davidslv/checkout.py

A checkout written in Python

checkout.py's Issues

Small tips/questions

1. In python it can be problematic to have an object as default argument like a list [] or dict [] as you have in pricing_rules=[]. Because that part of the code only runs once and so that list will always be the same.
   https://github.com/Davidslv/checkout.py/blob/master/checkout.py#L6

2. I would try to load the list of products in the checkout init dynamically from a CSV file.
   https://github.com/Davidslv/checkout.py/blob/master/checkout.py#L12

3. For the list of products in memory, I suggest using a dictionary instead of a list, so that you can quickly access a product using their code.
   https://github.com/Davidslv/checkout.py/blob/master/checkout.py#L12

4. To calculate the sum of discounts you could use something similar to what you did in the total.
   total -= sum(rule.discount(self) for rule in self.pricing_rules)
   https://github.com/Davidslv/checkout.py/blob/master/checkout.py#L24

   4.1. Also I would only pass the basket instead of the checkout instance.

5. In the Bulk Discount, why are you saving storing the t_item?
   https://github.com/Davidslv/checkout.py/blob/master/bulk_discount.py#L12

6. In the Bogof Discount, was it for a specific product? I thought all items could have this discount.
   https://github.com/Davidslv/checkout.py/blob/master/bogof_rule.py#L6

So, no big tips on the code man. Everything looks pythonic ;)