db-ui/theme-builder

theme-builder's Issues

Theme builder: icons w/o enough contrast

Change the `fill` color from the outside of SVG images via CSS Custom Properties.

          you could easily change the `fill` color from the outside of SVG images via CSS Custom Properties.

Originally posted by @mfranzke in #411 (comment)

That's as well how we do it for illustrative icons.

missing `checks-done`

As checks-done step is missing, PRs would get merged even if one of the steps fails:
https://github.com/db-ui/theme-builder/actions

warnings during `build`

several warnings come up during npm run build:

warnings when minifying css:
▲ [WARNING] Expected identifier but found whitespace [css-syntax-error]

    <stdin>:21533:14:
      21533 │   font-family: function bold() { [native code] };
            ╵               ^


▲ [WARNING] Unexpected "bold(" [css-syntax-error]

    <stdin>:21533:24:
      21533 │   font-family: function bold() { [native code] };
            ╵                         ~~~~~


▲ [WARNING] Expected identifier but found "[" [css-syntax-error]

    <stdin>:21533:33:
      21533 │   font-family: function bold() { [native code] };
      

Use latest DB UI mono version

you're currently using version 0.0.36, which still includes the font-face local reference problem.

Solid button incorrect

On https://db-ui.github.io/theme-builder/feat-generate-colors-by-palette/ the solid button looks incorrect, as a text variant actually in this case.

It both seems to get overwritten by global styles that are nowhere to be found (like e.g. button, [type=button], [type=reset], [type=submit]) as well as some styles by DB UI Mono are missing (only primary, outlined and text included, but the background-color for solid is missing; how could this miss incrementally?) that would regularly let this button appear correctly on https://db-ui.github.io/mono/version/v0.0.61/components/button/overview

Checkbox & radio error state gets incorrect background colors

Both invalid radio and checkbox elements get an incorrect (valid) background colors.

tailwind: No optimization in place

Currently it seems like that we're delivering the whole tailwind garbage within the CSS file and none of the optimizations seems to be in place: https://tailwindcss.com/docs/optimizing-for-production