CPU Halt on 5160 Boot

[dbalsom]

CPU Halt on 5160 Boot

[dbalsom]

FE0AB implies the register test failed. That really shouldn't happen at any clock speed...

can you open the "CPU State" window after the halt and screenshot it for me?

also please set the environment variable RUST_LOG to
trace,naga=error,wgpu_core=error

and attach the console log? Thanks

[dbalsom]

Great, yeah, I finally got time to look at the instruction trace log , it just looked like the wrong ROM order. The CPU register test should be one of the first few instructions executed but there were thousands of instructions executed before it in the log.

I should be more explicit about the use of the rom_override function in the config. Hopefully with the fixed ROM documentation, more people won't struggle with this.

Thanks for the report and making the log for me!

[graphixillusion]

@dbalsom here:

https://imgur.com/a/VFC9zkz

console log:

[2023-07-03T21:52:40Z DEBUG marty_core::config] toml_config: ConfigFileParams { emulator: Emulator { basedir: "./", autostart: true, headless: false, fuzzer: false, warpspeed: false, correct_aspect: true, debug_mode: false, no_bios: false, run_bin: None, run_bin_seg: None, run_bin_ofs: None, trace_on: false, trace_mode: Cycle, trace_file: None, video_trace_file: None, video_frame_debug: false, pit_output_file: None, pit_output_int_trigger: true }, gui: Gui { gui_disabled: false, theme_color: Some(3681625) }, input: Input { reverse_mouse_buttons: false }, machine: Machine { model: IBM_XT_5160, rom_override: Some([RomOverride { path: "./roms/BIOS_5160_09MAY86_U19_62X0819_68X4370_27256_F000.BIN", address: 983040, offset: 0, org: Normal }, RomOverride { path: "./roms/BIOS_5160_09MAY86_U18_59X7268_62X0890_27256_F800.BIN", address: 1015808, offset: 0, org: Normal }]), raw_rom: false, turbo: false, video: CGA, hdc: Xebec, drive0: Some("dos330.vhd"), drive1: None, floppy0: None, floppy1: None }, cpu: Cpu { wait_states_enabled: true, off_rails_detection: false, instruction_history: false }, validator: Validator { vtype: Some(Arduino8088), trigger_address: Some(1048560), trace_file: Some("./traces/validator_trace.log") } }
Found floppy image: "./floppy\\8088MPH (Final Version).img" size: 737280
Found floppy image: "./floppy\\Area 5150 (Compo Version).img" size: 737280
Found floppy image: "./floppy\\cgacomp.img" size: 737280
Found floppy image: "./floppy\\FreeDOS 1.3 Disk 1 (Boot me).img" size: 368640
Found floppy image: "./floppy\\FreeDOS 1.3 Disk 2.img" size: 368640
Found floppy image: "./floppy\\Marty Utilities.img" size: 368640
Found floppy image: "./floppy\\Microsoft DOS 3.31 (3.5).img" size: 1474560
Found floppy image: "./floppy\\Ratillery (CGA).img" size: 368640
Found floppy image: "./floppy\\Stellar Roads (CGA).img" size: 368640
Found VHD image: "./hdd\\dos330.vhd" size: 21412352
[2023-07-03T21:52:40Z INFO  wgpu_hal::vulkan::instance] Instance version: 0x4030f1
[2023-07-03T21:52:40Z INFO  wgpu_hal::vulkan::instance] Enabling device properties2
[2023-07-03T21:52:40Z INFO  wgpu_hal::gles::egl] Unable to open libEGL: Library(LoadLibraryExW { source: Os { code: 126, kind: Uncategorized, message: "Impossibile trovare il modulo specificato." } })
[2023-07-03T21:52:41Z DEBUG wgpu_hal::vulkan::adapter] Supported extensions: ["VK_KHR_swapchain", "VK_KHR_swapchain_mutable_format", "VK_EXT_robustness2"]
[2023-07-03T21:52:41Z DEBUG martypc] wgpu using adapter: Intel(R) HD Graphics 530, backend: Vulkan
[2023-07-03T21:52:41Z DEBUG martypc] Given machine type IBM_XT_5160 got machine description: MachineDescriptor { machine_type: IBM_XT_5160, system_crystal: 14.318181818181818, timer_crystal: None, bus_crystal: 14.318181818181818, cpu_type: Intel8088, cpu_factor: Divisor(3), cpu_turbo_factor: Divisor(2), bus_type: Isa8, bus_factor: Divisor(1), timer_divisor: 12, have_ppi: true, kb_controller: Ppi, pit_type: Model8253, pic_type: Single, dma_type: Single, conventional_ram: 1048576, conventional_ram_speed: 200.0, num_floppies: 2, serial_ports: true, serial_mouse: true }
[2023-07-03T21:52:41Z DEBUG marty_core::cpu_808x] Setting TraceLoggingEnabled(false) to: false
[2023-07-03T21:52:41Z DEBUG marty_core::cpu_808x] Setting OffRailsDetection to: false
[2023-07-03T21:52:41Z TRACE marty_core::machine] Sample rate: 48000 pit_ticks_per_sample: 24.857958333333332
[2023-07-03T21:52:41Z DEBUG marty_core::rom_manager] [ROM OVERRIDE] Reloading rom file: ./roms/BIOS_5160_09MAY86_U19_62X0819_68X4370_27256_F000.BIN
[2023-07-03T21:52:41Z DEBUG marty_core::rom_manager] [ROM OVERRIDE] Mounted rom "./roms/BIOS_5160_09MAY86_U19_62X0819_68X4370_27256_F000.BIN" at location 0F0000
[2023-07-03T21:52:41Z DEBUG marty_core::rom_manager] [ROM OVERRIDE] Reloading rom file: ./roms/BIOS_5160_09MAY86_U18_59X7268_62X0890_27256_F800.BIN
[2023-07-03T21:52:41Z DEBUG marty_core::rom_manager] [ROM OVERRIDE] Mounted rom "./roms/BIOS_5160_09MAY86_U18_59X7268_62X0890_27256_F800.BIN" at location 0F8000
[2023-07-03T21:52:41Z DEBUG marty_core::cpu_808x] Setting EnableWaitStates to: true
[2023-07-03T21:52:41Z DEBUG marty_core::cpu_808x] Setting InstructionHistory to: false
[2023-07-03T21:52:41Z DEBUG marty_core::cpu_808x] Setting TraceLoggingEnabled(false) to: false
[2023-07-03T21:52:41Z DEBUG martypc] Current monitor resolution: 1920x1080
[2023-07-03T21:52:41Z DEBUG martypc] Resizing window to 768x576
[2023-07-03T21:52:41Z DEBUG martypc] Reiszing render buffer to 768x472
[2023-07-03T21:52:41Z DEBUG martypc] Resizing pixel buffer to 768x576
[2023-07-03T21:52:41Z DEBUG marty_core::vhd_manager] Associating vhd: dos330.vhd to drive: 0
[2023-07-03T21:52:41Z INFO  marty_core::vhd] VHD Creator: [109, 114, 116, 121] (mrty)
[2023-07-03T21:52:41Z INFO  marty_core::vhd] VHD Creator Version: 00010000
[2023-07-03T21:52:41Z INFO  marty_core::vhd] VHD Creator OS: [87, 105, 50, 107] (Wi2k)
[2023-07-03T21:52:41Z INFO  marty_core::vhd] VHD Geometry: c:615 h:4 s:17
[2023-07-03T21:52:41Z INFO  marty_core::vhd] VHD UUID: 93bff6fb-5b45-478b-9947-caaf2cb1c0a3
[2023-07-03T21:52:41Z INFO  martypc] VHD image "dos330.vhd" successfully loaded into virtual drive: 0
[2023-07-03T21:52:41Z DEBUG martypc] Resizing pixel surface to 960x720
[2023-07-03T21:52:41Z INFO  martypc] CPU clock has changed to 4.7727272727272725Mhz; new cycle target: 79545
[2023-07-03T21:52:41Z TRACE marty_core::devices::ppi] PPI: Write to command port: 89
[2023-07-03T21:52:41Z TRACE marty_core::cpu_808x::execute] Halted at [FE0AB]
[2023-07-03T21:52:41Z ERROR marty_core::machine] CPU Halted!
[2023-07-03T21:52:41Z ERROR marty_core::machine] CPU Error: The CPU was halted at address: 0FE0AB.

[2023-07-03T21:52:41Z WARN  marty_core::machine] Instruction returned 0 cycles

[dbalsom]

That's... weird. Ok, can you set trace_on = true, trace_mode = "Instruction" and trace_file = "./traces/instr_trace.log" in the martypc.toml file and run it again? then attach the resulting 'instr_trace.log'

it should be a fairly short log generated due to the fact you're halting so early. but this will log all the instructions and the register state after each, i should be able to get a better idea of what's going on from that.

[graphixillusion]

@dbalsom 28MB log. i've zipped and upped here:

https://gofile.io/d/ilbJ30

[graphixillusion]

@dbalsom I just want to report that according to the updated Roms Wiki page i've tried this rom instead the old one

df9f29de490d7f269a6405df1fed69b7 *BIOS_5160_09MAY86_U19_62X0819_68X4370_27256_F000.BIN --> NO ERROR

and the CPU Halt error doesn't occur. So maybe this rom which was listed before is wrong?

f051b4bbc3b60c3a14df94a0e4ee720f *BIOS_5160_09MAY86_U19_62X0819_68X4370_27256_F000.BIN --> CPU HALT ERROR

[dbalsom]

Interesting; it shouldn't have let you load a bad rom - unless were you putting them in rom_override in the config?

[graphixillusion]

Interesting; it shouldn't have let you load a bad rom - unless were you putting them in rom_override in the config?

Yep i did the override becouse with the bad roms it will always load the opensource bios. Now i've tried disablind the override and it loads the correct ones anyways.