Implement linting via github actions

[dbt-athena]

Implement linting via github actions

[nicor88]

Thanks for the issue. What you suggested sounds good to me, except mypy I have black and isort in all my private repos, and I use flake8 for code checks.
When working on a local development, pre-commit is a must, then we can add another Github action to run exactly the same checks of the pre-commit. Generally I have a make check locally called in the pre-commit, and the same command is called in the CI.

Regarding tests we need to differentiate at least 2 types:

• unit testing: I was thinking pytest and moto to mock api calls, or simple response mocking with monkeypatch
• integration tests: we can run simple dbt models against a real AWS account, or ideally we can use localstack.

[jankatins]

poetry or pip? Is poetry ok?

I would start with just linting and leave running unit testing for later as it is not yet defined.

(another thing for later: adding a release pipeline however that should look like)

[nicor88]

Yeah fine let's split a bit up and covering linting first.
I'm fine with Poetry, @thenaturalist any objections?

[Jrmyy]

I am also fine with Poetry.

If I sum we want :

• Poetry for dependency management
• Flake8 for code check
• Black and isort for linting
• Pre-commit to ensure smooth developer experience

Am I missing something @nicor88 @jankatins ?

I have some time right now, I can start working on that as soon as we release 1.0.4 and 1.3.0 versions 👍🏻

[nicor88]

@Jrmyy seems all good. I checked other official providers and seems that poetry is not used. Let's stick with pip for consistency across other adapters. Wdyt?

[Jrmyy]

LGTM to keep pip to be consistent with the other adapters 👍🏻