de-mh/g2p_fa

A Grapheme to Phoneme model using LSTM implemented in pytorch

g2p_fa's Issues

IndexError in tensor2IPA when last value of tensor is not 'END'

I encountered an issue while using the g2p_fa library where I received the following error message:

IndexError: index 30 is out of bounds for dimension 0 with size 30

This error occurs in the tensor2IPA function in utils.py (line 54). Upon investigation, I found that the error arises when the last value of the tensor is not 'END', leading to an out-of-bounds index access.

I believe this issue might stem from two possible scenarios:

1. The input word might be larger than the predefined size, causing the model to produce a tensor with a length greater than expected.
2. In the call function of g2p_fa.py, tensor2IPA receives the argmax of the model output. If the model fails to predict correctly and the output lacks the 'END' token, it leads to the mentioned IndexError.

I suggest exploring solutions such as handling variable-sized inputs gracefully like sentences or adding a mechanism to detect the end of the predicted sequence more reliably, even in cases where the model prediction is incorrect.

Would it be possible to implement these changes to improve the library's robustness?

Thank you for your attention to this matter.

Best regards