Filtering messages without logging errors

[deancording]

Filtering messages without logging errors

[DeanCording]

Thanks Bart, I'm in two minds about this. On the one hand, the Assert node is for testing and the messages it filters out should be rare exceptions that occur from something being wrong. Therefore it should always log the error. Using it as a message filter is misuse of the node. On the other hand, a message filter is very useful and the current switch node is a bit limited. I'm more inclined to make a separate Filter node that is based on Assert but is better suited to filtering. Give me a couple of days. Dean On Thursday, 29 December 2016 1:34:00 PM AEST bartbutenaers wrote: Hey Dean, your Assert node is very useful in my current setup, for filtering messages based on all kind of values. However, my logs are being polluted by the errors that are logged by the Assert node. Is it possible to turn off the error logging of this node (without having to change the log level of the entire flow) in some way? For example a checkbox on the node's properties view to 'disable logging', would be sufficient ... Hope to hear from you soon.Kind regards,Bart Butenaers —You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub[1], or mute the thread[2].[3]

…

-------- [1] #2 [2] https://github.com/notifications/unsubscribe-auth/ AAPVImmX4amCFG7eH36v_MnYMQRsAuaTks5rNCdIgaJpZM4LX2_h [3] https://github.com/notifications/beacon/AAPVInnnoNBJrG41kLgNEJ7-tBF8z--4ks5rNCdIgaJpZM4LX2_h.gif

[bartbutenaers]

Hey Dean,

I understand what you mean. When talking about an 'Assert' as a developer, it indeed reminds me at raising an exception when some condition is not fulfilled (e.g. unit testing). So it totally makes sense that you would separate it into a 'Filter' node. Perhaps the 'Assert' node can be some kind of thin wrapper around the 'Filter' node, that just raises an exception when the filter node doesn't find a match?

Thank you for your help! Looking forward to review your solution.
Best wishes for 2017.

Bart

[bartbutenaers]

Hey Dean,

If I can be of any help (e.g. by creating a pull request) to the development of your new Filter node, don't hesitate to let me know how I can assist you!

Kind regards,
Bart Butenaers

[DeanCording]

Thanks Bart, I haven't forgotten. I'll have something for you in the next couple of days. Dean On Thursday, 9 February 2017 3:54:18 AM AEST bartbutenaers wrote: Hey Dean, If I can be of any help (e.g. by creating a pull request) to the development of your new Filter node, don't hesitate to let me know how I can assist you! Kind regards,Bart Butenaers —You are receiving this because you commented.Reply to this email directly, view it on GitHub[1], or mute the thread[2].[3]

…

-------- [1] https://github.com/DeanCording/node-red-contrib-assert/issues/ 2#issuecomment-278621252 [2] https://github.com/notifications/unsubscribe-auth/AAPVImNsUNYGBPupLBjJK1-AzQ1O8p4Aks5rav5qgaJpZM4LX2_h [3] https://github.com/notifications/beacon/ AAPVIhvFk6wMlFdmZMHusdsgUox1eUxAks5rav5qgaJpZM4LX2_h.gif

[DeanCording]

Ok, sorry for the delay. Have a look at node-red-contrib-match - it sends messages out the first output if they match all the rules or out the second output if any rule fails.

Dean

[bartbutenaers]

Thanks a lot Dean.
Great contribution! Just what I was looking for.

Kind regards,
Bart