deanwombourne/node-diawi

Node library to upload to Diawi

node-diawi's Issues

Scale polling duration based on app size

Diawi says poll for 1 second per 10MB uploaded app size. Currently, this library just polls 10 times.

Write Some Tests

There should probably be some tests in this module, currently there are none.

It never emits "success" event

It only emits "complete" event.

Add support for optional parameters

i.e. from the Diawi docs:

Optional parameters

• find_by_udid (true/false as 1/0): allow your testers to find the app on Diawi's mobile web app using their UDID (iOS only)
• wall_of_apps (true/false as 1/0): allow Diawi to display the app's icon on the wall of apps
• password (string): protect your app with a password: it will be required to access the installation page
• comment (string): additional information to your users on this build: the comment will be displayed on the installation page
• callback_url (URL as string): the URL Diawi should call with the result This won't work with this library - it's going to poll.
• callback_emails (emails as string): the email addresses Diawi will send the result to (up to 5 separated by commas for starter/premium/enterprise accounts, 1 for free accounts)
  installation_notifications (true/false as 1/0): receive notifications each time someone installs the app (only starter/premium/enterprise accounts)

(https://dashboard.diawi.com/docs/apis/upload)

Missed a bit in the instructions

Hi,
Took me a while to get this to run via node script, because the sample code should be:

var Diawi = require("diawi");

new Diawi({ token: "api token", path: "path/to/app.ipa" })
  .on("complete", function(url) { ... })
  .on("error", function(error) { ... })
  .execute();

It's missing the execute()

Other than that, great work!

Regards,
Andy

Better error message if attempting to upload archive not zip

Currently you just get Failed: Error: Error: form-data: EISDIR: illegal operation on a directory, read which isn't very helpful. It would be nice to intercept this and return something like This seems to be a directory - if this is your .xcarchive please zip it first.

or, ideally, we could zip and upload for the user :)