Giter Site home page Giter Site logo

politeiagui's People

Contributors

alexlyp avatar amass01 avatar blaltarriba avatar crypto-rizzo avatar dajohi avatar davecgh avatar degeri avatar dependabot[bot] avatar derekdkim avatar dornelasnelson avatar fernandoabolafio avatar go1dfish avatar gozart1 avatar hypernoob avatar jholdstock avatar lukebp avatar marcopeereboom avatar oktapodia avatar orthomind avatar rgeraldes avatar richardred0x avatar rrecuero avatar shubham-skr avatar sndurkin avatar thi4go avatar tiagoalvesdulce avatar tnguyen303 avatar vctt94 avatar vibros68 avatar victorgcramos avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

politeiagui's Issues

Markdown preview isn't working

The markdown preview area doesn't seem to be working.

Steps to reproduce:

  1. Navigate to the new proposal page in Chrome.
  2. Type # Test in the markdown editor.

Expected to see a header "Test" in the markdown preview area, but nothing is shown and there are no JS errors in the console.

Load Markdown editor on demand

react-markmirror is a very nice Markdown editor, but it's 500kb built.

Ideally we should only load it once the user visits the submission creation page

MVP: prevent attaching images beyond max size

i added a larger image (~628 KB) to a proposal and it printed an error about how the image was too large. this should be prevented up-front if possible, so the user cannot upload an image with size greater than the max size.

MVP: add user profile view

users will need to be able to do stuff like reset their password, set their username, add an avatar, etc.

having a simple page for performing these actions is a start and can be expanded later.

receive and verify bundle after proposal submission

the censorship token amounts to a signature from a particular pi instance confirming that a proposal submission has been received. instead of having users lookup their proposal by id or censorship token to check its status, the user should be prompted to download a "proposal bundle", which would contain all the censorship data, along with the file(s) that make up the proposal.

beyond prompting the user to download a proposal bundle, there needs to be a simple tool that users can run to verify a censorship token is valid. this is important not only for the user being censored, but also other users who wish to verify the proposal in question was indeed censored.

Refreshing on Submit page takes you to the Login page

After logging in to Politeia, it should take you /proposals/new. If you refresh while on the page, it will navigate to the /user/login page. It should stay on the /proposals/new page.

Similarly, refreshing on /admin/censored and /admin/unreviewed takes you to the home page.

Better error/success messages

We need better error/success messages. Just from light testing I noticed we need better messages for:

  • /user/verify/success
  • /user/verify/failure
  • /login

There are probably others as well.

Proposal submission success page

#81

Currently pgui redirects user to their proposal’s permalink after successful submission.

API no longer returns a users unvetted proposals so we will need to add a page that replicates proposal detail with the data from the successfully submitted proposal (should be in the proposal request’s payload and response in state)

Attaching files on the new proposal page wipes any existing attachments

Clicking the file input to attach files wipes any existing file attachments on the new proposal page. I can only select multiple files if I select them all within the file selector dialog, but I should be able to attach multiple files, one at a time, from multiple accesses of the file selector dialog.

Change Password page issues

The Change Password page has several visual issues that need addressing:

  • The error display overlaps with the sidebar on the right side of page
  • The inputs and button should look and be organized like the inputs on the signup/login page

remove public access to unvetted proposals

when proposals are first submitted, they are considered in the 'unvetted' state and must be manually reviewed by someone who checks that a number of basic requirements are satisfied. since proposals that are unvetted or currently in the process of being vetted could contain inflammatory content, we must deprive users of the ability to externally access this data while a proposal is unvetted. this avoids the scenario of pi being used to effectively serve inflammatory content, albeit via an indirect channel.

as part of fixing this, the censorship token lookup widget in the ui would be removed. users who submit proposals that are ultimately censored should be able to independently verify that their proposal was indeed received and not made public with its censorship token alone. by allowing lookups against a censorship token, whoever is hosting the pi instance may end up inadvertently hosting inflammatory content.

Login issues

  • When logged in, menu still displays Login instead of Logout
  • After first logging in, it should redirect to either the Submit or Home page

MVP: add ability to remove images

since a user may add then wish to remove an image for a proposal, they need a corresponding button/link to do this. currently, you can only add images.

Need loading indicators

Loading indicators should be displayed for the proposal submit page and when executing the censor/approve admin actions.

MVP: improve error handling

when i attempted to submit a new proposal, i received the near-useless error message "Error creating proposal, Bad response from server". errors should be less vague and include details that allow users to make a meaningful bug report.

by requiring that a sysadmin check the logs or dig further for an error, it decreases the likelihood of the error condition being properly handled.

Markdown editor acts weird on Galaxy Note 8

A user reported in Slack that the markdown editor doubles certain words while typing.

Device: Galaxy Note 8
Browser: Chrome, Firefox

Using Chrome:

If I type "decred.o" and then "r", I get "decred.odecred.or"

"google.c" &"o" gives me google.cgoogle.co

Firefox seems to be worse:

Any time I hit space, comma, or period, the entire word just disappears!

The issue is reproducible using the base headzoo/react-markmirror component, but it's not as bad with the JedWatson/react-md-editor component. For JedWatson/react-md-editor:

it seems to delete periods the first time i type them. So "decred." becomes just "decred", but if I type the "." again it stays.

Export/import privkey

We need to be able to export the ed25519 private key from local storage. Let's debate options and add some sort of mechanism to allow the user to export end import said key.

MVP: submit tab should only appear when logged in

the submit tab is shown when the user is not logged in. this gives the impression that one can submit a proposal without registering with the site, which mismanages user expectations. the submit tab should only appear when users are logged in.

Submit page doesn't reset

After submitting a proposal and navigating to another page, the Submit page should reset and allow the user to submit another.

Need <PageLoadingIcon> component

Currently we're using <LoadingIcon> for page-to-page transitions, but that's not working well on the proposal detail page. We should create a <PageLoadingIcon> component which is used for page-to-page transitions, and is consistently displayed maybe 200 - 300px from the top of the page. This should be separate from <LoadingIcon> which should be easily embeddable into other components. Similarly, <ButtonWithLoadingIcon> should be refactored to use <LoadingIcon>.

Admin proposal status page should display the full proposal

The admin proposal page currently only displays the proposal title and the actions. Actually, this page could be removed and the actions could just be added to the proposal details page if the current user is an admin.

Also - actions should not appear if status == Censored.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.