defillama/defillama-app

defillama-app's Issues

Stride: Evmos and Injective Fee History

There are two days where Stride's EVMOS and INJ fees were miscalculated (see here). In particular, I think the denoms were incorrectly calculated on April 14th and 15th. Is there a way to forward-fill fees for Evmos and Injective on those days for Stride? The router is correctly calculated now (see this PR) so I think we only need to adjust those fees backwards-looking. If it's easier, we can also throw out all fees for Evmos and Injective until now.

Apologies, I'm not very familiar with the DefiLlama codebase, but if you can point me to this part of the repo, I'm also happy to submit a PR! Also apologies if this is the wrong repo to report this issue, I'm happy to repost elsewhere if that's better.

Thanks so much for the help, please let me know if I can help clarify.

Loader doesn't work

The loader is not working. indeed when I click on a link in the web app, there is no feedback that lets me think that I have made a click (which pushes me to click again and again) I just notice that it there's a new page that appears in front of me (when I'm attentive).
How to remedy this?

i see that there is already a PR open for this...please merge it. It's hard to navigate without a loader
#578

ps : sorry for the bad english

"Check the code" button not working

Check the code button redirects to Github 404

How to reproduce:

• Go to https://defillama.com/protocol/solend
• Click on "Check this code" under the Methodology section

There are some errors in your openapi.yaml for OpenAI Plugins.

Hello,

I noticed that you have submitted defillama to OpenAI Plugins.
However, I noticed that there are some error in your openapi.yaml.
Is there anyone who can fix them?

https://llamawrapper-prod.onrender.com/openapi.yaml

incorrect formatting of Round Up content when there are multiple segments

when there are multiple segments, for example,

1/2 News📰

⚠️ Ethereum Alarm Clock contract exploited
https://twitter.com/peckshield/status/1582756435955359744

...

2/2 Reads📚

SBF: current thoughts on crypto regulation
https://twitter.com/SBF_FTX/status/1582835426116575235

the 1/2 and 2/2 indicators will ruin the formatting on the website roundup page

Coingecko Issue

Chain page not working
I get this error when I try to start the "Chain" page

SyntaxError: Unexpected token < in JSON at position 0

And this is where I found the problem from the "getChainPageData" function

Maybe this is due to API get simple price glitch or some other reason
I think it is necessary to solve them or have a fallback method

Provide convencience buttons in charts

It would be nice as a complement to the existing timeline component where I can drag to choose a specific timeframe in a TVL chart to provide convenience buttons for fixed timeframes like Last 24 hours, Last month, YTD etc.

Inconsistent trade volume of Wombat Exchange

Hi DefiLlama's team,

I found that the TVL of Wombat Exchange is inconsistent: right side is ~3 bil, while left side is ~2 bil. Right side seems to have the correct number since it is what Wombat Subgraph returns (totalTradeVolumeUSD; protocol with id = 1 in https://thegraph.com/hosted-service/subgraph/wombat-exchange/wombat-exchange-bsc):

{
  "data": {
    "protocol": {
      "boostedRatio": "0.8475009493225679104402404997056709",
      "createdTimestamp": "1673416609",
      "id": "1",
      "lastUpdate": "1696848543",
      "network": "BSC",
      "totalBoostedTvlUSD": "16585122.24270364537002951499796613",
      "totalCashUSD": "29184917.3645072730734600445059978",
      "totalBribeRevenueUSD": "459497.1204152359117686787120471265",
      "totalCollectedFeeUSD": "214010.8615076372022459763183952743",
      "totalLiabilityUSD": "29657858.89525576780054838715076453",
      "totalSharedFeeUSD": "139630.1393333452487672786562995004",
      "totalTradeVolumeUSD": "3215759655.999092051518885902475963",
      "totalTvlUSD": "19569443.85249434187719452938480407",
      "version": "MasterWombatV3"
    }
  }
}

It seems like totalTvlUSD (for locked value) is used for the left side instead of totalTradeVolumeUSD. Can you guys fix this?

Many thanks!

Fix token name it's XRP not Ripple

Add max limit to portfolio folder name or truncate it

Allow viewing treasury chart without own tokens

Ideally by default the treasury chart does not display own tokens and maybe own tokens can be included via a checkbox.

'CHART_TYPES"

./src/components/GlobalNFTChart/index.js

15:29:15.886 | Attempted import error: 'CHART_TYPES' is not exported from '~/components/TradingviewChart' (imported as 'CHART_TYPES').
15:29:15.886 |  
15:29:15.886 | Import trace for requested module:
15:29:15.887 | ./src/components/GlobalNFTChart/index.js
15:29:15.887 | ./src/components/NFTDashboardPage/index.js

Trending contracts page not working

This is for both ethereum and polygon tabs.

Fee and Revenue

Show fees Chart, I think we should show chart so we can interact based on historical data of fees and revenue.

Here is the website link: Link to website

Adding protocol to watchlist does not work

Adding a protocol to watchlist does not work (or at least the protocol does not show up in the watchlist properly) when the protocol has multiple products associated with it. I have reproduced this with both Ribbon and Redacted. If I add a product individually, that works fine.

UI Bug : LongShortStrategy Page shows [object Object] in header

'peggedassets' is not a valid route

On the stablecoins page, in <nav/>, users can click on the "Pegged Assets" link but it goes to /peggedassets which is an invalid page route.

This also applies to any stablecoin details pages like /stablecoin/tether.

Decimals in days ago is a bit unfriendly

This view is from the Airdrops page. It may be found elsewhere too, haven't looked closely. The decimals look weird, it may be better to just drop them and instead have something like a tooltip next to the date that provides the exact time and date when you hover it.

Fee and Revenue Matters

Liquidity pool is less than $200k but fee is over 3 billion, I definitely have data or display problem

Play button on charts is misleading

Why does it look like play button? Should we change it to something closer to "reset" or <--> and show only when the chart was resized? Because right now I've just clicked on it for a few times without any action following.

Use get api error 403

Good afternoon everyone, I'm consuming the Defillama API with Node.js and Fetch, but when I try to execute the action, it generates a 403 error. From what I can see, the server hosting the API is using Cloudflare. Does anyone know how to solve this issue? Thank you.

The endpoint: https://api.llama.fi/lite/protocols2

Treasury shows up in chain breakdown

Seems weird since treasury is not really a chain

Sidebar overflows on page content

Screen width: 1470px

Please document where the entry definitions are

Even better, add an "Edit" link to each entry that points to the correct file on GitHub. That would've enabled me to submit a PR for DefiLlama/DefiLlama-Adapters#949 directly, instead of an issue.

show FDV/TVL in charts

currently there is only Mcap/TVL colume. It would be awesome to also show FDV/TVL to provide more comprehensive info, this is especially useful for the chains that has low Mcap/FDV ratio

update epns icon

hi team,

you'll find the new icon on our notion here

thank you!

Compound line graphs for TVL Chains & Tokens (USD)

Hey team!
I have a suggestion for better UX, that can be easily implemented.

We build an omnichain defi protocol and I think Chains & Tokens (USD) graphs on TVL tab can be displayed in better way.

Currently:

• Each chain's TVL is displayed as a separate graph, and each graph is superimposed on one another
• Y axis reflects only the biggest chain TVL (because line graphs are superimposed)

How it can be improved:

• Enable compounding for line graphs (see example below)
• Y axis will reflect the total TVL of the protocol across all chains

It can applied for all charts with USD denomination on Y axis (Chains, Tokens (USD), and others).
I really hope you consider and update line graphs configuration, because we are going to have 50+ chains integrated soon.

Clicking tabs on bridges resets scroll position

When you click on tabs scroll resets to top which is weird

[FR] Full-text search

Use case: I want to search for DEXes with "leverage".

Just going to the DEX category isn't sufficient. For example, it doesn't produce Mango Market, which is in the Lending category.

Change "Active Users" to "Active Addresses"

In chains: https://defillama.com/chains

There is the misleading statement of Active Users.

I know that if you scroll over the question mark it clarifies that they are active addresses.

But still, I believe it should clearly say active addresses as the difference is very significant.

People that quickly look at this chart could end up with the false idea that chain x has y active users, while in reality can be half of it.

Comparison page doesn't update query params in route when protocols are removed

There is another problem with this page, when a protocol is removed the query params in the route is not updated.

See:

Originally posted by @brenopolanski in #432 (comment)

UI bug - Stride Fees

Stride fees on the Cosmos chains page are different than the Stride fees on the Stride Protocol page.

The Stride Protocol page is correct, I believe the Cosmos chains page is only displaying Stride's fees from stATOM, whereas the Protocol page is correctly adding up fees from all of Stride's stTokens. The fees on the Cosmos chains page should be changed to match the Stride Protocol page.

Please let me know if I can help clarify further!

Cosmos chains page:

Stride Protocol Page:

Update Clearpool logo

Clearpool's current logo is

Elements floating in directory page

Allow adding protocols to watchlist via protocol view

The only way to add a protocol to the watchlist currently is to find it in its own category and click the flag next to it.

It would be nice to be able to add to watchlist directly via the protocol view. A couple of options I can think of:

1. add the flag icon next to the protocol logo, or
2. add a "Add to Watchlist" checkbox with the rest of the checkboxes
   

UI bug - Stride TVL

Stride's TVL shows up as 0 for random days (e.g. Feb 3-6 2023).

Unlocks shows non-meaningful information

Description:
in the unlocks page https://defillama.com/unlocks, it shows some not meaningful data, for example:

BLUR: A cliff of 0 BLUR ($0) tokens will unlock from community treasury on June 02, 2023 (in 2 months) - does it really need to show this when there is 0 token unlock?

SUSHI: Linear unlock will increase from 126,800 SUSHI ($137,451) to 126,800 SUSHI ($137,451) tokens per week from liquidity mining on April 30, 2023 (in 23 days) - seems like no increase at all

screenshot:

Broken links in Volumes/Chains

To replicate:

• Go to https://defillama.com/dexs/chains
• Look for zkSync Era, or zkSync Lite, or Polygon zkEVM (maybe there are more)
• Click on them and see it fails

In those cases the link is formatted as
https://defillama.com/dexs/chains/zksync-era
instead of
https://defillama.com/dexs/chains/zksync%20era

You can also see that the chart title is wrong: "Dexs volume in Zksync era" instead of "Dexs volume in zkSync Era"

Maybe the same issue is in the Fees/Revenue page

See the table columns: the function slug transforms zkSync Era to zksync-era for the link, for example.

Incorret dev metrics

e.g. https://defillama.com/protocol/aave

Weekly commits: 3

Monthly commits: 3

Weekly developers: 9

Montly developers: 1

Last commit date: 02/09/23

• Daily's Chart not working (cant derive daily data from weekly/monthly)
• Typo: #1573
• data is wrong
  • weekly cc & dev always more than monthly
  • some protocols (e.g. Osmosis) get around 1k weekly commits

add 3D viz and defillama github link

@0xngmi could you assign this to me?

tasks:

• add https://007vasy.github.io/ to the bottom of the overview page
• add defillama github link to the bottom left

{%_/.}

Show TVL chart per category

It would be great to be able to view historical TVL charts per category, eg., a TVL chart for NFT Lending

Revenue is Negative

I saw this data, revenue of arbitrum is negative, Can you guys take a look on that

Treasury data shows up only in a single adapter

According to ulysses in Discord, adding the treasury of a protocol into one of its adapters will show up in its overall page (when there are multiple adapters for a protocol). It does not seem to be the case with Ribbon.

1. Here we added the treasury logic in the main adapter
2. Treasury data shows up fine in the main adapter view
   
3. It does not show up in the Overall view
   

Round up page does not format Markdown.

The roundup page does not format any markdown rather it displays as a raw markdown from the API.

Help to Install

Hi sorry i have never installed such as file on my server. its my first time. Can anyone tell me step by step how to install this on my server ?

best regards

Link to CEX category returns 404

https://defillama.com/protocols/cex

Clickable from the protocol view, eg.,

Circular dependency issues

There are some circular dependency issues in defillama-app.

Circular dependencies (also known as cyclic dependencies) occur when two or more modules reference each other.
ref: https://spin.atomicobject.com/2018/06/25/circular-dependencies-javascript/

To detect this problem, I added the next-circular-dependency to next.config.js.

Circular dependency detected:
src/components/Charts/DominanceChart.tsx -> src/components/Charts/index.tsx -> src/components/Charts/DominanceChart.tsx

Circular dependency detected:
src/components/Charts/PeggedDominanceChart.tsx -> src/components/Charts/index.tsx -> src/components/Charts/PeggedDominanceChart.tsx

Circular dependency detected:
src/components/Charts/PeggedPieChart.tsx -> src/components/Charts/index.tsx -> src/components/Charts/PeggedPieChart.tsx

Circular dependency detected:
src/components/Charts/PieChart.tsx -> src/components/Charts/index.tsx -> src/components/Charts/PieChart.tsx

Circular dependency detected:
src/components/Charts/index.tsx -> src/components/Charts/PieChart.tsx -> src/components/Charts/index.tsx

Add MarketCap column

Hi, next to TVL and Mcap/TVL columns can you add a Mcap sortable column please? Thanks

feature: place to value all the crypto companies and their valuation

i think it would be cool if u could look into crypto companies - their valuation and more insights like maybe employees, past raises.