deloitteau/atlas

Atlas is the Deloitte Digital Framework for Sitecore Development

atlas's Issues

Merge "develop" to "master" and release new NuGet package version

Hi,
I'm trying to get Atlas to work with Sitecore 9 and it's all well and good except the LinkFieldRenderingString class still has some dependency to CommonServiceLocator. In Sitecore 9, CommonServiceLocator is still used, but reserved for Solr integration only. This breaks on any ViewModel class that uses ILinkFieldRenderingString. The fix for this has already merge to the "develop" branch. It would be great if it could be merged to master, and release a new version of NuGet package.

Thanks,
David Nguyen

Increase unit test coverage

The test coverage in the project is a little... basic. We should add unit test coverage across all Atlas components, especially the mapper / field rendering components.

Remove the LinkFieldStyle class and its dependcies

This class poses a very specific concern on a particular solution/implementation context and there fore shouldn't be held at the framework level. The full class name is DeloitteDigital.Atlas.FieldRendering.LinkFieldStyle.

IFieldRenderString methods are not as usable as they could be

In the IFieldRenderingString interface we have three methods, WithAttribute, DisableWebEdit, and DefaultValueIfEmpty.
These methods return IFieldRenderingString (the this), and were intended to be builder methods to let the user build up the desired behaviour, e.g.

MyField.DisableWebEdit().DefaultValueIfEmpty("I'm empty!");

When you use these methods you are coerced to IFieldRenderingString which can be annoying if your field was more derived, such as LinkFieldRenderingString.

These methods would be better as extension methods, that use a generic parameter constrained to IFieldRenderingString. i.e.

public static T DisableWebEdit<T>(this T field) where T : IFieldRenderingString

This would allow the builder pattern on any of the field rendering types that derive from IFieldRenderingString, without the coercion, e.g. after using DisableWebEdit() the field is still a LinkFieldRenderingString and not a boring old IFieldRenderingString.

Changing the interface is a breaking change. Adding equivalent extension methods would help, but any code that references Atlas would have to be recompiled.

Sometimes there's an exception thrown on first page request

(placeholder - detail to be added)

Stop the LogScope log spamming

LogScope emits Debug.WriteLine. We did this so we could see the logs while debugging.

The SitecoreTraceListener then writes the trace to the sitecore log file as well, results in duplicate logs.

I suggest the Debug.Write are removed.

GetItemUrl returns invalid url

I had a list of articles to be retrieved as I found out that for some of articles, url is mydomain.com/articles/article1 but for some other is like /sitecore/content/home/articles/article1

So I changed
return LinkManager.GetItemUrl(item);
With
return LinkManager.GetItemUrl(item, UrlOptions.DefaultOptions);

using the security disabler in an Item Extension method is unexpected

In one of the item extensions
public static Item GetFieldValueAsItem(this Item item, string fieldName)

securityDisabler is used. I would suggest that If someone needs SecurityDisabler they can useit in their own code.

https://github.com/DeloitteDigitalAPAC/Atlas/blob/a411197a8f3eb1d0b52030e95d2a843dff53cb3f/src/DeloitteDigital.Atlas/Extensions/ItemExtensions.cs#L166-L176

HtmlAgilityPack version mismatch with Sitecore

Atlas is built against HtmlAgilityPack 1.4.9.5 but Sitecore ships with an earlier version. You currently need to manually install v 1.4.9.5 and add an assembly redirect.

This should be rectified, either by:

• taking a proper NuGet dependency on 1.4.9.5
• using the version that Sitecore ships with (TBC, potential code change?)

Rework ExecuteRendererAndHideOnException to be a IRendererErrorStrategy instead

Sitecore introduced the concept of IRendererErrorStrategy. Instead of swapping out the ExecuteRenderer processor, we should move the functionality to a RendererErrorStrategy.

Binding of Rendering Parameters other than type Bool or String is not supported

We have the need to use a Rendering Parameter template with a field of type GeneralLink.

Binding this field using a var of type IFieldRenderingString returns Null and using a var of type string, returns the xml for the link field.

We need a IFieldRenderingString or a Link object to be able to be returned so that it can be rendered and/or properties retrieved