Comments (5)
the real solution would be to not need a spinner, by using a virtual list for this, there is already an issue for this: #1830
Show group members (only slow on first load)
It's not slow for me, how many group members do you have? under which circumstances? what means "first load" (app or dialog?)?
Also I prefer skeleton items to a spinner.
from deltachat-desktop.
Cool, I'll change the title then. Agree that we should look into the root of the problem first.
the real solution would be to not need a spinner, by using a virtual list for this, there is already an issue for this: #1830
I'm looking at a 800ms loading delay for opening the ViewGroup
dialog for the first time, rendering ca. 30 contacts, not sure if a virtual list is a solution to this problem. Maybe we have different issues in different dialogs?
I've tried hooking in the React Debugger into the Electron Extensions to do some profiling but it didn't work out on first attempt (not sure what's the issue yet). So far I could only use the default Dev Tool profiler. It's clear that the bottleneck sits in the frontend code from looking at it, but without the React Debugger we will not easily find out where, or my source maps are not working ..
from deltachat-desktop.
Ah, I think I found the issue, at least for the ViewGroup
dialogue. Probably also this issue only pops up when doing a development build:
There's invalid HTML in ViewGroup
which causes React to throw an error when opening the component for the first time:
"react-dom.development.js:67 Warning: validateDOMNesting(...): <p> cannot appear as a descendant of <p>."
After fixing the invalid element the dialog opens faster ✨
from deltachat-desktop.
After fixing the invalid element the dialog opens faster ✨
Thats btw indirectly fixed by #3627
from deltachat-desktop.
I'm closing this now as the other dialog's issue is discussed in #1830
from deltachat-desktop.
Related Issues (20)
- chat does not scroll down after forwarding
- Update UPDATE_CORE documentation HOT 1
- the title on adding subsequent profiles should read "Add Profile", not "Welcome"
- overridden sender name property for outgoing/self messages not displayed
- Skip fill peer connections if webxdc internetAccess is allowed HOT 2
- Allow opening maps of multiple chats HOT 2
- Change map default dimensions to be bigger and landscape instead of portrait
- Visual bug in search result list HOT 3
- Switch to `save_msg_file()` + `MessageObject::file_name` for saving attachments HOT 1
- CI: Mac preview build fails
- Readme still mentions `deltachat-node`
- Map doesn't open HOT 8
- instant onboarding: adapt title of "Privacy Policy" link
- "I already have a profile" dialog doesn't vanish after adding client as second device
- Formatting issues in Russian for scan QR code HOT 1
- Three dots become inactive when opening tabs to the right from Audio HOT 2
- A bug with date of audio messages in Russian HOT 4
- Settings should be closable in sub-pages with escape key HOT 2
- WAV files are not displayed in the audio tab HOT 1
- Plural rules are not followed for many languages HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from deltachat-desktop.