demotu/detecta

A Python module to detect events in data

detecta's Issues

ZENODO citation

Hi @demotu,
can you please make your code citable via ZENODO? There are some journals not accepting your way how to cite your repository since GitHub is not considered as a FAIR compliant data repository.

Thanks a lot

exception is thrown when passing ax argument in detect_cusum with show=True

When passing ax argument to detect_cusum with show=True an exception is raised in the following line:

Steps to reproduce:
fig, ax = plt.subplots(2, figsize=(10,5)) # set the size that you'd like (width, height) alarm_indices, anomaly_start_indices, anomaly_end_indices, amp = detect_cusum(data, threshold, drift, True, show=True, ax=ax)
Will result in the following error:
UnboundLocalError: local variable 'ax1' referenced before assignment

detecta/detecta/detect_cusum.py

Line 153 in 08c0a1c

ax1.plot(t, x, 'b-', lw=2)

The reason is self explanatory and is clearly seen in the code - question is if you remove the ax argument from detect_cusum method or fix the _plot implementation to accept and use indices instead of ax1 and ax2