denismasterherobrine/magicalforest

Magical Forest is a mod which brings a new biome into Minecraft 1.15.2+. Inspired by Thaumcraft 4.

I'm Denis, a part-time freelancer developer doing random stuff since 2015 🪐

• 🔭 I’m currently working as Java Junior Developer at SHIELD.LAND.

• 🌱 I’m currently an active Minecraft modder and pack developer. Can do comissioned mods and modpacks.

• ❓ Ask me about nearly anything about space, modding games, integrations and some other stuff related to Java.

• 🌑I like doing space-related projects from time to time and I wish to step on Mars at least one time in this life.

• 😄 I usually have some fun with VR, Unreal Engine and sometimes AI.

My Skill Set

Frontend

Backend

DevOps

Connect with Me

GitHub Stats

magicalforest's Issues

Suggestion for 1.19.2

This biome should be the home of the allay, they should spawn here not too commonly to keep them from being too abundant, It'd be a simple change to give players a reason to visit here often

MagicalForest Compatibility

Terralith will replace MagicalForest bio

Port to 1.16.x (Mod is in frozen state, not abandoned, but no active development yet)

This is issue regarding 1.16.x port of Magical Forest.
Currently it's hard to implement without PR about biome hook: MinecraftForge/MinecraftForge#6990

After merging this PR I'll rework the biome a bit

Terrablender fails to generate biomes

When using this mod with other biome related mods, it seems terrablender gets confused with biome names.

[13:13:14] [main/FATAL]: Failed to start the minecraft server
java.lang.IllegalStateException: Feature order cycle found, involved biomes: [net.minecraft.class_1959@235dd97b, net.minecraft.class_1959@9e60054, net.minecraft.class_1959@e878155, net.minecraft.class_1959@2e430cc6]
	at net.minecraft.class_1966.method_39525(class_1966.java:130) ~[server-intermediary.jar:?]
	at net.minecraft.class_1966.<init>(class_1966.java:65) ~[server-intermediary.jar:?]
	at net.minecraft.class_1966.<init>(class_1966.java:58) ~[server-intermediary.jar:?]
	at terrablender.worldgen.TBMultiNoiseBiomeSource.<init>(TBMultiNoiseBiomeSource.java:74) ~[TerraBlender-fabric-1.18.1-1.1.0.73.jar:?]
	at terrablender.worldgen.TBMultiNoiseBiomeSource$Preset.biomeSource(TBMultiNoiseBiomeSource.java:144) ~[TerraBlender-fabric-1.18.1-1.1.0.73.jar:?]
	at terrablender.worldgen.TBMultiNoiseBiomeSource$Preset.biomeSource(TBMultiNoiseBiomeSource.java:149) ~[TerraBlender-fabric-1.18.1-1.1.0.73.jar:?]
	at terrablender.api.WorldPresetUtils.chunkGenerator(WorldPresetUtils.java:110) ~[TerraBlender-fabric-1.18.1-1.1.0.73.jar:?]
	at terrablender.api.WorldPresetUtils.overworldChunkGenerator(WorldPresetUtils.java:48) ~[TerraBlender-fabric-1.18.1-1.1.0.73.jar:?]
	at net.minecraft.class_5285.handler$doa000$onCreate(class_5285.java:567) ~[server-intermediary.jar:?]
	at net.minecraft.class_5285.method_28021(class_5285.java:232) ~[server-intermediary.jar:?]
	at net.minecraft.class_3806.method_37371(class_3806.java:92) ~[server-intermediary.jar:?]
	at net.minecraft.server.Main.main(Main.java:173) [server-intermediary.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:608) [fabric-loader-0.12.12.jar:?]
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:77) [fabric-loader-0.12.12.jar:?]
	at net.fabricmc.loader.impl.launch.knot.KnotServer.main(KnotServer.java:23) [fabric-loader-0.12.12.jar:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) ~[?:?]
	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
	at java.lang.reflect.Method.invoke(Method.java:568) ~[?:?]
	at net.fabricmc.loader.impl.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:66) [fabric-loader-0.12.12.jar:?]

world gen is not happening version 1.19.2

I get this error every time i try to create a world. I will wait 1 hour and no progress is done on the world gen so i end up stopping the the task and this is the error i find in the log before the world gen stops.

com.alcatrazescapee.cyanide.codec.FeatureCycleDetector$FeatureCycleException: A feature cycle was found.

i have a bunch of biome mods so i cant tell where the issues is occuring exactly. but i am using cyanide for better world gen info

this is everthing world gen related:

at com.alcatrazescapee.cyanide.codec.FeatureCycleDetector.buildFeaturesPerStep(FeatureCycleDetector.java:141) ~[cyanide-forge-1.19.2-3.0.1.jar%23560!/:3.0.1]
at net.minecraft.world.level.biome.FeatureSorter.handler$dni000$buildFeaturesPerStepWithAdvancedCycleDetection(FeatureSorter.java:529) ~[client-1.19.2-20220805.130853-srg.jar%23777!/:?]
at net.minecraft.world.level.biome.FeatureSorter.m_220603_(FeatureSorter.java) ~[client-1.19.2-20220805.130853-srg.jar%23777!/:?]
at com.teamabnormals.blueprint.common.world.modification.ModdedBiomeSlicesManager.lambda$onServerAboutToStart$3(ModdedBiomeSlicesManager.java:108) ~[blueprint-1.19.2-6.2.0.jar%23504!/:6.2.0]
at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:183) ~[guava-31.0.1-jre.jar%23121!/:?]
at net.minecraft.world.level.chunk.ChunkGenerator.m_213609_(ChunkGenerator.java:397) ~[client-1.19.2-20220805.130853-srg.jar%23777!/:?]
at net.minecraft.world.level.chunk.ChunkStatus.m_223313_(ChunkStatus.java:145) ~[client-1.19.2-20220805.130853-srg.jar%23777!/:?]
at net.minecraft.world.level.chunk.ChunkStatus.m_223279_(ChunkStatus.java:292) ~[client-1.19.2-20220805.130853-srg.jar%23777!/:?]
at net.minecraft.server.level.ChunkMap.lambda$scheduleChunkGeneration$25(ChunkMap.java:621) ~[client-1.19.2-20220805.130853-srg.jar%23777!/:?]
at com.mojang.datafixers.util.Either$Left.map(Either.java:38) ~[datafixerupper-5.0.28.jar%23126!/:?]
at net.minecraft.server.level.ChunkMap.lambda$scheduleChunkGeneration$27(ChunkMap.java:619) ~[client-1.19.2-20220805.130853-srg.jar%23777!/:?]
at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1150) ~[?:?]
at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:482) ~[?:?]
at net.minecraft.server.level.ChunkTaskPriorityQueueSorter.m_143188_(ChunkTaskPriorityQueueSorter.java:62) ~[client-1.19.2-20220805.130853-srg.jar%23777!/:?]
at net.minecraft.util.thread.ProcessorMailbox.m_18759_(ProcessorMailbox.java:91) ~[client-1.19.2-20220805.130853-srg.jar%23777!/:?]
at net.minecraft.util.thread.ProcessorMailbox.m_18747_(ProcessorMailbox.java:146) ~[client-1.19.2-20220805.130853-srg.jar%23777!/:?]
at net.minecraft.util.thread.ProcessorMailbox.run(ProcessorMailbox.java:102) ~[client-1.19.2-20220805.130853-srg.jar%23777!/:?]
at java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(ForkJoinTask.java:1395) ~[?:?]
at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?]
at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?]
at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?]
at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?]
at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?]

here are the biome mode that im aware of (might have some mods that add biomes that im unaware of):
deep aether
the aether redux
autuminity
alex cave
alex mobs
amplified nether
ars nouveau
atmospheric
born in chaos
deeper and darker
ecologics
enviromental
evil craft
garden of the dead
nullscape
nyctophobia
tectonic
the aether
the abyss 2
the graveyard
twilight forest
the undergarden
tropicraft
voidscape

[1.18.2 suggestion] Add your biomes to biome tags for best compat

Hello, I am the dev for Repurposed Structures. I had noticed an issue with a few biome mods in 1.18.2 that my mod's structures and datapack structures are not spawning in the modded biomes.

In 1.18.2, Mojang allowed any worldgen registry to have tags. Including biomes. They then improved the json system for creating worldgen structures which now uses biome tags for what biomes to spawn in. As a result, biome mods not using these tags will not spawn modded or json structures that uses biome tags.

I have more info here along with resources on what biome tags are available to use and add to.
https://gist.github.com/TelepathicGrunt/b768ce904baa4598b21c3ca42f137f23

Just ask me if you get stuck or need help. The biome tags would go under /data//worldgen/biome/ folder

In this case, I think you just need to add to minecraft:is_forest biome tag and you're golden!

Version-Problem with TerraBlender...

Hello,
while testing your MOD, minecraft stopped loading with the following funny message:

Failure message: Mod magicalforest requires terrablender 1.18.2-1.1.0.99 or above
Currently, terrablender is 1.2.0.126

only MODs I used in this test are "TerraBlender-forge-1.18.2-1.2.0.126" and "MagicalForest-forge-1.18.2-2.0.3", and not to forget "Forge 40.2.0"
when I use "TerraBlendeer-forge-1.18.2-1.1.0.102" (or lower till "1.1.0.99") then there are no problems and minecraft starts normal.

EDIT: found another little funny Problem... see the screenshots (Tested with one instance with many mods, so I thougt, incompatibilty with any of the mods but as you can see in the second screenshot, with only MagicalForest and TerraBelnder as installed MODs) its absolutely the same, the magical forest is somewhere under water, at least at this spot. The seed for this is: "645384553566719240" the Position is absolutely the same, as you can see in the screenshots. [Maybe thats why Thaumcraft couldn't come to newer Versions of MineCraft... :) )

Registration to forge tag

Magical forest biome is not registered at forge:is_magical tag.

freeze/crash on load on certain worlds

with this mod it crashes/freezes world gen but doesnt really generate a crash log it might be trying to load this mods biome and breaking

Feature Cycle (crash), with Magical Forest + Tectonic

This was reported to me (alcatrazEscapee/cyanide#15), but Cyanide just caught the feature cycle and displayed the issue.

• Crash Log: crash-2023-01-29_10.11.00-client.txt
• Minecraft 1.18.2
• Magical Forest MagicalForest-forge-1.18.2-2.0.3.jar
• Tectonic tectonic-mod-mc1.18.2-v1.1.3.jar

The feature cycle:

Feature 'tectonic:common/seagrass_land'
  must be before 'tectonic:common/grass/patch_grass_dense' (defined in 'tectonic:old_growth_evergreen_forest' at index 5, 6 and 9 others)
  must be before 'minecraft:brown_mushroom_taiga' (defined in 'minecraft:taiga' at index 4, 5)
  must be before 'minecraft:red_mushroom_taiga' (defined in 'byg:frosted_taiga' at index 4, 5 and 10 others)
  must be before 'minecraft:patch_grass_plain' (defined in 'magicalforest:magical_forest' at index 7, 8)
  must be before 'minecraft:flower_meadow' (defined in 'magicalforest:magical_forest' at index 8, 9)
  must be before 'tectonic:common/seagrass_land' (defined in 'minecraft:meadow' at index 3, 4 and 1 others)

• Note that the byg:frosted_tagia is not necessary, as this ordering is also defined by Tectonic in it's override of minecraft:tagia

Basically

• Tectonic defines tectonic:common/seagrass_land before minecraft:brown_mushroom_tagia, and after minecraft:flower_meadow, in two separate places.
• Magical forest defines these vanilla features in the opposite order.
• Vanilla, as far as I can see, does not a priori define an ordering between these.

Also reported as Apollounknowndev/tectonic#14

---

MagicalForest/src/main/java/dev/denismasterherobrine/magicalforest/biome/MagicalForestBiomeDecorator.java

Line 66 in 004305e

// I really now hate feature cycle in 1.18... is there anything providing a feature cycle documentation?

As a side note, TelepathicGrunt has written up a lovely blurb on what a feature cycle is, which I shall copy paste below if you find it of interest. The TL;DR is "always order features as they are in vanilla and if not make sure you're always putting your own features in a consistent order w.r.t any vanilla features."

Here’s why feature cycles are a thing. When the game goes to generate a chunk, it collects all the biomes in that chunk, then grabs all the placedfeatures from all the biomes, and then generates them. Now say two biomes have birch trees in them and are in the same chunk. We should not just both biomes birch tree PlacedFeature together because then at the border of these biomes, the density of birch trees would be doubled

So instead, we consolidate this list of PlacedFeatures to not have duplicates of the exact same placedfeature instances.

Here’s where the feature cycle issue comes in

Biome 1 has a lake before birch tree in its generation stage. Biome 2 has birch tree before lake in its generation stage.

When the game consolidates the PlacedFeatures into a list of what to spawn for that chunk with both biomes, which feature should generate first?

And that there is the issue. Mojang decided this should be a crash.

Only way this can be resolved easily is to force all biomes to have the features in the same order in relation to other features. So if one biome has lakes before birch trees, so do all the other biomes. It came be in different generation stages as long as the lake is still before the birch tree.

Though this becomes complex if you’re shuffling PlacedFeatures in different stages as then the cycle could involve many PlacedFeatures

Better to keep them in the same generation stage and same order across all biomes for simplicity and easier checking.

Again, to be clear, the cycle is between instances of the placedfeature. So if a lake and tree is out of order, it doesn’t mean all lakes and all trees. Just that specific lake placedfeature and specific tree placedfeature is out of order

From MMD Discord

Feature cycle crash with Terralith and BYG with 'minecraft:flower_warm'

Using 1.19.2 with Forge 43.2.0, Oh_The_Biomes_You'll_Go-forge-1.19.2-2.0.1.0, TerraBlender-forge-1.19.2-2.0.1.136, and Terralith_v2.3.4.

Cycle:
At step 9
Feature 'minecraft:flower_warm'
must be before 'minecraft:patch_grass_savanna' (defined in 'minecraft:savanna' at index 3, 4 and 6 others)
must be before 'minecraft:patch_grass_taiga_2' (defined in 'byg:maple_taiga' at index 2, 3)
must be before 'minecraft:brown_mushroom_taiga' (defined in 'terralith:yosemite_cliffs' at index 2, 3 and 21 others)
must be before 'minecraft:red_mushroom_taiga' (defined in 'terralith:yosemite_cliffs' at index 3, 4 and 22 others)
must be before 'minecraft:patch_grass_taiga' (defined in 'byg:frosted_coniferous_forest' at index 5, 6 and 3 others)
must be before 'minecraft:patch_dead_bush' (defined in 'byg:frosted_coniferous_forest' at index 6, 7 and 8 others)
must be before 'terralith:highlands/arid/bushes' (defined in 'terralith:arid_highlands' at index 2, 3)
must be before 'minecraft:flower_warm' (defined in 'terralith:arid_highlands' at index 3, 4)

at com.alcatrazescapee.cyanide.codec.FeatureCycleDetector.buildFeaturesPerStep(FeatureCycleDetector.java:141) ~[cyanide-forge-1.19.2-3.0.1.jar%23319!/:3.0.1]
at net.minecraft.world.level.biome.FeatureSorter.handler$bgi000$buildFeaturesPerStepWithAdvancedCycleDetection(FeatureSorter.java:529) ~[client-1.19.2-20220805.130853-srg.jar%23414!/:?]
at net.minecraft.world.level.biome.FeatureSorter.m_220603_(FeatureSorter.java) ~[client-1.19.2-20220805.130853-srg.jar%23414!/:?]
at com.teamabnormals.blueprint.common.world.modification.ModdedBiomeSlicesManager.lambda$onServerAboutToStart$3(ModdedBiomeSlicesManager.java:108) ~[blueprint-1.19.2-6.1.0.jar%23288!/:6.1.0]
at com.google.common.base.Suppliers$NonSerializableMemoizingSupplier.get(Suppliers.java:183) ~[guava-31.0.1-jre.jar%23112!/:?]
at net.minecraft.world.level.chunk.ChunkGenerator.m_213609_(ChunkGenerator.java:397) ~[client-1.19.2-20220805.130853-srg.jar%23414!/:?]
at net.minecraft.world.level.chunk.ChunkStatus.m_223313_(ChunkStatus.java:145) ~[client-1.19.2-20220805.130853-srg.jar%23414!/:?]
at net.minecraft.world.level.chunk.ChunkStatus.m_223279_(ChunkStatus.java:292) ~[client-1.19.2-20220805.130853-srg.jar%23414!/:?]
at net.minecraft.server.level.ChunkMap.lambda$scheduleChunkGeneration$25(ChunkMap.java:621) ~[client-1.19.2-20220805.130853-srg.jar%23414!/:?]
at com.mojang.datafixers.util.Either$Left.map(Either.java:38) ~[datafixerupper-5.0.28.jar%23117!/:?]
at net.minecraft.server.level.ChunkMap.lambda$scheduleChunkGeneration$27(ChunkMap.java:619) ~[client-1.19.2-20220805.130853-srg.jar%23414!/:?]
at java.util.concurrent.CompletableFuture$UniCompose.tryFire(CompletableFuture.java:1150) ~[?:?]
... 11 more

1.18.2 version of this causes ae2 meteors not to spawn

Applied Energistics 2
thetechnici4n
appliedenergistics2-forge-11.7.4.jar

Continents
Starmute
Continents_1.18.2_v1.1.2.jar

Cristel Lib
Cristelknight
cristellib-forge-1.0.0.jar

Explorer's Compass
Chaosyr
ExplorersCompass-1.18.2-1.3.0-forge.jar

TerraBlender (Forge)
TheAdubbz
TerraBlender-forge-1.18.2-1.1.0.102.jar

Terralith

are all involved I'm unsure of updating too
TerraBlender-forge-1.18.2-1.2.0.126.jar
will fix the issue but if you could it would be great

[fabric 1.18] the biome is way too common

the weight is set to 1 and i have a lot of other biomes, but really, these biomes are huge and that's the most common biome in my worlds...