deno-libs/gql

☁ Universal GraphQL HTTP middleware for Deno

gql's Issues

Oak server example not working

Issue

Hey there, I was playing around with the oak-example. Unfortunately this isn't working as it shows the following error when I either make a request or attempt to retrieve the schema. Any ideas what the example needs?

Dependencies

{
    "x/oak": "https://deno.land/x/[email protected]/mod.ts",
    "x/gql": "https://deno.land/x/[email protected]/mod.ts",
    "x/graphql_tag": "https://deno.land/x/[email protected]/mod.ts",
    "esm/graphql-tools": "https://esm.sh/@graphql-tools/[email protected]",
}

Aligning all versions to what is in the example file also has no effect on the error being displayed

Logs

☁  Started on http://localhost:9000 
Error: Expected { __validationErrors: undefined, description: undefined, extensions: {}, astNode: { kind: "SchemaDefinition", operationTypes: [Array] }, extensionASTNodes: [], _queryType: Query, _mutationType: undefined, _subscriptionType: undefined, _directives: [@include, @skip, @deprecated, @specifiedBy], _typeMap: { Query: Query, String: String, Boolean: Boolean, __Schema: __Schema, __Type: __Type, __TypeKind: __TypeKind, __Field: __Field, __InputValue: __InputValue, __EnumValue: __EnumValue, __Directive: __Directive, __DirectiveLocation: __DirectiveLocation }, _subTypeMap: {}, _implementationsMap: {} } to be a GraphQL schema.
    at Q (https://esm.sh/v117/[email protected]/deno/type/schema.js:2:843)
    at W (https://esm.sh/v117/[email protected]/deno/type/validate.js:2:891)
    at a (https://esm.sh/v117/[email protected]/deno/graphql.js:2:863)
    at https://esm.sh/v117/[email protected]/deno/graphql.js:2:483
    at new Promise (<anonymous>)
    at R (https://esm.sh/v117/[email protected]/deno/graphql.js:2:466)
    at runHttpQuery (https://deno.land/x/[email protected]/common.ts:28:16)
    at eventLoopTick (ext:core/01_core.js:165:11)
    at async https://deno.land/x/[email protected]/http.ts:91:22
    at async handleGraphQL (~/edge/supabase/functions/graphql/index.ts:37:15)

Docs example doesnt work

The example on the "deno" page of the repo (https://deno.land/x/[email protected]) doesnt work. The correct version of this is on the deno blog: https://deno.com/blog/build-a-graphql-server-with-deno. The problem is that the addr parameter in the new Server() doesnt work anymore and instead just port: 3000 or any other port should be passed.
Pls fix soon as this confuses A LOT of people.
Greetings, Alex

Incompatible with Apollo GraphQL Sandbox?

Is it possible to use the https://studio.apollographql.com/sandbox/explorer instead of graphiql?

I tried to use it from this library, but it seems that the Apollo Server (3) differs because I could not connect to the GraphQL server through the localhost URL.

Does anyone know what it would need to work?

Doc: https://www.apollographql.com/docs/apollo-server/testing/build-run-queries/

Is there support for Upload and subscriptions?

Documentation Example Failing

import { Server } from 'https://deno.land/[email protected]/http/server.ts'
import { GraphQLHTTP } from 'https://deno.land/x/gql/mod.ts'
import { makeExecutableSchema } from 'https://esm.sh/@graphql-tools/[email protected]'
import { gql } from 'https://deno.land/x/[email protected]/mod.ts'

const typeDefs = gql`
  type Query {
    hello: String
  }
`

const resolvers = { Query: { hello: () => `Hello World!` } }

const s = new Server({
  handler: async (req) => {
    const { pathname } = new URL(req.url)

    return pathname === '/graphql'
      ? await GraphQLHTTP<Request>({
          schema: makeExecutableSchema({ resolvers, typeDefs }),
          graphiql: true
        })(req)
      : new Response('Not Found', { status: 404 })
  },
  addr: ':3000'
})

s.listenAndServe()

Output from the terminal:

error: Uncaught SyntaxError: The requested module '/v111/[email protected]/deno/graphql.js' does not provide an export named 'GraphQLError'
    at <anonymous> (https://esm.sh/v111/@graphql-tools/[email protected]/deno/utils.js:2:1183)

405 and CORS

Hello,
I have a server configured with http as follows:

const handler = async (req: Request) => {
    const { pathname } = new URL(req.url);

    return pathname === "/graphql"
      ? await GraphQLHTTP<Request, Context>({
          schema: makeExecutableSchema({
            resolvers,
            typeDefs: [center, student, instructor, group, scalars],
          }),
          graphiql: true,
          context: () => {
            return { request: req };
          },
        })(req)
      : new Response("Not Found", { status: 404 });
  };

  const server = new Server({ handler });
  const listener = Deno.listen({ port: parseInt(PORT) });

  console.info("Listening on", listener.addr);

  await server.serve(listener);

When I use the graphiql playground it works just fine, but when using from any other client I get 2 erros:

• Request Method: OPTIONS Status Code: 405 Method Not Allowed
• CORS

How could I fix this? Thanks for your time.

Context is an empty object with Oak

I am following the updated oak example but trying to inject my own context object, inside the resolver the context is an empty object and there are no errors in the console

import { ServerRequest } from  "https://deno.land/x/[email protected]/mod.ts"

interface ResolverContext<T> {
  // user is added to context if possible in @auth directive
  user?: User;
  stripe: StripeClient;
  request: T
}

  app.use((ctx) => GraphQLHTTP<ServerRequest>({
    schema,
    graphiql: true,
    context: (request): ResolverContext<ServerRequest> => {
      return { request, stripe }
    }
  })(ctx.request.originalRequest as ServerRequest));

i have a simple hello world resolver which logs the context

// TEMP hello world resolver
const helloResolver = {
  Query: {
    hello: (_args: {}, ctx: ResolverContext<ServerRequest>) => {
      console.log({ ctx })
      return "world"
    }
  }
}

{ ctx: {} }

Additionally the typescript typings are incorrect for the GraphQLHTTP<ServerRequest>. Typescript complains about

error: TS2344 [ERROR]: Type 'ServerRequest' does not satisfy the constraint 'Request<ParamsDictionary, any, any>'.
  Type 'ServerRequest' is missing the following properties from type 'Request<ParamsDictionary, any, any>': accepts, acceptsCharsets, acceptsEncodings, acceptsLanguages, and 29 more.
  app.use((ctx) => GraphQLHTTP<ServerRequest>({

Some issue with xss dependency hash in deno.lock

Hello, I use [email protected]. Type checks on github actions started to fail. Is it related to the gql lib or esh.sh? Would be great to get any help about this.

Download https://esm.sh/xss
Download https://deno.land/x/[email protected]/graphiql/markup.ts
Download https://esm.sh/[email protected]
Download https://esm.sh/v131/[email protected]/deno/cssfilter.mjs
Download https://esm.sh/v131/[email protected]/deno/xss.mjs
Download https://esm.sh/v131/[email protected]/typings/xss.d.ts
error: The source code is invalid, as it does not match the expected hash in the lock file.
  Specifier: https://esm.sh/[email protected]
  Lock file: /home/runner/work/bromo/bromo/deno.lock

Headers are not getting set

It appears there is currently no way to set cors headers on the responses. I am using opine middleware and the graphql response is sent immediately, without running the middleware afterwards

`validationRules` support

Would be awesome!

I see that graphql-http supports Deno and also validationRules, but I'm being lazy at the moment and don't feel like changing my GraphQL setup.

Oak Example Not Working

Hi,

This is great but the oak example does not work.

Valid Accept header should include `*/*` instead of just `text/html`!

This line is causing the postman software to error, as it sends */* as the default Accept header.

There should also be a ?raw=true query parameter check to see if graphiql should not be served, regardless of option parameter.

gql/http.ts

Line 24 in 7d78b41

if (request.headers.get('Accept')?.includes('text/html')) {