Giter Site home page Giter Site logo

Comments (2)

DenverCoder1 avatar DenverCoder1 commented on May 17, 2024

Using htmlspecialchars() to escape the the lines seems to be a sufficient fix.

I'll just need to double check that there's nothing in SVGs that needs to be treated separately.

Output with running htmlspecialchars on each line:

...
<textPath xlink:href='#path1'>
  Second line of &lt;/textPath&gt;&lt;/text&gt;&lt;script&gt;alert(&quot;xss?&quot;)&lt;/script&gt;&lt;text&gt;&lt;textPath&gt;
</textPath>
...

Example SVG with new code

Changes (currently in xss-fix branch): ff76298

from readme-typing-svg.

DenverCoder1 avatar DenverCoder1 commented on May 17, 2024

Thanks for your help @plamoni!

With #8, I think it should be safe now.

from readme-typing-svg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.