PD007, PD008, PD009 should not use node.value.attr

[deppen8]

PD007, PD008, PD009 should not use node.value.attr

[simchuck]

Not sure what is going on here.

import ast

stmt = "df.loc[:, ['B', 'A']]"
tree = ast.parse(stmt)
node = tree.body[0].value

print(type(node))
print(node.value.attr)

This gives the following output:

<class '_ast.Subscript'>
loc

[simchuck]

I added the instance checks for the ast.Subscript check functions (ix, at, iat). Also found a typing error in the parameters for the at and iat functions.

I pushed my new commit, but I don't think the changes fixed the flake8 error.

[simchuck]

It seems like the error is coming from the import check now...

[simchuck]

Sorry, I meant the "inplace" check.

[deppen8]

Think I cracked this. ast.Subscript can be either a Name or Attribute and they don't have matching attributes.

If node.value is ast.Name, use node.value.id. If node.value is ast.Attribute, use node.value.attr.

This type uncertainty might be something we run into elsewhere as well so we should remember this.

PR to fix is incoming

[deppen8]

Closed by #51