designforcontext / aac_review_tool Goto Github PK

View Code? Open in Web Editor NEW

5.0 5.0 7.0 18.23 MB

License: MIT License

Ruby 1.52% Perl 1.18% CSS 8.48% JavaScript 88.54% HTML 0.28%

aac_review_tool's People

Contributors

Stargazers

Watchers

Forkers

szeke craigknoblock vladimiralexiev autry-cataloger onzali jjmhtp

aac_review_tool's Issues

mapping of Bibliographic Reference

Where is the mapping for Bibliographic Reference? I can't see it, I see only Catalogue Raisonné.

I think the mapping of both should be:

<object> is documented in <reference>, <CatalogueRaisonné>.
<reference> a Document; rdf:label "description"; 
  has_type aat:300311954. # reference (référence bibliographique)
<CatalogueRaisonné>a Document; rdf:label "description";
  has_type aat:300026061. # Catalogue Raisonné

Document is more appropriate than Linguistic Object (which means a piece of text): surely catalogs also have pictures.

american-art/cbm#52 says to use 300026497 bibliographies "Lists of books, documents, and other bibliographical items". But this concept is wrong for this purpose: that piece of data describes a single document, not a List.
The right concept is 300311954 reference (référence bibliographique) (that is a <document by function>)

Problem with mapping of Death

I expected to see:

?death_event in SELECT

but instead I saw:

?death_class in SELECT

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?death_class ?display_deathdate ?earliest_deathdate ?latest_deathdate ?death_location ?death_location_class
WHERE {
<http://collection.britishmuseum.org/id/person-institution/70240> a crm:E39_Actor ;
    crm:P93i_was_taken_out_of_existence_by ?death_event.
?death_event a crm:E64_End_of_Existence.
OPTIONAL { 
  ?death_event crm:P4_has_time-span ?death_timespan.
  ?death_timespan a crm:E52_Time-Span;
        crm:P82a_begin_of_the_begin ?earliest_deathdate;
        crm:P82b_end_of_the_end ?latest_deathdate;
  OPTIONAL { ?death_timespan rdfs:label ?display_deathdate.}
}
OPTIONAL {
  ?death_event crm:P7_took_place_at ?death_location_class .
  OPTIONAL {
    ?death_location_class a crm:E53_Place;
              rdfs:label ?death_location.
  }
}

}

Problem with mapping of Sort Name

I expected to see:

?sort_type is not defined

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?sort_name ?sort_type ?name_class
WHERE {
<http://collection.britishmuseum.org/id/person-institution/70240> a crm:E39_Actor ;
  crm:P131_is_identified_by ?sort_name_class .
?sort_name_class a crm:E82_Actor_Appellation ;
  rdf:value ?sort_name ;
  crm:P2_has_type  <http://vocab.getty.edu/aat/300404672> .
OPTIONAL {
  ?sort_name_class crm:P139_has_alternative_form ?name_class.
}

}

Problem with mapping of Object ID

I expected to see:

E42_Identifier to have property(rdf:value) set to an

but instead I saw:

E42_Identifier to has both property (rdf:value and rdfs:label) set to an

Query has rdfs:value instead of rdf:value
?identifier_url a crm:E42_Identifier ;
rdfs:value ?identifier ;
crm:P2_has_type http://vocab.getty.edu/aat/300404621 .

Problem with mapping of Alternate IDs

I expected to see:

Below set selection under MINUS blocks seems wrong.
MINUS { <http://data.americanartcollaborative.org/ima/object/id/62748> crm:P2_has_type <http://vocab.getty.edu/aat/300404621>}
MINUS { <http://data.americanartcollaborative.org/ima/object/id/62748> crm:P2_has_type <http://vocab.getty.edu/aat/300312355>}
MINUS { <http://data.americanartcollaborative.org/ima/object/id/62748> crm:P2_has_type <http://vocab.getty.edu/aat/300404670>}

I feel that it should be...

MINUS { ?identifier_url crm:P2_has_type <http://vocab.getty.edu/aat/300404621>}
MINUS { ?identifier_url crm:P2_has_type <http://vocab.getty.edu/aat/300312355>}
MINUS { ?identifier_url crm:P2_has_type <http://vocab.getty.edu/aat/300404670>}

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?identifier ?identifier_type_label ?identifier_url
WHERE {
<http://data.americanartcollaborative.org/ima/object/id/62748> a crm:E22_Man-Made_Object .
<http://data.americanartcollaborative.org/ima/object/id/62748> crm:P1_is_identified_by ?identifier_url .
?identifier_url a crm:E42_Identifier ;
  rdfs:label ?identifier ;

MINUS { <http://data.americanartcollaborative.org/ima/object/id/62748> crm:P2_has_type <http://vocab.getty.edu/aat/300404621>}
MINUS { <http://data.americanartcollaborative.org/ima/object/id/62748> crm:P2_has_type <http://vocab.getty.edu/aat/300312355>}
MINUS { <http://data.americanartcollaborative.org/ima/object/id/62748> crm:P2_has_type <http://vocab.getty.edu/aat/300404670>}

OPTIONAL {
 ?identifier_url crm:P2_has_type ?identifier_type .
 OPTIONAL {
   ?identifier_type skos:prefLabel ?identifier_type_label .
 } 
}

}

Problem with mapping of Responsible Department

Reference diagram is missing from the website.

Problem with mapping of Event Name

?event_type to be used in place of http://vocab.getty.edu/aat/300404670

I expected to see:

SELECT ?event_name ?event_class ?type_label
WHERE {
http://data.thewalters.org/exhibition/id/2851 a crm:E5_Event ;
crm:P1_is_identified_by ?event_class .
?event_class a crm:E41_Appellation ;
rdf:value ?event_name ;
crm:P2_has_type ?event_type.
?event_type a crm:E55_Type .
OPTIONAL {
OPTIONAL {?event_type skos:broadMatch http://vocab.getty.edu/aat/300404670 .}
OPTIONAL {?event_type skos:prefLabel ?type_label. }
}
}

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?event_name ?event_class ?type_label
WHERE {
<http://data.thewalters.org/exhibition/id/2851> a crm:E5_Event ;
  crm:P1_is_identified_by ?event_class .
?event_class a crm:E41_Appellation ;
  rdf:value ?event_name ;
  crm:P2_has_type <http://vocab.getty.edu/aat/300404670> .
<http://vocab.getty.edu/aat/300404670> a crm:E55_Type .

OPTIONAL {
  OPTIONAL {<http://vocab.getty.edu/aat/300404670> skos:broadMatch <http://vocab.getty.edu/aat/300404670> .}
  OPTIONAL {<http://vocab.getty.edu/aat/300404670> skos:prefLabel ?type_label. }
}

}

Problem with mapping of Credit Line

For Object 34753...
I expected to see:

Museum purchase with funds provided by the Eddie and Sylvia Brown Challenge Grant, matching funds, and the estate of Anna Fehl, for the acquisition of African American Art, 2004

but instead I saw:

Nothing/Blank

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?credit_line ?credit_line_class
WHERE {
{
  <http://data.thewalters.org/object/34753> a crm:E22_Man-Made_Object ;
    crm:P67i_is_referred_to_by ?credit_line_class .
  ?credit_line_class a crm:E33_Linguistic_Object;
    crm:P2_has_type <http://vocab.getty.edu/aat/300026687> ;
    rdf:value ?credit_line .
}
 

}

Problem with mapping of Creation Date

I expected to see:

[between 1751 and 1752]

but instead I saw:

I SAW NOTHING!]

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://erlangen-crm.org/current/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>

SELECT ?display_date ?earliest_date ?latest_date ?production_event
WHERE {
<http://collection.britishart.yale.edu/id/object/499> a crm:E22_Man-Made_Object.
{
  <http://collection.britishart.yale.edu/id/object/499> crm:P108i_was_produced_by ?production_event .
} UNION {
  ?production_event crm:P108_has_produced <http://collection.britishart.yale.edu/id/object/499> .
} UNION {
  <http://collection.britishart.yale.edu/id/object/499> crm:P108i_was_produced_by ?intermediate_event .
  ?intermediate_event crm:P9_consists_of ?production_event .
}
?production_event a crm:E12_Production ;
  crm:P4_has_time-span ?production_timespan. 
?production_timespan a crm:E52_Time-Span.
OPTIONAL {
  {
   ?production_timespan crm:P82a_begin_of_the_begin ?earliest_date.
   ?production_timespan crm:P82b_end_of_the_end ?latest_date.
  } UNION {
    ?production_timespan crm:P82_at_some_time_within ?earliest_date.
    ?production_timespan crm:P82_at_some_time_within ?latest_date.
  }
}
OPTIONAL {
  {
    ?production_timespan crm:P3_has_note ?display_date. 
  } UNION {
    ?production_timespan skos:prefLabel ?display_date. 
  } UNION {
    ?production_timespan rdfs:label ?display_date. 
  }
}

}

Distinction bw Preferred ID and Object ID

Please cite some examples from any museum data, so as to distinguish these fields.

Problem with mapping of Alternate Titles

I expected to see:

Identifier for Title modeled similar to Primary Title

but instead I saw:

Identifier for AlternateTitle isn't modeled

Replace Actor Appellation with Appellation in v1.1

Per http://www.cidoc-crm.org/sites/default/files/minutes%20of%2037th%20meeting%20Berlin%20%28draft%29.pdf
page 12, the SIG has decided to delete E82 Actor Appellation.

We should thus just use a regular Appellation when we need to model the name of a resource as a resource in its own right.

mapping of contributors other than main Creator

As american-art/DMA#2 shows, there are roles different from main Creator or Artist: eg Engraver.

The mapping should specify how to map such roles.
BM does that with production sub-events:

The contributor role is mapped to an event type, eg in this case P2_has_type aat:300053225 "Engraving"

Problem with mapping of Alternate Titles

I expected to see:

?alternate_title_type_class isn't related to other parts of query

but instead I saw:

MINUS{?alternate_title_type_class crm:P2_has_type http://vocab.getty.edu/aat/300404012 .}

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?title_text ?title_class ?alternate_title_type ?alternate_title_type_class
WHERE {
<http://data.thewalters.org/object/id/39053> a crm:E22_Man-Made_Object .
<http://data.thewalters.org/object/id/39053> crm:P102_has_title ?title_class .
?title_class a crm:E35_Title ;
  rdf:value  ?title_text .
OPTIONAL {
 ?title_class crm:P2_has_type ?title_text_class . 
 ?title_text_class a crm:E55_Type ;
   skos:prefLabel ?alternate_title_type .
}
MINUS{?alternate_title_type_class crm:P2_has_type <http://vocab.getty.edu/aat/300404012> .}

}

Medium uses wrong AAT concept

You map Medium to aat:300264237 "material components" which has such curious children as atoms, electrons, eggshell, ossein (bone material) etc. How does "oil on canvas" fit in here?

Use aat:300163343 "medium (artists' materials)".

Furthermore, representing medium/material as Linguistic Object makes no sense to me at all.

Actor LOD identifier mapping

@azaroth42:
The Actor LOD identifier mapping goes eg like this:

<http://data.americanartcollaborative.org/autry/maker/abeytatony>
  skos:exactMatch ulan:500126291.
ulan:500126291 skos:inScheme ulan: .

However, people are not concepts. A better mapping is

<http://data.americanartcollaborative.org/autry/maker/abeytatony>
  owl:sameAs ulan:500126291-agent.

Problem with mapping of Preferred Identifier

I expected to see:

rdf:value

but instead I saw:

rdfs:value

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?identifier ?identifier_url
WHERE {
<http://collection.britishmuseum.org/id/person-institution/70240> a crm:E39_Actor .
<http://collection.britishmuseum.org/id/person-institution/70240> crm:P1_is_identified_by ?identifier_url .
?identifier_url a crm:E42_Identifier ;
  rdfs:value ?identifier ;
  crm:P2_has_type <http://vocab.getty.edu/aat/300404670> .

}

"Submit an issue" should open new tab

@workergnome Great tool!
The "Submit an issue" link should open a new tab, else I lose my context all the time

Query is using wrong property "rdfs:value" instead of "rdf:value"

Hi,

For accession number, http://review.americanartcollaborative.org/entity/E22_Man-Made_Object#field_26-search_0 below is the query used on the review site but it is using property "rdfs:value". It should be "rdf:value".


SELECT ?identifier ?identifier_url
WHERE {
<http://data.americanartcollaborative.org/ima/object/id/62748> a crm:E22_Man-Made_Object .
<http://data.americanartcollaborative.org/ima/object/id/62748> crm:P1_is_identified_by ?identifier_url .
?identifier_url a crm:E42_Identifier ;
`  rdfs:value ?identifier ;`
  crm:P2_has_type <http://vocab.getty.edu/aat/300312355> .
}

why use rdf:value?

@workergnome @azaroth42
http://review.americanartcollaborative.org/entity/E39_Actor:
Why use rdf:value? CRM doesn't specify the use of this property, and I don't know any provider who uses it.
Use crm:P3_has_note (as per CRM spec) or rdfs:label (also sort of accepted by CRM SIG)

Sort Name should be P139i not P139

http://review.americanartcollaborative.org/entity/E39_Actor#field_1-search_0

  ?sort_name_class crm:P139_has_alternative_form ?name_class.

Just what is ?name_class here? If that's meant to be the main (natural-order) name, inverse the relation because "It is a dynamic asymmetric relationship, where the range expresses the derivative"

need ext prop Extent

@azaroth42 CCO has a prop Extent that's used to describe a particular aspect of an object, for the purposes of contribution, material, dimension, or subject.

After analysis of values, I've argued in the CONA confluence that this cannot be mapped to an object Part because many extents are not physical parts.

GM have per-extent dimensions, so lacking proper guidance, they've used P46_is_composed_of improperly (that's for physical parts), eg

http://data.americanartcollaborative.org/GM/object/39895:

crm:P46_is_composed_of
  <http://data.americanartcollaborative.org/GM/object/39895/Overall>

http://data.americanartcollaborative.org/GM/object/9:

crm:P46_is_composed_of
  <http://data.americanartcollaborative.org/GM/object/9/Framed>
  <http://data.americanartcollaborative.org/GM/object/9/Image>

An object cannot be composed of parts Overall nor Framed.

Cannot view queries at http://review.americanartcollaborative.org/

All of sparql queries are reporting : Nothing to see here...

mapping Rights (of Image or Object)

This is all wrong.

  ?image crm:P104_is_subject_to ?right .
  ?right a crm:E30_Right .
  ?image crm:P67i_is_referred_to_by ?rights_statement_class .
  ?rights_statement_class a crm:E33_Linguistic_Object ;
    crm:P2_has_type <http://vocab.getty.edu/aat/300055547> ;
    rdf:value ?rights_statement .

You say there's some Right over the image, but provide no info about it; then say there's some Linguistic Object but it;s not related to the right. Should be like this:

  ?image crm:P104_is_subject_to ?right .
  ?right a crm:E30_Right 
    # crm:P2_has_type # pick a license from creativecommons.org or rightsstatements.org
    crm:P3_has_note ?rights_statement .

dimension mapping should use crm:P90_has_value

Dimension mapping uses rdf:value.
However, it should use crm:P90_has_value that is specifically dedicated to that purpose.
It's also shown in CRM-graphical: http://personal.sirma.bg/vladimir/crm-graphical/#measurement.
Note: that says E60_Number, but it's widely accepted that Primitive Classes should be implemented as literals, and indeed cidoc_crm_v6.2-draft-2015August.ttl shows rdfs:range rdfs:Literal

Subject mapping doesn't specify rdf:type

See Subject mapping. It doesn't specify rdf:type, so PUAM has used owl:Thing, see eg http://data.americanartcollaborative.org/page/puam/object/17328.
Since you're using CRM, specify E1_Entity

Problem with mapping of Preferred ID

I expected to see:

34753

but instead I saw:

Nothing/Blank

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?identifier ?identifier_url
WHERE {
<http://data.thewalters.org/object/34753> a crm:E22_Man-Made_Object .
<http://data.thewalters.org/object/34753> crm:P1_is_identified_by ?identifier_url .
?identifier_url a crm:E42_Identifier ;
  rdf:value ?identifier ;
  crm:P2_has_type <http://vocab.getty.edu/aat/300404670> .

}

Review site issue

The queries don't seem to be working on the review site. It just says "Searching" and 'Show this query' says "Nothing to see here..."

Problem with mapping of Primary Title

I expected to see:

Crawford Notch - because the first title listed should always be the first title displayed, even if it has a qualifier

but instead I saw:

nothing

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?primary_title_text ?primary_title_class ?primary_title_id ?primary_title_id_class
WHERE {
<http://data.americanartcollaborative.org/puam/object/5024> a crm:E22_Man-Made_Object ;
  crm:P102_has_title ?primary_title_class .
?primary_title_class a crm:E35_Title ;
  rdf:value ?primary_title_text ;
  crm:P2_has_type <http://vocab.getty.edu/aat/300404670> .
OPTIONAL {
  ?primary_title_class crm:P1_is_identified_by ?primary_title_id_class.
  ?primary_title_id_class a crm:E42_Identifier;
    crm:P2_has_type <http://vocab.getty.edu/aat/300404012> ;
    rdf:value ?primary_title_id .
}

}

query for Actor Other Names

The query for Actor Other Names is not selective enough and also returns Primary names.
Check with http://data.crystalbridges.org/person-institution/73

Problem with mapping of Alternate Titles

This query gets primary titles, not alternate titles

Location mapping is poor

See production location mapping.
For the place it specifies a label and geo coordinates (split in two nodes, which is very strange).

Consider eg american-art/PUAM#49. PUAM places have:

structured name, also indicating a place hierarchy: Continent, SubContinent, Country, Region, State, City, County, SubRegion, Locale, Locus, River, Excavation. The best is to make these out as separate nodes and interconnect them
geonames link (some of them)

Exhibition mapping is missing

There's only a mapping of Event including only Title. But:

you at least need to indicate P2, to distinguish this event from others (eg Production): american-art/npg#5
crm:P2_has_type aat:300054766; # exhibition (event)
CBM (at least) has structured info, incl for Traveling Exhibitions: american-art/cbm#19, including shared exhibitions (object-exhibition is n-n), venues (sub-exhibitions), dates of main and sub-exhibition, and sub-exhibition organizer (venue constituent)
In american-art/PUAM#8 (comment) I proposed a mapping for Traveling Exhibitions

Object ID and Accession Number show no mapping

Instead of a diagram, these show "Welcome to PlantUML". That is strange because

"Show mapping as turtle" works
http://data.crystalbridges.org/object/20 shows the right ObjectID (namely "20")

Problem with mapping of Creation Location

I expected to see:

United States, New Hampshire, Carroll County, Crawford Notch - data from apiobjgeography place made=

but instead I saw:

nothing

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?creation_location_name ?creation_lat ?creation_lng ?creation_location_class
WHERE {
<http://data.americanartcollaborative.org/puam/object/3139> a crm:E22_Man-Made_Object ;
  crm:P108i_was_produced_by ?production_event .
?production_event a crm:E12_Production ;
  crm:P7_took_place_at ?creation_location_class. 
OPTIONAL {
  ?creation_location_class a crm:E53_Place;
    rdfs:label ?creation_location_name.
  OPTIONAL {
    ?creation_location_class crm:P87_is_identified_by ?lat;
      crm:P87_is_identified_by ?lng.
    ?lat a crm:E47_Spatial_Coordinates;
      crm:P2_has_type <http://vocab.getty.edu/aat/300387565>; 
      rdf:value ?creation_lat.
    ?lng a crm:E47_Spatial_Coordinates;
      crm:P2_has_type <http://vocab.getty.edu/aat/300387567>; 
      rdf:value ?creation_lng.
  }
}

}

use AAT concepts directly rather than local concept with broaderMatch to AAT

http://review.americanartcollaborative.org/entity/E39_Actor#field_2-search_0
Why not use aat:300404651 directly but do this broadMatch rigmarole?
Is any institution actually using local concepts for ?given_name_type?

  ?given_name_type_class a crm:E55_Type ;
    skos:broadMatch <http://vocab.getty.edu/aat/300404651> .
    skos:prefLabel ?given_name_type.

Problem with mapping of Artist / Object 9895

--Update, tested this for Object 34753 too which has an individual artist and the same problem persists (not specific to institutions as the example cites below).

Our constituents file is split into 6 subfiles...not sure why this is but I think it's preventing the validator from reading our artists names.

I expected to see:

Artist name "Tiffany and Company" -- Note there is a separate model for institution/individual/culture in our data (I can understand why but this freaks me out).

but instead I saw:

Nothing/Blank

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?actor_name ?actor_type ?actor_class
WHERE {
<http://data.thewalters.org/object/9895> a crm:E22_Man-Made_Object ;
   crm:P108i_was_produced_by ?production_event .

?production_event a crm:E12_Production ;
  crm:P14_carried_out_by ?actor_class .

OPTIONAL {
  ?actor_class a ?actor_type .
}
OPTIONAL {
  ?actor_class rdfs:label ?actor_name.
}

}

Problem with mapping of Dimensions (Part)

I expected to see:

this data in "physical size of the work" rather than in "physical size of part of the work" - how does this get decided? the element for this dimension is 'overall'

but instead I saw:

data in the part field - no data in the overall dims field

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?value ?part ?part_class ?part_type ?unit ?dimension_name ?dimension_class
WHERE {
<http://data.americanartcollaborative.org/puam/object/3139> a crm:E22_Man-Made_Object ;
    crm:P46_is_composed_of ?part_class.
?part_class a crm:E18_Physical_Thing ;
  crm:P43_has_dimension ?dimension_class .
?dimension_class a crm:E54_Dimension ;
  rdf:value ?value ;
  crm:P91_has_unit ?unit ;
  crm:P2_has_type ?dimension_type .
OPTIONAL {
  ?dimension_type skos:prefLabel ?dimension_name.
}
OPTIONAL {
  ?part_class crm:P2_has_type ?part_type.
}
OPTIONAL {
  ?part_class rdfs:label ?part.
}


   

  

}

AAT Description (activity)

<http://data.thewalters.org/object/155/description>
  crm:P2_has_type <http://vocab.getty.edu/aat/300404670>

aat:300404670 is Description, but the activity of describing something: analytical functions, <functions by general context>, functions (activities), Functions (hierarchy name), Activities Facet.

Need to pick something better

Export Entity As doesn't find the data

go to http://review.americanartcollaborative.org/entity/E5_Event#field_0-search_0
enter http://data.crystalbridges.org/exhibition/10
click Search ("AAC" should be selected)
it shows name="Celebrating the American Spirit": so far so good

Now try Export Entity As:

Turtle: "Nothing to see here..."
JSON: "eventName": [ ]
Report: "Errors: Event Name: Mandatory field not present. Field Listing: Event Name"

Question on mapping of Subject vs Concept

Subject "What the work depicts" is mapped differently from Concept "What the work is about".

Can you give some examples of Subject vs Concept values?

P62_depicts is a shortcut of P128_carries/P129_is_about, which is correct only if the nature of aboutness is visual (eg a portrait of someone). If this cannot be ascertained, the long-path should be used in both cases.

mapping for Responsible Department

The mapping for Responsible Department doesn't show as image, instead "Welcome to PlantUML".

The mapping itself:

?entity_uri a crm:E22_Man-Made_Object ;
  crm:P46i_forms_part_of _:collection_class .
_:collection_class a crm:E19_Physical_Object ;
  rdfs:label ?collection_name ;
  owl:sameAs ?collection_class ;
  crm:P49_has_former_or_current_keeper _:department_class .
_:department_class a crm:E74_Group ;
  crm:P2_has_type <http://vocab.getty.edu/aat/300263534> ;
  owl:sameAs ?department_class ;
  crm:P107i_is_current_or_former_member_of ?institution;
  rdfs:label ?department_name .

Has these problems:

why P49_has_former_or_current_keeper and not P50_has_current_keeper ?
why not a direct link to the department but go through some imaginary Collection?
why the collection is E19_Physical_Object and not E78_Collection?
the owl:sameAs are not specified, so let's see what the students make out of them

Some of museum like say WAM may not have timespan for Actor, though just birth location exists

I expected to see:

Optional {
crm:P4_has_time-span ?birth_timespan.
?birth_timespan a crm:E52_Time-Span;
crm:P82a_begin_of_the_begin ?earliest_birthdate;
crm:P82b_end_of_the_end ?latest_birthdate;
}

but instead I saw:

Its not optional

The current query was:

PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX crm: <http://www.cidoc-crm.org/cidoc-crm/>
PREFIX skos: <http://www.w3.org/2004/02/skos/core#>
PREFIX xsd: <http://www.w3.org/2001/XMLSchema#>
PREFIX foaf: <http://xmlns.com/foaf/0.1/>
PREFIX dct: <http://purl.org/dc/terms/>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX schema: <http://schema.org/>

SELECT ?display_birthdate ?earliest_birthdate ?latest_birthdate ?birth_location_class ?birth_location
WHERE {
<http://collection.britishmuseum.org/id/person-institution/70240> a crm:E39_Actor ;
    crm:P92i_was_brought_into_existence_by ?birth_event.
?birth_event a crm:E63_Beginning_of_Existence;
    crm:P4_has_time-span ?birth_timespan.
?birth_timespan a crm:E52_Time-Span;
      crm:P82a_begin_of_the_begin ?earliest_birthdate;
      crm:P82b_end_of_the_end ?latest_birthdate;
OPTIONAL { ?birth_timespan rdfs:label ?display_birthdate.}
OPTIONAL {
  ?birth_event crm:P7_took_place_at ?birth_location_class .
  OPTIONAL {
    ?birth_location_class a crm:E53_Place;
              rdfs:label ?birth_location.
  }
}

}

global Title mapping

Consider eg LOD CBMAA Titles.csv that includes eg this record:

ObjectID=     197
TitleID=      6,716  (someone printed the ID with a decimal separator, silly)
Title=        From "Album Unique" formerly in the collection of the Duke of Portland
TitleTypeID=  4
TitleType=    Group Title
DisplayOrder= 2
DataDate=     12/23/2015

The global Title mapping http://review.americanartcollaborative.org/entity/E22_Man-Made_Object#field_1-search_0 has the following problems:

doesn't specify the URLs, which has allowed the mapping implementers to botch it like this: american-art/cbm#58 items 1 and 2 (TWO wrong URLs in one mapping!)
The title type (eg http://data.americanartcollaborative.org/page/cbm/object/197/title_type) mixes SKOS (skos:prefLabel) and CRM (crm:E55_Type) in an undisciplined way
There's no relation of title type to AAT. Whenever you need a concept like Group Title, write to Patricia and she'll add it. (AFAI remember, CCO has such a concept)
DisplayOrder is not modeled but often it is important
(@azaroth42: back to the discussion whether using rdf:List is appropriate for this. crm:P102_has_title cannot point to a rdf:List)
A more subtle problem: Group Title reflects a collection of objects so it should be modeled as crm:E78_Collection

map gender to sex, not sex role

Gender is mapped to 300055147 sex role. However, that concept has no children and is a bit unclear.
In https://jira.getty.edu/browse/ITSLOD-497 I suggest to delete it, since there's already:

300055146 sex, with children male, female
300400503 sexual orientation, with children: LGBT, bisexual, heterosexual etc

I think AAC should map to 300055146 sex

Problem with mapping of Gender

The query for gender seems to have nationality_type instead of gender_type in it

E39_Actor sex v. gender

I propose that "gender" in the E39_Actor mapping be renamed "sex" or "biological sex" since it draws that field from ULAN's biography nodes that map sex distinctions as an agent's gender.

I know that gender distinctions are tricky, but where ULAN maps gender, it points to objects of sexual distinction. schema:gender predicates point to terms of sexual distinction--mostly http://vocab.getty.edu/aat/300189559 ("male") and http://vocab.getty.edu/aat/300189557 ("female"), though some "unknown" or "other" objects exist. These are both sexual distinctions (see http://www.getty.edu/vow/AATHierarchy?find=&logic=AND&note=&page=1&subjectid=300055146 where you can see the unused term from that hierarchy--hermaphroditism!).

Without a model capable of making finer distinctions between instances of gender (say, an event- or utterance-based one that would distinguish between Marcel Duchamp's persona as a male artist and his feminine alter-ego Rose Sélavy) I think the label should reflect what the data represents.

Problem with mapping of Primary Name

The variable ?type_label is undefined.

SELECT ?actor_name ?type_label ?actor_class
WHERE {
http://data.americanartcollaborative.org/autry/maker/leighwilliamrobinson a crm:E39_Actor ;
crm:P131_is_identified_by ?actor_class .
?actor_class a crm:E82_Actor_Appellation ;
rdf:value ?actor_name ;
crm:P2_has_type http://vocab.getty.edu/aat/300404670 .

}

deep zoom images are not mapped

Eg Colby has IIIF deep zoom, eg http://iiif.museum.colby.edu/2013.125_003_pm.tif.
It's a pity these are not mapped, given @azaroth42 is so deeply involved in IIIF.
These would be nice to display in the app @workergnome.

A mapping model for YCBA can be found at https://confluence.ontotext.com/display/ResearchSpace/Yale+Mapping+Problems#YaleMappingProblems-Images,
and an RDF example at https://confluence.ontotext.com/display/ResearchSpace/Yale+Mapping+Problems#YaleMappingProblems-ImageRDF

Question on mapping of Descriptions

Do you actually have info on who wrote the descriptions? (Main and Other)

  ?alt_description_class crm:P94i_was_created_by ?alt_desc_authorship_event .
  ?alt_desc_authorship_event a crm:E65_Creation ;
    crm:P14_carried_out_by ?alt_desc_author_class .
  ?alt_desc_author_class a crm:E39_Actor;
    rdfs:label ?alt_desc_author .

designforcontext / aac_review_tool Goto Github PK

aac_review_tool's People

Contributors

Stargazers

Watchers

Forkers

aac_review_tool's Issues

Recommend Projects

Recommend Topics

Recommend Org