despical/oitc

Kill everyone with your bow and reach 25 points to win!

Check out pinned repo's for some of my most recent work.

oitc's Issues

How do I disable health regen?

When health regen is disabled, players do not regen their hearts back they lost.

I'm on the latest version.

[`Hide-Players`] Players can't see each other after game ends

Description of Issue

If Hide-Players is enabled in the config, after a match ends, all players are teleported out to the set location, but players cannot see each other until relogging. Hide-Players says it hides in-game players from other online players, but once they're out in the lobby, they shouldn't be hidden anymore.

Steps to Reproduce

1. Ensure Hide-Players is set to true in config.yml
2. Play a match normally
3. Wait to be teleported back to lobby
4. Observe that no players in lobby can see each other

OITC Version

2.5.0

Server Version

This server is running Paper version git-Paper-290 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: f186318)

Stack Trace/Log Files/Crash Reports

N/A

Additional Information

N/A

[Scoreboard] Ability to have a lobby scoreboard (when not queueing)

Description of the new feature

Right now, there is no scoreboard in the lobby and it's looking kind of bland. I cannot add a scoreboard myself with a different plugin, because it might overlap each other and cause problems.

Vanilla teams broken efter game in OITC (+sometimes in MM)

https://youtu.be/-oWYeVnFHxw

No errors displayed in console during this recording. However, this has came up before:

[23:26:41] [Server thread/ERROR]: Could not pass event PlayerDeathEvent to OITC v2.4.1
java.lang.IndexOutOfBoundsException: Index 27 out of bounds for length 27
at jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64) ~[?:?]
at jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70) ~[?:?]
at jdk.internal.util.Preconditions.checkIndex(Preconditions.java:266) ~[?:?]
at java.util.Objects.checkIndex(Objects.java:359) ~[?:?]
at java.util.ArrayList.get(ArrayList.java:427) ~[?:?]
at me.despical.oitc.arena.managers.ScoreboardManager.getRank(ScoreboardManager.java:160) ~[one-in-the-chamber-2.4.1.jar:?]
at me.despical.oitc.arena.managers.ScoreboardManager.getRank(ScoreboardManager.java:169) ~[one-in-the-chamber-2.4.1.jar:?]
at me.despical.oitc.arena.ArenaManager.formatSummaryPlaceholders(ArenaManager.java:326) ~[one-in-the-chamber-2.4.1.jar:?]
at me.despical.oitc.arena.ArenaManager.stopGame(ArenaManager.java:299) ~[one-in-the-chamber-2.4.1.jar:?]
at me.despical.oitc.events.Events.onDeath(Events.java:348) ~[one-in-the-chamber-2.4.1.jar:?]
at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor228.execute(Unknown Source) ~[?:?]
at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at org.bukkit.craftbukkit.v1_17_R1.event.CraftEventFactory.callPlayerDeathEvent(CraftEventFactory.java:899) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at net.minecraft.server.level.ServerPlayer.die(ServerPlayer.java:851) ~[app:?]
at net.minecraft.world.entity.LivingEntity.hurt(LivingEntity.java:1479) ~[app:?]
at net.minecraft.world.entity.player.Player.hurt(Player.java:965) ~[app:?]
at net.minecraft.server.level.ServerPlayer.hurt(ServerPlayer.java:1033) ~[app:?]
at net.minecraft.world.entity.player.Player.attack(Player.java:1301) ~[app:?]
at net.minecraft.server.level.ServerPlayer.attack(ServerPlayer.java:2128) ~[app:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl$6.onAttack(ServerGamePacketListenerImpl.java:2576) ~[app:?]
at net.minecraft.network.protocol.game.ServerboundInteractPacket$1.dispatch(ServerboundInteractPacket.java:24) ~[app:?]
at net.minecraft.network.protocol.game.ServerboundInteractPacket.dispatch(ServerboundInteractPacket.java:80) ~[app:?]
at net.minecraft.server.network.ServerGamePacketListenerImpl.handleInteract(ServerGamePacketListenerImpl.java:2501) ~[app:?]
at net.minecraft.network.protocol.game.ServerboundInteractPacket.handle(ServerboundInteractPacket.java:67) ~[app:?]
at net.minecraft.network.protocol.game.ServerboundInteractPacket.handle(ServerboundInteractPacket.java:12) ~[app:?]
at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$1(PacketUtils.java:56) ~[app:?]
at net.minecraft.server.TickTask.run(TickTask.java:18) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:149) ~[app:?]
at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[app:?]
at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1450) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at net.minecraft.server.MinecraftServer.executeTask(MinecraftServer.java:192) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[app:?]
at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1428) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1421) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:132) ~[app:?]
at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1399) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1310) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:322) ~[patched_1.17.1.jar:git-Purpur-"4ff0630"]

[Category] When players queue with /oitc randomjoin, it will not put them in a mode that is queuing

Description of Issue

When players queue with /oitc randomjoin, it will not put them in a mode that is queuing

Steps to Reproduce

Two people join /oitc randomjoin, and it'll put them in separate modes;

OITC Version

Latest

Server Version

ImanitySpigot 1.8.9

Stack Trace/Log Files/Crash Reports

None provided.

Additional Information

Nothing.

[Category] When queuing, all players are invisible except the ones in the queue

Description of Issue

If possible, could we have a option to disable this?

Steps to Reproduce

Self explanatory.

OITC Version

Latest

Server Version

1.8

Additional Information

[BUG] Losing Inventory

Description of Issue

If 2 players are in a round and then one player leaves the game with ESC, he loses his entire inventory that he had before.

Steps to Reproduce

1. Start a round with at least 2 Players
2. Player 1 stays online and the other one is leaving the server with ESC -> Disconnect

OITC Version

2.5.6

Server Version

Purpur Version 2165

[arena/arrows] Allow arrow pickup.

Is there a way to enable pickup of arrows that have been shot from bows?
I think it would add another neat dimension to the game.

So when another player shoots the arrow with a bow and it gets stuck in a block.
Another player should be able to pick up the same arrow.

Sorry for being so direct and thank you for your time in advance.

Abusive leave command.

Description of Issue

If a player who is leading in score leaves the game in an arena with two players, they directly win, which can be abusive.

Steps to Reproduce

1. Two players join an arena.
2. One of the players takes the lead in score.
3. That player leaves the game and instantly wins.

OITC Version

v2.6.1 & v2.6.2.

Server Version

Any version that OITC supports.

When player leaves whenever it transfer, it'll register as a player but godded mode

Description of Issue

Whenever a player leaves the match and is teleported to the arena, they will in spectator mode and they will show up for all players;

Steps to Reproduce

1. Leave match when teleported;

OITC Version

Lastest

Server Version

ImanitySpigot 1.8

Stack Trace/Log Files/Crash Reports

none

Additional Information

None

[Category] Ability to go over 10

Description of the new feature

You should be able to go over 10 players per match. There's one options that I think would be best, let me know if there's any, I'll love to give feedback.

You could have it, so you can have it at like 10 spawns, but whatever you set, let's say a set 20 people can be in that arena, you can do 20 people and randomize the spawns within the 20 people playing;

Tab-complete for arena names doesn't work properly

Description of Issue

When using a command that should tab-complete an arena name (for example /oitc join,) and typing a partial arena name, arenas not matching the partial name are not filtered out. This doesn't match the behavior of the /oitc base command, where tab-completing on /oitc e will filter out everything except the edit subcommand.

Steps to Reproduce

1. Create some arenas. For example, I have Bowser_Land, Castle_Turret_Tumble, Colosseum, Crazy_Cakes, Crystal_Caves, DeepDarkMansion, Extreme_War, Legacy_Cove, MoonBase, and Pyramid_Panic.
2. Type /oitc join and then the first few letters of an arena name, without pressing enter. With my arena set, I used /oitc join Cr
3. Observe that non-matching arena names are not filtered out. With my arena set, only Crazy_Cakes and Crystal_Caves should remain.

OITC Version

2.5.0

Server Version

This server is running Paper version git-Paper-290 (MC: 1.20.2) (Implementing API version 1.20.2-R0.1-SNAPSHOT) (Git: f186318)

Stack Trace/Log Files/Crash Reports

N/A

Additional Information

Tab-complete for /oitc stats and /oitc top also behave strangely, but they're usable. Instead of filtering out the ones that don't match, it seems it just brings the closest match to the top (selecting it,) which is fascinating and unusual but fairly intuitive.

[Server support] Plugin fails to load on Paper 1.20.6

Description of Issue

The plugin doesn't load correctly on Paper 1.20.6. (Issue is probably not present on Spigot 1.20.6)

Steps to Reproduce

1. Install Paper 1.20.6 and this plugin
2. Start the server
3. Observe the console error and the plugin being disabled.

OITC Version

2.5.8

Server Version

This server is running Paper version 1.20.6-124-master@0fcf3e3 (2024-05-29T22:05:27Z) (Implementing API version 1.20.6-R0.1-SNAPSHOT)

Stack Trace/Log Files/Crash Reports

https://pastebin.com/JiVdG0c7

Additional Information

Seems to be due to Paper's removal of CraftBukkit package relocation: https://forums.papermc.io/threads/1106/
Meaning there is no longer a component of the package that looks like v1_20_R4

[Player Stats] Can we have OITC leaderboards?

Description of the new feature

Holograms to display who is on the top of the leaderboard for kills, wins, etc

[FEATURE] Define own itemset

Hey mate,
would it be possible to set your own items as starting items? So e.g. via config that you can only play with a bow in one arena and with a sword in the other arena, for example.