dhoer/k8s-env-gen

Kubernetes environment generator makes docker env files compatible with kubernetes

k8s-env-gen's Issues

Bash functions and global variables

Currently, there are three functions put, get, and keys in the script.

Each of them ends up mutating global state, which probably isn't a good idea in the long term. You can make your functions more "pure" by using command substitution:

function myfunc()
{
    local  myresult='some value'
    echo "$myresult"
}

result=$(myfunc)   # or result=`myfunc`
echo $result

The function keys is probably the most problematic as you're creating a function and a global variable with the same name.

Investigate templates

Right now, all output is handled with echo. It might be worth looking into using templates so that it's easier manage what the final result will look like and add additional functionality.