dhruv-tech/ninjachefs

Web application that leverages generative AI to simplify online recipe sharing 🧑‍🍳🍽️

Hello World, I'm Dhruv 👋

Fullstack Developer, Application Security Enthusiast.

🌐 dhruv.tech | 🔗 LinkedIn | 📨 [email protected]

ninjachefs's Issues

External Code Review (twitch.tv/cloudzydev)

General Feedback

• OUTSTANDING PROJECT
• I would've given you an interview like 2minutes into checking out this repo

Denormalizing Your Observability Tools

• So I noticed that in PendingSubmissions you have one row that tracks the current status of a submission
• The one tidbit of foresight I'd like to give you is that it can be really helpful to be able to look back at the history of all statuses for a submission rather than just the most recent one
• If you can eat the DB costs, I'd recommend it because it often comes up that you wonder "well when did this submission leave state X and when did it enter state Y"
• As an added benefit, you can then parallelize parts of the process that are currently sequential because you don't have to worry about losing state / overwriting things - each "stage" gets its own row

Add Zod for schema validation

A little improvement suggestion: you could use Zod to validate responses from AI's, this way you won't need to be reimplementing the wheel with custom validation anymore and expected scheme shape will be more apparent from the code.

ninjachefs/backend/utils/helpers.js

Lines 7 to 131 in 7e78493

	helpers.isRecipeOutputValid = (output, targetSchema = 'aiAssist') => {
	let schemaOptions = {
	aiAssist: [
	{
	prop: "ingredients",
	type: Object
	},
	{
	prop: "diet",
	type: String
	},
	{
	prop: "allergies",
	type: Array
	},
	{
	prop: "intro",
	type: String
	},
	{
	prop: "desc",
	type: String
	},
	{
	prop: "health_score",
	type: Number
	},
	{
	prop: "health_reason",
	type: String
	},
	{
	prop: "prompt",
	type: String
	}
	],
	userUpdate: [
	{
	prop: "ingredients",
	type: Object
	},
	{
	prop: "diet",
	type: String
	},
	{
	prop: "intro",
	type: String
	},
	{
	prop: "desc",
	type: String
	},
	{
	prop: "name",
	type: String
	},
	{
	prop: "cooking_time",
	type: Number
	},
	{
	prop: "steps",
	type: Array
	}
	],
	insights: [
	{
	prop: "allergies",
	type: Array
	},
	{
	prop: "health_score",
	type: Number
	},
	{
	prop: "health_reason",
	type: String
	}
	]
	}
	try {
	let schema = schemaOptions[targetSchema];
	for (let schemaItem of schema) {
	if (!Object.hasOwn(output, schemaItem.prop)) return false;
	else if (!typeof(output[schemaItem.prop]) === schemaItem.type) return false;
	else return true;
	}
	} catch (error) {
	console.log("[at helpers.isRecipeOutputValid]: " + error);
	return false;
	}
	}