diamirio/biometricauth

Backport of Android Pie's BiometricPrompt using Kotlin and RxJava

biometricauth's Issues

Switch to current AndroidX dependencies

Currently your library is the last remaining dependency which uses old support libraries and forces us to enable Jetifier.

Please consider releasing a new minor version update using the current AndroidX libs.

Declare RxKotlin as api dependency

Currently you have to manually add the io.reactivex.rxjava2:rxkotlin dependency to your project to use the library. Consider declaring rxkotlin as api dependency.

Use FragmentActivity instead of AppCompatActivity

The BiometricAuth.create function requires an activity as parameter which is typed as the androidx.appcompat.app.AppCompatActivity activity. Looking through the source it seems the only thing needed from the specific activity is the supportFragmentManager which is provided through the androidx.fragment.app.FragmentActivity super class. Therefore it should not be required to use AppCompatActivity instead of FragmentActivity for this parameter.

Remove duplicated permission declarations

Issue raised by @nilsjr, details are available in #15

Android Oreo (API 27) java.util.NoSuchElementException: The MaybeSource is empty

I'm getting java.util.NoSuchElementException: The MaybeSource is empty

.authenticate(crypto, ...)
.subscribe(
  { success_block },    // this one must be called
  { error_block }       // this one calls after successfully fingerprint scanning with exception named as above one
)

It occurs after fingerprint scanning (there must be called function onSuccess) only when I use the method authenticate with CryptoObject argument only on Android API 27 (also maybe lower API versions). On Android API 28 works well

Project still maintained / availability on MavenCentral?

Hi,
are there any plans on updating and maintaining this library? This would require making it available on MavenCentral (or jitpack).

Since I am a library maintainer myself I know the hassle of setting up MavenCentral and so on. Does your company already have a MavenCentral account? I saw that your domain is tailored-apps.com while your package name is com.tailoredapps. This could potentially be an issue with the verification.

I could support you by creating a PR to set up all the publishing configuration for MavenCentral inside the Gradle buildscripts.

If this library has no priority for you thats also fine ofc. But would be nice if you could notice this in the readme e.g.

Check for new fingerprint added

Check for new fingerprints via sending CryptoObject in authorization method is not working on Android 8 and lower