dideler/brocku-reddit-for-chrome

A Google Chrome extension for brocku.reddit.com

brocku-reddit-for-chrome's Issues

Notification pops up for old submissions

Steps to reproduce the problem:

1. Have the notification option for the extension enabled.
2. Remove a submission from the front page that the extension is already aware of (via deletion or downvotes).
3. When you refresh or the extension auto-refreshes, it will send a notification saying a new submission was made.

Expected:
No notification because no new submission was made.

Actual:
The second top post is seen as a new submission because it now appears at the top of the front page, and the submission that the extension has stored as the top one is no longer the top one, so it assumes the new top one is a new submission.

Fix:
Instead of just looking at the top stored link, go through the list of all stored links to verify if the submission already exists in storage, rather than assuming it's a new submission.

Refresh timer does not work

Expected:
An auto refresh is supposed to happen every so often depending on the user-set interval. E.g. every 15 minutes.

Actual:
No auto refresh. Upon inspection, the lastRefresh item in localStorage is abnormally large, so the current time will always be less than the next update time and no update would happen.

The lastRefresh time is too large because the retry time (used when an update fails) is appended rather than added. This is because the '+' operator acts as concatenation since lastRefresh is returned as a string. To fix, simply parse it as a float before adding the retry time.