didier-wenzek/ocaml-kafka

OCaml bindings for Kafka

ocaml-kafka's Issues

please install *.mli and *.cmt* files

Balanced consumer groups support

librdkafka supports broker based balanced consumer groups (see FAQ), would be awesome to have this API wrapped in ocaml-kafka lib.

Create a 0.1 tag for publishing to OPAM

Hey, I saw this project in r/ocaml and wanted to try it out. A quick opam search showed that this project isn't yet available there.

I was wondering if you consider this project to be worthy of a 0.1 version and would be happy to have it published on OPAM. I've done some of the initial legwork to create an opam package. To complete that I need a tag created in this repo as explained here which will create a tar.gz file for that version.

After that I can create a PR against OPAM and get this project added there.

Cheers

job_consume leak

extern CAMLprim
value ocaml_kafka_consume_job(value caml_kafka_topic, value caml_kafka_partition, value caml_kafka_timeout)
{
  struct job_consume* job = (struct job_consume*)lwt_unix_new(struct job_consume);

but there is no corresponding free afaics?

rd_kafka_conf leak

  if (conf_err) {
     rd_kafka_conf_destroy(conf);
     RAISE(RD_KAFKA_CONF_RES(conf_err), "Failed to configure new kafka consumer (%s)", error_msg);
  }

  rd_kafka_t *handler = rd_kafka_new(RD_KAFKA_CONSUMER, conf, error_msg, sizeof(error_msg));
  if (handler == NULL) {
     RAISE(RD_KAFKA_RESP_ERR__FAIL, "Failed to create new kafka consumer (%s)", error_msg);
  }

this leaks rd_kafka_conf when rd_kafka_new fails

Integration tests failing for librdkafka < 1.0.0

See pull request Build & test code on Travis CI #13

• The integration tests are ok for all the versions from 1.0.0.RC2 up to 1.3.0
• There is no 1.0.0.RC1 and the previous version was 0.11.6. The tests are failing on an Assert_failure("test/integration/integration.ml", 181, 3)
• The version installed with ubuntu 0.11.3 leads to a time out in the same place related to producers' delivery callbacks.

Request: new release

Hey!

The latest release is from 2020. Can we create a new version (0.6)? Thanks!

Ubuntu 14.04

I'm unable to compile this on Ubuntu 14.04. I tried posting the error on discord but haven't been able to figure out

#=== ERROR while compiling kafka.0.4 ==========================================#
# context     2.0.7 | linux/x86_64 | ocaml-base-compiler.4.05.0 | https://opam.ocaml.org#c23dfbd9
# path        ~/locations-consumer/_opam/.opam-switch/build/kafka.0.4
# command     ~/.opam/opam-init/hooks/sandbox.sh build jbuilder build -p kafka -j 1
# exit-code   1
# env-file    ~/.opam/log/kafka-25955-d2c37b.env
# output-file ~/.opam/log/kafka-25955-d2c37b.out
### output ###
# ocaml_lwt_kafka.c:112:3: warning: implicit declaration of function ‘rd_kafka_consume_queue’ [-Wimplicit-function-declaration]
# [...]
# ocaml_lwt_kafka.c:112:16: warning: assignment makes pointer from integer without a cast [enabled by default]
#    job->message = rd_kafka_consume_queue(job->queue, job->timeout);
#                 ^
# ocaml_lwt_kafka.c: At top level:
# ocaml_lwt_kafka.c:241:3: error: unknown type name ‘rd_kafka_queue_t’
#    rd_kafka_queue_t *queue;
#    ^
# ocaml_lwt_kafka.c: In function ‘worker_consume_batch_queue’:
# ocaml_lwt_kafka.c:255:3: warning: implicit declaration of function ‘rd_kafka_consume_batch_queue’ [-Wimplicit-function-declaration]
#    job->actual_msg_count = rd_kafka_consume_batch_queue(job->queue, job->timeout, job->messages, job->msg_count);

Thanks!

Publish kafka_async

Are there plans to publish kafka_async? I'm going to have trouble convincing folks to pin an unpublished version of this library

delivery_callback is GC unsafe

  if (Is_block(caml_delivery_callback)) {
     caml_callback = Field(caml_delivery_callback, 0);
     rd_kafka_conf_set_opaque(conf, (void*) caml_callback);
     rd_kafka_conf_set_dr_cb(conf, ocaml_kafka_delivery_callback);
  } 

this stores OCaml value in the C structure without registering as GC root

Kafka_lwt.consume_batch is not thread-safe

I observe memory corruption when trying to run Kafka_lwt.consume_batch on the same topic object but different partitions in two Lwt threads. Is it supposed to work like this?

The custom partitioner callbacks are not invoked

The partitioner callback set when a topic producer is created is not used when messages are produced with no partition assigned.

Setting a partitioner callback as in:

let partitioner_callback partition_cnt key = Some ((Hashtbl.hash key) mod partition_cnt) in
let topic = Kafka.new_topic ~partitioner_callback producer topic_name options in                                                                                                                                 
Kafka.produce topic ~key msg

we expect that the partitioner_callback is called for each message produced without a partition.
Actually, the custom callback is never invoked and the partition is assigned using the partitioner set by the partitioner property