dimillian/achnbrowserui

Animal Crossing New Horizon companion app in SwiftUI

achnbrowserui's Issues

iOS app crash when selecting certain villagers?

I don't quite understand what's causing this issue. I recorded my screen and posted the video here. When I search for 'Pudge' and click on them, it works fine. But when I go back to click on 'Puddles', the app crashes.

Navigation Title and item ghosts remain after partially been navigated back

It's happening when using the "go back" gesture (swipe from left of the screen to the centre). No problems when tapping on the go back button though.

User interface localization

Without even talking about the data, we need to localize at least the UI.
There ton of Text constructed with variable in the middle of the string and I don't think it's a good pattern to have.
Anyway let's look into it. Never localized a SwiftUI app yet.

• English
• German
• French
• Spanish
• Italian
• Russian
• Dutch
• Chinese TW
• Chinese HK
• Japanese
• Korean

Typo for Categories in ItemsViewModel

var categorie: Categories should be var categories: Categories.

Swipe to Add to Collection

Hey all. New here. Gonna try to jump in with helping on things but I’ve never coded in swift. See if I can catchup fast.

Would be better if swiping right added a bug/fish/item to your collection. I also find a check might be better than a star for the non swipe method? It took me a bit to figure out star wasn’t favouriting meaning something else. Thoughts?

Item detail

•  Link to Recipe

Turnips chart tab

Something like that would be cool:

You can try it here:
https://ac-turnip.com/

Item Discovery

A bit like I did in MovieSwiftUI discover movies view: https://github.com/Dimillian/MovieSwiftUI
I think with would be great to have somewhere in the the possibility to see random items.
We would display them as stacked cards and you just swipe them to add them to like/collected/lists or dismiss them.

Custom lists of items

The goal of the feature is to help people categorize their items in order to plan their house.

I see two ways of doing that.
One a bit funky:

• You see a sort of a AC house plan (a cut from top) with all the house rooms. And you can tap on them to add items and label them. You can also add items from item detail to labeled rooms.

The other one more classic

• We have a Lists tab in the My Stuff tab and the user can create a new list with an icon and a title. And then we can search and add items from there or from item detail add to list.

The first one is a bit more work but would be worth.

Turnips

This issue will be a master list of ideas for turnips. No particular order or priorities.

• Turnip Calculator
• Turnip Charts
• Push notices
• Turnip Exchange

Refactor DashboardView into smaller views

Item / data localization

As you know, the http://acnhapi.com/ can display any catalog item in the correct localisation.
Would it be possible to add on option to let user choose the database language ?

Dashboard: organize widgets

@Bonney Did the UI for the re order button + sheet. Now we need to make it works.
This is mostly artchitectural, we need to have a list of TodayItem struct that have a makeView() function. So we can save and restore that.

Turnip tab reload glitch

Tapping the turnips tab while already viewing that tab causes a weird refresh. Can be restored by visiting any other tab, then turnips again.

Flashing

Hi,

There is a flashing when changing views through the tabBarController isn't there any way to make a small animation?

Regards

PS: Sorry for the multiple issue regarding the iOS version, the github mobile application told me that the issue was not created.

Star/save variants/color for items

Since I love collecting furniture, I also like collecting variety of colors. It'd be cool to 'star' even more specific on the colors obtained.

From a fellow Reddit user

IOS version

Hi,

I think that the restriction of the iOS version which must be the last one (13.4.1) is too restrictive.

Doesn't it seem better to have a minimum version of 13.0.0?

Regards

Turnips UI issue

Hi, first, thanks for this great app! I use it a lot while playing the game.
After updating the turnip price this afternoon, the UI looked like this:

I can't reproduce it at the moment

Setup CI

Automate delivery to TF. Use github actions / fastlane.

Categorize items added into my stuff

My stuff' -"items" section could have the folders of specifics since there are a ton of items eg; flooring, wallpaper, furniture, etc

From a fellow Reddit user

Reorganize Settings screen

I plan on doing on work on the Settings view; try to clean up the island details (maybe pull that in to it's own view); leave the door open for any future preferences we need to integrate

Dashboard: Today task widget

@Bonney Did the UI for the view in TodayTasksSection now we actually need to make it works. We can displays the 4 fossils to find, items in tree etc... any task that can be done daily and checked.

CoreData backed UserCollection

Explore the idea of using CoreData for keeping UserCollection inventory. Simpler than using CD for everything.

iOS Version

Hi,

I think that the restriction of the iOS version which must be the last one (13.4.1) is too restrictive.

Doesn't it seem better to have a minimum version of 13.0.0 ?

Regards

Update data to 1.2.0 game patch

@ericlewis is in the process of migrating our static JSON files dumped from https://nookplaza.net/ a while ago to full featured CoreData database.
Upgrading to new Nook Plaza dump should be a breeze after that.

Fishes or fish, and where in the UI?

https://www.grammarly.com/blog/fish-fishes/

Villager birthday on dashboard only appear once

I’ve broke it with villagers cache

Build Error

Env

macOS: 10.15.3 (19D76)
XCode Version 11.2.1 (11B500)

Data dump / API / Items update status

This is an issue I want to keep open and updated, because it's quite hard to keep up to date with the data and how / what / when I'm updating items data from the API and put it inside the app.

Latest: 99e6eb1

NookPlaza grouped houseware, art, miscellaneous and wall-mounted into one furnitures endpoint. It also change a bit the JSON response.
I've been able to import it only for Furnitures (the most important, changing data as game update). The only change in our Item Codable object is that obtainedFrom is now an array instead of a String. So from the source JSON i've renamed obtainedFrom to obtainedFromNew and we have both properties in our Item model for "old" items and new items.
Once I'll migrate all categories / endpoint I'll be able to remove the obtainedFrom completely and keep only the new one as an optional to allow legacy items in UserCollection to still be decoded.

Turnips chart improvement

• Add +50/-50 (not below 0) to the minMax spread so it have space to breath
• Scroll the Y legend with the content? (need to test)
• Curved lines

Today’s Birthday doesn’t show today’s actual birthday

Attached picture shows that the today’s birthday section doesn’t take into the actual date. Todays date is May 11, but the screenshot shows Nov 5. Yesterday it showed Oct 5.

Turnip profit calculation

Turnip profit calculation is based on average daily price, but to be a "profit" it has to be the difference between sell price and investment, so you need to subtract the initial investment. Otherwise profit is always "green".

Example:
Bought 3700 turnips for 100 bells -> total investment = 370.000 bells
Average price on Monday AM is 89 Bells -> total earning when selling is 325.500 bells
-> earning - invest = profit => 325.500 - 370.000 = -45.500 bells
profit is negativ and should be marked red. If sell price is over buy price (e.g. 110 bells) the profit is 37.000 bells

If you agree I will fix it - after finishing translation tasks.

Good morning. Missed the commits......

Refactor Text style as centralized ViewModifier

Right now we have too many Text style across the application. We should centralize them in a sort of Style ViewModifiers like Text("Title").modifier(Title())

Alternative icon picker

We have lots of icons! We need to support being able to choose alternatives.

• convert images
• setup in project
• build UI under settings view

Suggestion - turnip prices should update to show user input prices

The turnip calculator shouldn’t say average prices for the time slot if the user has put in a value already.

In the screenshot above, it says the average for the morning is 98 bells but I already put in 95 bells as my price for this morning. It should say your price this morning is 95 bells sense there is already a price entered.

Flower breeding section/guide/tracker

This one was specifically requested by my wife :)

Events

Surface info about events coming up / on the day.

Tabs Navigation Stack Resets

Expected Behaviour: When I switch between tabs on TabView, each tab should maintain its own Navigation Stack.

Current Behaviour:
When i switch beteween tabs, they always show me the rootView.

Example: On Villagers tab if I go to some villagers details Screen and then click on Dashboard and come back to Villagers tab, it shows me Villagers list, instead of Detail View. This is happening for all the tabs

Push notices

This is a general issue to capture push notice ideas. These can all be done locally, but need to be based on the island time.

• when shops open / close
• special events (sprint fishing tourney)
• turnip price changes
• turnip sell reminder / turnip purchase reminder

iOS crash after attempting to enter turnip prices.

Unfortunately this happened after I entered all my inventory 😓 but the app crashed and it would not let me back in. I had been entering my turnip prices after signing up for AC Helper+. So I deleted the app and re-downloaded it but it's not picking up that I am a subscriber anymore :-/

Fix previews

Some users / developers want to use previews. Some (most) of them are for now missing or not working because missing a dependency.

Make the app playful

• Make star button having feedback and animation
• Make dashboard a little more rounded (headers maybe?)
• Add animation to item detail when opening the view
• Maybe some parallax on item detail?
• More

User data capture

We need to collect certain pieces of data to understand how to feed other features

• island time
• native fruit
• hemisphere
• infrastructure (able sisters shop, resident service building, etc)

Load Turnip.Exchange listings conditionally.

I'd personally prefer if the app are only loads listings if the user wants to see it (by tapping on a button) or if you maybe just load the first 5? What does everyone else think?

Refactor ItemDetailView into smallers view

iOS Version

Hi,

I think that the restriction of the iOS version which must be the last one (13.4.1) is too restrictive.

Doesn't it seem better to have a minimum version of 13.0.0 ?

Regards

Crashes when tapping on Villagers tab

Not sure what more info to provide, or if this is even how you prefer this feedback, but I'm on an iPhone 11 Pro. Install app -> tap each tab until I get to Villagers -> crash.

Remove reliance on private API for ACNH Google Sheet -> JSON conversion

Master search

Have the categories root have a search that display 3-5 results per categories in a sectioned List.
We'll do that once we have CD plugged in.

Crash when trying to touch something in a list after using text field on macOS

It seems that my fix to dismiss automatically the keyboard lead to a crash on macOS :(

I think I will add some #if os(macOS) on the ViewModifier as there is no keyboard that pops, so no need to apply the ViewModifier there.