discipletools/disciple-tools-bulk-magic-link-sender

disciple-tools-magic-links

disciple-tools-bulk-magic-link-sender's Issues

Explore PHP Echoed JS Code Alternatives

Explore the use of wp_register_script() approach, instead of echoing JS code from within PHP code.

Custom text fields not showing

Filter Magic Link Form Contacts List

• Ability to only display a subset of user contact records; based on filter requirements. E.g. New Contacts Only!

Link Expiration Display Issue

Repeat scheduled message includes date from previous expiration in the past and according to message received the link has already expired. The link actually works properly but the date/time displayed in the message isn't updated prior to printing the text variables within the message generated. Configured settings are set to schedule send once per day and expire 8 hours after it is sent. The messages received each day at around 6PM EDT, on 13 August for example, and indicate the link expires 2AM EDT on 13 August. The expiration should instead indicate 2AM EDT on 14 August in this example. This issue is observed through both Twilio sending channel as well as email. When viewing the scheduling configuration after 6PM EDT, the expiration is set correctly to 8 hours after it was sent.

Resolve Custom Template Field Editable Issue

Ensure custom template fields are still editable when users are not logged into DT.

Spit scheduling and expiring sections

Checkbox to enable connections search.

The connections field is a powerful on the magic link.
Ideally the magic link opens a small window into D.T, for a simplified interface and for security.
For a user with more access the connections field allows listing of all the contacts in D.T.

We'd like to keep this feature but require that the admin enabled it when creating the magic link.

Something [ ] enable connection fields, this allows the user list list all the contact/groups they have access to.

Bug: Apostrophes in Post name break click event

If a post (my example is a group) has an apostrophe in the name (e.g. John Doe's Wife), clicking the name at the top of the Group Updates link does not do anything because it is not escaped properly.

It ends up rendering like this:

<tr onclick="get_assigned_post_details('999', 'John Doe's Wife');">

Enable connection field on templates.

Change "magic_plug" to "smart_links" in the link url

Contact based smart link configuration option to allow contact to see and update other sub-assigned contact records

There is a custom plugin that allows a smart link where the contact sees their sub-assigned contacts and can make specific updates on that contact's detail record.

Can this functionality be extended to the generic administrator created smart link feature?

Use Request Method POST When Updating Large Payloads

Switch to POST request method when processing a large volume of form fields, so as to avoid Request-URI Too Large exceptions.

Support Template Title Dynamic Translations

Similar to field translations; ensure template titles can also be dynamically translated....

Scheduler: Refresh Magic Link before sending to avoid user's link expiring.

If the user's magic link auto expires, refresh it before sending it to the user.
If auto expire is set to 3 days, this will let the user have 3 days to use the link before it expires.

This will avoid the situation where the magic link is set to expire in a couple hours and is sent to the user. They would only have a couple hours to use the link and might not see the email or text in time to use it.

Filtering ML Assigned Users & Teams List

Provide a feature to enable the filtering of listed assigned users:

Display Last Modified Timestamp Within User Contacts Updates ML Type Form

--- in place of expiry for some users

In the list of people the link is being sent to.
At one point there were some with a --- in place of the link expiry date.

This is from a report, and not sure how to reproduce this

Display Assigned Users Current Magic Link

• Within ML plugin admin section, make provision for the displaying/accessing of assigned users' currently active magic link.

Scheduling: Ability to set weekday and time

Example: Send every sunday at 4pm

Smart Link Templates - If Sub-Assigned Then Display List Of Contacts

Similar to User Contacts Update ML types, templates must also display list of contacts who the smart-link recipient is also sub-assigned to.

User Group Links

Lets switch to passing the vars in the body of the request instead of the url. The template form has this fix. I'm testing this on an instance that has a lot of fields.

• The church health milestones don't appear for me.
• Lets hide the fields with the "hidden" param. Like the creation date and last modified

Originally posted by @corsacca in #47 (comment)

UX with adding user to send list

Choose user from drop down. click add.
The user is added, but the form isn't cleared, and if the list is a long one, you can't tell if it has been added successfully

Expected:
It should notify you that the user has been added
It should clear the form after the user has been added

Scheduling Clarity

1. Show when the next send is scheduled for (and in how much time).

2. Move send now into own section
   Option to:
   Send now with refreshing all links ( might be needed)
   Send now without refreshing links.

Email as the default magic link sending channel

Use same options for all magic link ojbects

These options should be the same for
User Contacts
User Groups
Templates

Auto recommend the twillio plugin

See https://github.com/DiscipleTools/disciple-tools-porch/blob/master/support/required-plugins/config-required-plugins.php
And for linking to a Discple.Tools plugin (or any plugin not on the wordpress store): https://github.com/DiscipleTools/disciple-tools-theme/blob/2adaa8524a986a36bbc19906e53d72744d1fa688/dt-core/config-required-plugins.php#L47

View Assigned Contact Records Within Template Links

Ability to view a user's assigned contacts when accessing a template link; as currently this feature is not supported within templates.

Group members syncing

When selecting a group in the Assigned Users and Teams.
Would we auto add users to the magic link object when a member is added to a group?
Or place a button on the group row to sync members?

Allow sorting on all magic link field types

Cannot Uncheck group updates connection fields

With Enable connection field types enabled
The connection fields stay checked after saving.

emails not arriving

This could be on the WP sending side or the deliverability/filtering of the user's inbox.

There is a chance it could also be due to the wrong email address being sent to

Template as custom text field as textarea

When adding custom text fields
Make the field a textarea instead of an input.

Add visual confirmation that update was submitted

Add a loading spinner while submitting and success text ( that fades ) after submit.

set email subject when sending new link

Currently you set the email subject once for all links that are sent.

It would be nice to be able to set the email subject with the body that is sent in order to make the subject more specific to the link being sent out

Link Object Structure

Current Sections

Link Object Management

• Enabled
• Name
• Object Expires.
• Magic Link Type

Magic Link Fields

Users and Teams

• send now
  ###Link Management
• Links Expire Within
• Links Expiry Auto Refresh Enabled

Message

Schedule Management

• Schedule Enabled
• Freq
• Sending Channel
• Links Refresh before Sending
• Next Schedule

Proposed structure

Link Object Management

• Enabled
• Name
• Object Expires. This one might not be needed
• Magic Link Type
• Links Expire Within
• Links Expiry Auto Refresh Enabled
• Sending Channel
• Links Refresh before Sending

Schedule Management

• Schedule Enabled
• Freq
• Next Scheduled Run

Users and Teams

• users list
• send now

ML Assigned Users & Teams Ordering

Alphabetically sort listed (and dropdown menu) assigned users by Name:

Templates Type

It does not feel right for the subassigned to be a checkbox:

It is more fitting as a type.
Let's change it to a 'type' select

Template type : [
Update a record.
List Sub-Assigned Contacts
]

We can later add:

• list assigned contacts
• list assigned groups
• etc

Don't submit form if number above max

Set a number field above the max set on the field.
Then try submitting the form.
It just says something went wrong

CustomTranslate Template Labels

Create a magic link form template creator

Magic link templates can be used in the bulk sender or the front Bulk Send App (next to bulk edit). or other places linked to: Chose one post type.

Section to select fields. There are:

• Existing D.T fields
  • Not the connection field.
• Custom text fields that will be added as a comment
  • Ability to translate labels for custom text fields
    • Copy from fields settings tab

quick feature request: Address / location field in Group links

Hi team!
quick feature request - can you please add the Address/location field in Group links?

This will allow us to plot where new groups are in the field from just a magic link!

will be a HUGE value for field workers

timezone

disciple-tools-bulk-magic-link-sender/magic-link/magic-links-api.php

Line 887 in 9543815

$time_zones = [

@kodinkat we can use this existing function: DateTimeZone::listIdentifiers( DateTimeZone::ALL );

Ability to translate magic link form front end to other languages

can be done by passing in a language code in the url. Example : magic-link?lang=fr_FR

Switching language:
https://github.com/DiscipleTools/disciple-tools-prayer-campaigns/blob/5c98d3b84554256a7c9fa2e6dd5a9e91039bb577/magic-links/24hour.php#L347

Template type should depend on post type

I think the subassigned type should only appear under contacts:

Send notification when contact fills out their magic link.

When a magic link for a record is filled out, allow the record users to be notified.

Expired magic link page

If a magic key does not exist. Or if it is expired.

Show a landing page instead of the D.T login page.

'this key is not valid or has expired.

pleas login in, look for a more recent key, or ask for a new one.'

Scheduling Links to recur is unsuccessful

Setting links up with a schedule results in only the initial message being sent to WhatsApp and the scheduled reoccurrences don't get sent out. Please view following loom recording for example and investigate issue. I am available to meet and discuss further if needed.

Edit: link to recording will be sent through other communication method

log sending of emails

When Trying to debug why some emails haven't arrived at inboxes
it would be useful to have a note in the Logging section of how many emails were sent successfully etc.

Feature Request: Ability to renew/extend link expiration

When a link is generated with an expiration time, there is now way currently to extend that expiration. If a user is not able to get to the task you've given them in that certain time, it can be useful to just renew the link they already have instead of needing to generate a new one. It would be nice to have a tool or way to do this.

Implement Failure Toasts On Submission

Similar to the toast shown following a successful submission, implement toasts for failed operations.