discoverygarden/embargoes

DEPRECATED: This module has been replaced by https://github.com/discoverygarden/embargo

embargoes's Issues

[BUG] WSOD on Media page

I installed Embargoes, and then found that I could not access the Media page at admin/content/media. It turns out to happen because I had a media type that didn't have any entity reference fields (i.e. wasn't set up for Islandora).

The error in Drupal's logs was:

Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42000]: Syntax     
error or access violation: 1064 You have an error in your SQL syntax;      
check the manual that corresponds to your MySQL server version for the     
right syntax to use near '' at line 4: SELECT "base_table"."vid" AS        
"vid", "base_table"."nid" AS "nid"                                         
 FROM                                                                       
"node" "base_table"                                                        
WHERE; Array 

With XDebug, I placed the exploding query at https://github.com/discoverygarden/embargoes/blob/1.x/src/EmbargoesEmbargoesService.php#L277, i.e. trying to do a node query with an empty orConditionGroup.

Views not respecting embargo

I took an Islandora 1.1.0 image and created a collection with two items:

I then embargoed one of the collection members: "Item One, to be embargoed":

I then opened an incognito window to view the collection:

Notice that it gives a some-what misleading message, because it seems to indicate the collection is under embargo, while only one object in the collection actually is. (Side-note: so we should probably use the node's title instead of "This resource".) You will also see that the teaser of the embargoed node is still shown in the members view.

Clicking on the embargoed node's link does direct us to an "access denied" page; although the node shouldn't have appeared in the first place: