Comments (7)
Just looking back at this, I've found with mock data in the last couple days that the uncertainty on the inc, PA and phase center as returned by the least squares optimizer in FitGeometryGaussian
and FitGeometryFourierBessel
can grossly underestimate the error (the true values being >> 3 sigma from the fitted values). Maybe not surprising, but just to note.
from frank.
A prior flat in cos(inc) is just prior = 1 / inc
unless I'm mistaken.
from frank.
HI Jeff, thanks for this. Do you know whether the very large errors are associated with the fit getting stuck in a local minimum?
from frank.
I don't suspect so, only because the tendency to underestimate the errors is consistent across several initializations of a guess for the geometry (though all for the same mock dataset). But I could be wrong, and I haven't looked into this exhaustively.
I've also varied diff_step
in least_squares
(https://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.least_squares.html) from 1e-3 to 1e2, which hasn't altered the results.
There might be some unique quirk to this dataset that makes the geometry fit difficult, though I don't see what that would be. I'm generating mock visibilities using galario and using estimate_weights
though, so there could be potentially be contributions to the error upstream of the actual geometry fit. I added a couple plots to slack to show.
from frank.
It might be, but I suspect that the errors are just bad. That's sort of expected though
from frank.
Hey @rbooth200 do you want to apply the prior in cos(inc) to the geometry fitting routines? I think it should just be prior = 1 / inc
.
In #164 I added a note to the docs about how the geometry fit won't be accurate for a disc that's highly non-Gaussian, like one with a cavity. For an uncertainty estimate on ~Gaussian discs, I can check if draw_bootstrap_sample
will give a realistic uncertainty estimate. Shouldn't we also be able to get an estimate straight from FitGeometryGaussian
and FitGeometryFourierBessel
though, since they both use least_squares
?
from frank.
Can you check whether the bootstrap gives a reasonable uncertainty estimate?
However, I wonder if the best thing to do might be to note that these automated procedures are not perfect. We could edit the docs to discuss this better, suggest typical uncertainties and point to the appropriate papers that discuss it instead.
from frank.
Related Issues (20)
- Missing definition of position angle (PA) HOT 4
- circleci tests queuing HOT 4
- Move to GitHub Actions
- Unclear behaviour for fixed input geometry HOT 5
- 'frank.mplstyle' not found in the style library HOT 2
- storing priors in 'sol' HOT 5
- improve clarity on optically thick flux rescaling
- Matplotlib warning message HOT 2
- Predict using a different geometry HOT 1
- Add tutorial for mock data
- Debris tutorial HOT 3
- Lognormal tutorial
- tutorial for measurement set <--> visibility table
- tutorial for imaging frank residuals
- streamline multi-fits, determine 'best fit'
- Throw an error on non-convergence
- error I(r) in save_fit wrong when using method lognormal HOT 1
- wrong syntax for np.atleast_1d ? HOT 2
- Broader test coverage
- Warning about bad power spectrum HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frank.