Giter Site home page Giter Site logo

Fix __init__.py about frank HOT 5 CLOSED

discsim avatar discsim commented on July 26, 2024
Fix __init__.py

from frank.

Comments (5)

mtazzari avatar mtazzari commented on July 26, 2024

I think we don't need this line since we are not going to support Python v2 anymore:
from __future__ import division, absolute_import, print_function

I think on what we should/could add before closing the issue.

from frank.

mtazzari avatar mtazzari commented on July 26, 2024

I'd make the changes in a PR, regardless how small it is, so we get it tested before merging into master.

from frank.

rbooth200 avatar rbooth200 commented on July 26, 2024

Should we have any imports in there at all?

from frank.

jeffjennings avatar jeffjennings commented on July 26, 2024

I don't think they're needed for a few reasons:

  • I have all imports in fit.py
  • It would be good to have an option to run the code in order to just plot an existing fit
  • To run the code the user doesn't necessarily need to import FourierBesselFitter (just FrankFitter)

from frank.

rbooth200 avatar rbooth200 commented on July 26, 2024

Ok, that's what I thought too. I'll remove all this stuff and leave an empty init file

from frank.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.