Comments (5)
I don't agree with this, we explicitly use V(q) in the paper, so I would prefer to keep the current notation. It makes even more sense when you think about the arguments passed to the DHT - these should be spatial frequencies. hence q is the correct notation.
If anything we should change vis-> V in geometry. OK?
from frank.
I've pushed a commit doing this to docs_and_runner_jj
from frank.
I agree it's good to be consistent throughout the code. I just find it a bit confusing that a single variable q
(or V
), refers in different parts of the code to either the data or the model. And that the variable in those 2 cases is (or is at, for V
) different baselines. If you don't think that's confusing, I think at least some inline commenting would be helpful.
from frank.
capital V (visibilities) and lower-case v (one component of the uv-points) are now used consistently throughout the code so no comments are needed here. I also don't see what the problem is with q either. The definition is consistent with the paper and the rest of the code.
from frank.
After discussing, we've agreed. Closing!
from frank.
Related Issues (20)
- Missing definition of position angle (PA) HOT 4
- circleci tests queuing HOT 4
- Move to GitHub Actions
- Unclear behaviour for fixed input geometry HOT 5
- 'frank.mplstyle' not found in the style library HOT 2
- storing priors in 'sol' HOT 5
- improve clarity on optically thick flux rescaling
- Matplotlib warning message HOT 2
- Predict using a different geometry HOT 1
- Add tutorial for mock data
- Debris tutorial HOT 3
- Lognormal tutorial
- tutorial for measurement set <--> visibility table
- tutorial for imaging frank residuals
- streamline multi-fits, determine 'best fit'
- Throw an error on non-convergence
- error I(r) in save_fit wrong when using method lognormal HOT 1
- wrong syntax for np.atleast_1d ? HOT 2
- Broader test coverage
- Warning about bad power spectrum
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from frank.