Giter Site home page Giter Site logo

Add tests about frank HOT 5 CLOSED

discsim avatar discsim commented on August 30, 2024
Add tests

from frank.

Comments (5)

mtazzari avatar mtazzari commented on August 30, 2024

Some tests placeholders added in #10
Now need to add real code inside them

from frank.

mtazzari avatar mtazzari commented on August 30, 2024

2 tests still missing:

  • Test IO
  • Test the full pipeline

from frank.

jeffjennings avatar jeffjennings commented on August 30, 2024

For the IO test, in tests.py there's

def test_import_data():
    # TODO
    pass

but how useful is this, as it'll just be checking that np.genfromtxt and np.savetxt / np.save are working?

For the full pipeline test, there are already tests for the geometry fitting and the brightness profile fitting; is there utility in a test for the full pipeline, as it would just additionally be testing that figures can be generated (that np.genfromtxt and plt.savefig are working)?

from frank.

mtazzari avatar mtazzari commented on August 30, 2024

Regarding the IO test, now there is a meaningful test here

def test_import_data():
    """Check the UVTable import function works for a .txt"""
    load_uvtable('tutorials/test_datafile.txt')

from frank.

mtazzari avatar mtazzari commented on August 30, 2024

Regarding the full pipeline test, I agree it would be nice to have it -- indeed I added that in Dec to the todo list above.
However to implement such text will require non-trivial amount of work to check files are created, populated correctly, etc. It could easily take a few days of work.
I've opened #48 to track this.

from frank.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.