<link ... in Head Tag Not Cleaned

[disqus]

from disqus-react.

[tterb]

@renomureza Thanks for your help!
I'll try to get a new version of the package published to NPM later today.

[tterb]

@renomureza Thanks for reporting this issue. It looks like there might be an issue with the cleanup process.
Do you have a public repo that I can use to reproduce this issue?

[renomureza]

Hi @tterb you can check it out here:

• https://codesandbox.io/s/next-disqus-eid24?file=/pages/with-disqus.js
• https://eid24.sse.codesandbox.io/

[tterb]

@renomureza I just put up a PR(#111) to fix this issue. It would be great if you could pull the branch and make sure that it resolves your problem before merging.

[renomureza]

@renomureza I just put up a PR(#111) to fix this issue. It would be great if you could pull the branch and make sure that it resolves your problem before merging.

@tterb It works fine, in <header> it's clean.

But, I noticed at the end of the tag there is an <iframe> which has the same behavior, not cleaned.

[tterb]

@renomureza Nice catch!
I've updated the PR to also remove the referenced iframe.

[renomureza]

@tterb Yes it works, everything is as expected. 🥳

Waiting for release.

[brokul-dev]

Hi!
I've updated disqus-react package to the newest version. Scripts from head and Disqus iframe are removed but there is still one iframe that is not deleted. Here is the result after few roundtrips:

Worth noticing that these iframes do not have title attributes. This attribute is currently used as a query selector in the cleanup code.

Perhaps it's a problem on my side? 🙂

[renomureza]

@brokul-dev i had the same problem, @tterb

[tterb]

@renomureza @brokul-dev Unfortunately, due to the lack of attributes on that iframe there isn't really a way of targeting them for removal that wouldn't cause unintended consequences for any other iframes on the page.