Comments (6)
we'd need to be a lot more careful with the version dependency metadata for built-in plug-ins
Indeed. The safe default would be to only bump plug-ins to newer versions that are explicitly declared compatible with the installed toolkit version, and maybe provide something like the --force
option install to override that default and also install newer plug-ins that aren't officially compatible with the installed version.
from dita-ot.
@infotexture I've been hesitant to try and implement anything that is a real plug-in dependency management into DITA-OT, just because I expect it to be in the class of Really Difficult. But warning about removing a plug-in that some other plug-in depends on should not be too difficult 🤔
from dita-ot.
These are good suggestion, but there are some problems that come with them.
The "unable to delete" is a result of OT trying to delete a JAR file it's currently running. A fix would be to run install and uninstall subcommands with a classpath that only contains the core libraries, none of the plugin libraries. For Bash CLI this is a simple fix, but for Windows the problem is that none of the main developers has a Windows machine. Maybe a fix for Windows could be left for the community to contribute.
from dita-ot.
@infotexture @robander I wonder how much of an issue it will be that
- User installs DITA-OT version 4.2 that ships with plug-in X version 7.3
- User runs
update
subcommand and plug-in X version is updated version 9.1 - User runs into problems with plug-in X transtype and reports an issue for DITA-OT 4.2
We'd need to change our issue reporting templates so that you'd need to paste in the results of running dita plugins
that contains the list of plugi-ns with version numbers.
Another problematic case is
- User installs DITA-OT version 4.2 that ships with build-in plug-ins version 4.2
- User runs
update
subcommand and all build-in plug-ins are updated to version 4.3 - User runs into problems with a build-in plug-in because they rely on some feature added in DITA-OT 4.3
It would also mean that we'd need to be a lot more careful with the version dependency metadata for built-in plug-ins.
from dita-ot.
@jelovirt While you're thinking about safeguarding uninstall
in #4328, we might want to consider reviewing plug-in dependencies as part of the process, so if someone tries to remove a plug-in that another depends on, the action fails with a warning that explains why.
Here's an example of how Homebrew handles this:
❯ brew uninstall ruby
Error: Refusing to uninstall /opt/homebrew/Cellar/ruby/3.2.2_1
because it is required by gem-bundler, which is currently installed.
You can override this and force removal with:
brew uninstall --ignore-dependencies ruby
We can treat this as a separate issue of course, just wanted to mention it here in case it makes sense to combine them.
from dita-ot.
@jelovirt It seems obvious now that you say that's why it could it be removed; not sure why that hadn't occurred to other than having never tried that command before. As a Windows user, I'll be glad to work on (at least) the ability to kill a running .jar file. I think it's also a pretty straightforward thing to do via a command based on a cursory search in StackOverflow.
from dita-ot.
Related Issues (20)
- Release new patch version to fix plugin org.dita.pdf2.fop security issues HOT 6
- NullPointerException in NormalizeTableFilter when reusing table cell HOT 3
- Add a warning in console when chunking is present on multiple levels HOT 3
- NullPointerException in HTML-based transformations when images references ends with `/` HOT 6
- Internal link to an element using keyref within a topic is fails during the topic-key processing HOT 3
- Video poster element has no effect (DITA 2.0) HOT 1
- Links defined in reltables not taken into account when deciding to duplicate topic file names in key scope contexts HOT 1
- Multiple flagging color styles (foreground/background) are not taken into consideration for the same element HOT 2
- Subject Scheme Map - Illegal character in path
- CHM output - trim index values
- index-sort-as elements beginning with newline get sorted as "Specials" HOT 8
- dita2markdown Tables are malformatted when cells contain multiple paragraphs or lists HOT 2
- DITA-OT 4.1.x throw "Error: java.lang.NoSuchMethodError: 'void net.sf.saxon.Configuration.setResourceResolver(net.sf.saxon.lib.ResourceResolver)'" HOT 8
- markdown2dita: notes in lists HOT 2
- markdown2dita: superscript link for footnotes doesn't appear HOT 2
- Update logback libraries HOT 1
- Generate HTML5 metadata attributes in the `index.html` TOC file
- Installing plugin from directory with '@' character results in error HOT 2
- The "image-metadata" step attempts to read content of remote image
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dita-ot.