divadretlaw/emojitext

😃 Render Custom Emoji in Text

emojitext's Issues

Release builds crash when "animated()" is enabled

When I tried animated() I noticed that the release build crashes for png/gif/web.

Code

EXC_BAD_ACCESS

Stress test

This issue have been reported on Ice Cubes

Dimillian/IceCubesApp#1738

If you want to have fun optimizing memory consumption. I haven't looked yet in detail, but the app is spiking around 700 MB of RAM instantly.

Tag versions without the "v" prefix

Presently, Xcode does not support version tags with a "v" prefix (cf. https://forums.swift.org/t/support-for-v-prefixed-version-tags-in-spm-swift-playgrounds-for-ipad/54845/5) and as a result, it's only possible to depend on EmojiText by branch or a commit which is not always optimal.

Would it be possible to tag releases as semantic version numbers from now on? e.g. "v2.0.0" -> "2.0.0"

Thank you!

Displaying emoji in middle of markdown formatted text

I would like to format part of text that might contain emoji using markdown.

Current implementation doesn't allow me to do that as anywhere where there is an emoji formatting breaks. Is there a known workaround? What I want to achieve is <bold text with emoji> <regular text> combined into correctly wrapping text.

---

Non working example:

func test_EmojiInMarkdown() async throws {
    let view = EmojiText(markdown: "**Hello :mastodon:** _Mastodon :mastodon:_ :mastodon:", emojis: [Emojis.mastodon])
    await assertSnapshot(matching: view, as: .rendered(size: CGSize(width: 300, height: 100), delay: 2))
}

pre-rednered text doesn't changed if input changes

Due to the way how SwiftUI View state works there is an issue in EmojiText where, when I modify text provided via initializer it will stay unchanged.

The problem appears when identity of EmojiText doesn't change but the user provides input that might change. The way how pre-rendering works is that it will store modified raw input in internal state. Unfortunately that internal state will survive even if users provide different values keeping previously displayed text unchanged.

A workaround is to explicitly change identity of EmojiText from call site, but it would be better if this library handled input changes automatically.

Below is example code that reproduces the issue. Tapping on "Switch" button doesn't change visible text unless I uncomment the line with id.

struct Preview: View {
    @State private var text = "mastodon :mastodon:"

    private let emojis: [any CustomEmoji] = [
        RemoteEmoji(shortcode: "mastodon", url: URL(string: "https://files.mastodon.social/custom_emojis/images/000/003/675/original/089aaae26a2abcc1.png")!),
        SFSymbolEmoji(shortcode: "iphone")
    ]

    var body: some View {
        VStack {
            EmojiText(verbatim: text, emojis: emojis)
                //.id(text) // Uncommenting this line fixes issue

            Button("Switch") {
                if text.starts(with: "m") {
                    text = "iphone :iphone:"
                } else {
                    text = "mastodon :mastodon:"
                }
            }
        }
    }
}

I tried experimented with a way to resolve it internally by adding onChange(of: raw) inside of EmojiText but that doesn't seem to work for initial change. I'm not sure why and don't have any other ideas currently so I'm submitting this as issue instead of pull request.

Similar issue might happen if provided emojis change but I didn't check that case.