divanteltd/magento1-vsbridge-client

Magento1 js client for VsBridge

This Node.js library enables JavaScript applications to communicate with Magento1 sites using their VsBridge module This module based on the magento2-rest-client module created by Marko Novak (2016).

This module is used by the Vue Storefront - first Progressive Web App for eCommerce.

Installation

The library can be installed using the Npm package manager:

$ npm install --save github:DivanteLtd/magento1-vsbridge-client

Requirements

This module is compatible with magento1-vsbridge

magento1-vsbridge-client's Issues

[FR] RestClient should be exported in magento1-vsbridge-client

RestClient should be exported in magento1-vsbridge-client to give the possibility of painless extending platform endpoints.

Some numeric values don't match with VSF API json schema

In Magento1 vsBridge, json response is created using json_encode with JSON_NUMERIC_CHECK flag.
I guess it's to have all ids in an integer format.

But, it creates some unexpected behaviors:

• cartId: Magento1 (contrary to Magento2), has integer values for cartId. but src/models/order.schema.json from vuestorefront-api defines it as string. Therefore, the schema cannot be validated
• Shipping addresses: postcode and telephone are converted to integer but again, the schema requires them as strings

It's possible to have same bugs elsewhere in magento1 vsBridge (i didn't tested everything)

oauth token in the request destory the request

Hi there,

we have a very mean frontend setup.
So now the bridge is sending an oauth with every request if there is no request token.

So with empty consumerKey and empty consumerSecret it also create an oauth object and use it wihtin the request.

Our Frontend Server does not allow this couse we don't have oauth ;)
It's a firewall settings that we can't change.

So if there is a request with e.g. BasicAuth or Plain Auth there should be no oauth sending with it.