dmitryshelamov/ui-cropping-image

WPF visual cropping image library

ui-cropping-image's Issues

[Enhancement] Make crop resizing flexible

Lightshot also follows this rule.
Regards

Cropped image size is too small

Thanks for posting your code for this project.

Testing it out I noticed an issue where the saved image size would be somewhat too small. The resulting cropped image (saved to disk) appears to be cut off somewhat on the right / bottom at least.

The simplest test cases is:

1. Run sample program
2. Load any sample image
3. Select the entire image as the crop area
4. Save
5. Resulting saved image is smaller than the original

I am running in 120 DPI, I'm not sure if that is related to this issue.

Many thanks

[Enhancement] Added code to keep Rectangle size even (square) and prevent from selecting out of canvas

I needed to crop the pictures into even sided rectangle (square) without having to -painfully- resize it manually to be exact.
For that, I had to set the width to be equal to height.
While testing that, I discovered that there's no protection from creating a square that is still inferior to the canvas in size but still overflowing outside of the canvas borders, so I also added a code that would resize it back inside and within the original canvas. It's working wonders for my project, maybe you'd want to add as a setting and include the code in a future release.

I'm doing my own build to run and include in my project for now.

Code added:

public RectangleManager(Canvas canvasOverlay)
{
            .....
            _originalCanvas = canvasOverlay;
            .....
}

public void UpdateRectangle(double newX, double newY, double newWidth, double newHeight)
 {
            //dont use negative value
            if (newHeight >= 0 && newWidth >= 0)
            {
                Canvas.SetLeft(_rectangle, newX);
                Canvas.SetTop(_rectangle, newY);
                _rectangle.Height = newHeight;
                _rectangle.Width = newHeight;

                if (_rectangle.Height > _originalCanvas.ActualWidth)
                {
                    Canvas.SetLeft(_rectangle, 0);
                    _rectangle.Height = _originalCanvas.ActualWidth;
                    _rectangle.Width = _originalCanvas.ActualWidth;
                }

                if (_rectangle.Height + newX > _originalCanvas.ActualWidth)
                {
                    Canvas.SetLeft(_rectangle, _originalCanvas.ActualWidth - _rectangle.ActualWidth);
                }
                //we need to update dashed rectangle too
                UpdateDashedRectangle();
            }
 }

I can't properly crop these images

I will check the code to try find this bug.