Comments (6)
What do you guys think? @GaiYu0 @ylfdq1118
from dgl.
I actually think allowing anonymous fields makes the model code quite succinct when users are dealing with models that only need one feature (like GCN, DGMG, RGCN).
But I do agree that allowing anonymous fields and explicit fields to co-exist is weird.
I don't think forcing explicit field will add burden to users, so if anonymous field is going to further complicate our implementation in the future, we should remove it.
from dgl.
I think the exsistance of anonymous field would break the consistance in codes. User have to identify whether the variable coming into the function is tensor or dictionary. It would be a burden when writing the code. I think explicit field is better through KISS principle.
from dgl.
@VoVAllen Could you elaborate the example of which most confuses you?
from dgl.
I think we can remove anonymous repr. The most confusing part is when user mixes explicit and implicit fields. As a result, we remove it and enforce user to use dictionary type for all the UDFs. @ylfdq1118 will handle this.
from dgl.
Done in #90 .
from dgl.
Related Issues (20)
- Multi-GPU training for DGL+ALIGNN HOT 2
- [GraphBolt][CUDA] GPUCachedFeature update bug when feature dimensions differ HOT 2
- [release] Build DGL package based on ubi7 to support lower glibc version
- [torchdata] cannot import name 'DILL_AVAILABLE' from 'torch.utils.data.datapipes.utils.common' HOT 2
- [GraphBolt][MultiGPU] Error occurs when running multiGPU example with `num-workers` > 0 HOT 9
- [GraphBolt] FeatureFetcher throws exception if `input_nodes` does not contain target feature HOT 2
- [GraphBolt] Remove workaround for `DILL_AVAILABLE` in torch 2.3.0 HOT 3
- preprocess_ondisk_dataset fails on absolute paths HOT 1
- [Examples]GATNE-T example uses gensim package, which in turn uses deprecated and removed API
- [Misc] Aliases in `typing` are deprecated since py 3.9 HOT 1
- Question/possible bug with SIGNDiffusion transform HOT 1
- Build fails: error: duplicate symbol: libxsmm_verbosity HOT 1
- TypeError: self.chandle cannot be converted to a Python object for pickling HOT 2
- [Bug] [Example] Transformer example is dated and does not work with latest networkx HOT 1
- [GraphBolt] SampledCSC with empty edges for some etype crashes in `create_block()`
- The CreateBlock is slow after we optimized GB dataloader. HOT 1
- [DistGB] add edge ID mapping between DGLGraph and FusedCSCSamplingGraph
- [DistGB] add NC example that uses `DistEdgeDataLoader` for train
- [DistDGL] enable `exclude_edges` for homogeneous DGL graph
- [DistDGL] enable exclude_edges for heterogeneous DGL graph
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dgl.