dnnsoftware/dnn.adminexperience

DNN (formerly DotNetNuke) Combined Admin Experience

dnn.adminexperience's Issues

Refactor GetUser Command Unit Test to Inherit from CommandTest

Description of bug

GetUserUnitTests should inherit from CommandTest Generic class to achieve DRY

Steps to reproduce

Go to the implementation of Extensions\Manage\Dnn.PersonaBar.Users.Tests\GetUserUnitTests.cs

Current result

It does'nt inherit from CommandTest

Expected result

It should be inheriting from CommandTest

Affected version

• 9.2.1
• 9.2

Refactor DeleteUserUnitTests to Inherit from CommandTest

Description of bug

DeleteUserUnitTests should inherit from CommandTest Generic class to achieve DRY

Steps to reproduce

Go to the implementation of Extensions\Manage\Dnn.PersonaBar.Users.Tests\DeleteUserUnitTests.cs

Current result

It does'nt inherit from CommandTest

Expected result

It should be inheriting from CommandTest

Affected version

• 9.2.1
• 9.2

Update issue templates to include Dnn 9.2.2

The issue templates need a checkbox for Dnn 9.2.2

Logout and page

When clicking on logout (personabar), nothing happens (there is a web api request made).
I think its better to refresh the page after logout (response of 200).

Originally created by @kurtwilbies at dnnsoftware/Dnn.AdminExperience.Extensions#191

Disabled Pages not List in Export list for the site

Description of bug

Disabled pages are usually used as placeholders for the menus and such so that only the children pages are visible, so in most cases there are children pages that need to be exported along with the parent page.
And for other user cases, users would still have the option to uncheck the pages if needed.

Steps to reproduce

1. Go to pages and mark one as disabled.
2. Go to Settings > Export/ Import > Export Site

Current result

Disabled Pages are not listed in the treeview

Expected result

Disabled Pages should be listed in Treeview

Affected version

• 9.2.2

SQL Console page title inconsistent

Description of bug

Title of the page should be "SQL Console" to be consistent with spelling in other places

Current result

Group old and new privacy related settings in new tab on Site Settings

Description of problem

We need to be transparent and up front about what DNN is doing in terms of privacy and offer admins the best possible info and options to make the best decisions.

There are now 5 tabs under "Site Behavior": Default Pages, Messaging, User Profiles, Site Aliases, More. Under More you'll find:

• Check for Software Upgrades
• Participate in DNN Improvement Program
  These settings have an impact on privacy and security.

There are settings that are currently not yet in the UI (Show Copyright Notice) or that will be implemented shortly for GDPR (strategies surrounding user deletion, cookie consent, etc). These settings also need to find a place in the UI.

Description of solution

Create a new tab "Privacy" under site behavior. This will hold the existing settings regarding privacy and the future ones we create. It will provide a single home for admins to check all privacy settings.

Popup theme, wrong tabid and no antiForgeryToken

I am developing an angular app, in MVC, using web api, and this works fine in a NON popup theme, such as Admin and Home (Xcillion). In a popup theme the tabid is set to -1 and there is no element RequestVerificationToken and thus using sf to get the antiForgeryToken OR window.document.getElementsByName('__RequestVerificationToken')[0].value is not possible; this occurs only for non administrators. When logged in as super user this issue is not present.

In summary:

1. MVC, DNN popup theme and Non administrator: the above mentioned problem occurs. Using dnn9 with the default theme (Xcillion).
2. In other scenarios the tabid is set correctly and the antiForgeryToken is present.

Originally created by @kurtwilbies at dnnsoftware/Dnn.AdminExperience.Library#9

list-user when multisite or sitegroup then showing users only from master site

Description of bug

list-user when multisite or sitegroup then showing users only from master site
While logged-in as host user and open the
PB > Settings > Prompt
Type "list-users"
a grid with only host user appear and none of the users before site group appear

Steps to reproduce

Login as host in main site
add users in main site e.g user1, user2, user3
goto setttings > Prompt
type "list-users"
will show all users in grid
Create child1(portalid= 1)site in main site(portalid=0)
Make site group of child1 and main-site with child1-site as master site
goto setttings > Prompt
type "list-users"

Current result

Message displayed "No users" or only host user shown

Expected result

All users from site-group should be shown as in PB > Manage > Users

Affected version

• 9.3.0
• 9.2.2

Show Content Pane Labels

Description

When in edit mode > hover over a module > there is a Move flyout menu with content panes listed to reposition the module on a page.

Admins need a way to easily identify the name of each content pane in order for this to be a usable feature.

Originally created by @tpluscode at dnnsoftware/Dnn.EditBar#25

'Use SSL for cache synchonization' in UI does not match database

Description of bug

The 'Use SSL for cache synchonization' switch does not always match the setting value in the database HostSettings table. Switching it on enables the setting, and the change is saved to the database, but the next time you visit the Performance pane, the switch says "Off".

Steps to reproduce

List the steps to reproduce the behavior:

1. Log into a DNN 9.2.1 install as a Super User
2. In the PersonaBar, click Cog (Settings), then Servers
3. Click Server Settings, then Performance
4. Set SSL for Cache Synchronization to On
5. Click Save
6. Refresh the page
7. Navigate back into the Performance pane
8. Note that SSL for Cache Synchronization is Off
9. In the PersonaBar, click Cog (Settings), then SQL Console
10. Enter select * from HostSettings where SettingName = 'UseSSLForCacheSync'
11. Note that SettingValue is true.

Current result

The setting is correctly stored in the database HostSettings table, but is not correctly reflected in the UI.

Expected result

The setting is correctly stored in the database HostSettings table, and is correctly reflected in the UI.

Affected version

• 9.2.1
• 9.2

Affected browser

• Chrome
• Firefox
• Internet Explorer

Branch cleanup

@dnnsoftware/tag

Here's what I propose to clean up branches and branch strategy here:

1. tag the HEAD of each release branch with a matching tag
2. merge release branches into development starting from the oldest
   • any conflicts should be resolved in favour of development
   • ideally, there shouldn't be any
3. delete release branches
4. delete master branch
5. rename development -> master
6. delete development

There are also some stale branches. Most probably should be removed. We can address them later

Originally created by @tpluscode at dnnsoftware/Dnn.AdminExperience.Library#154 and dnnsoftware/Dnn.AdminExperience.Extensions#577

Tooltip not displayed under site link

Description of bug

If you manage sites, there are 3 icons under the site URL for View Site, Site Settings, Export Template. The tooltip is not shown when the mouse in on the icon

Steps to reproduce

List the steps to reproduce the behavior:

1. Login as Host
2. Use Personabar, Manage Sites
3. Hold your mouse in the cell with the site URL, icons appear
4. Move your mouse over an icon
5. The tooltip does NOT appear

Current result

No tooltip

Expected result

Show tooltip, this works in 9.2.0
Suggestion: do not hide the icons until the mouse is over the cell. This surprises the user.

Screenshots

See attachment

Error log

Additional context

Affected version

• 9.2.2
• 9.2.1
• 9.2
• 9.1.1
• 9.1
• 9.0

Affected browser

• Chrome
• Firefox
• Safari
• Internet Explorer
• Edge

PROMPT CMD : get-page showing empty status in

Description of bug

get-page for deleted page showing empty status in PROMPT CMD

Steps to reproduce

logged in as "Host"
add a page namely "prompt-delete-status"
goto setttings > Prompt
type "list-pages"
grab the id of above page in mine case it was 81
now type "delete-page 81"
now type "get-page 81"
look at delete in detail view of page

Current result

Showing empty

Expected result

Should show true or false

Additional context

Add any other context about the bug that may be helpful for resolution.

Affected version

• 9.3.0

Creating new user in Persona Bar asks for Username when using Email as Username

Description of bug

Creating a new user in Persona Bar admin UI asks for Username when using Email as Username

Steps to reproduce

List the steps to reproduce the behavior:

1. Go to Settings Users in Persona Bar
2. Click on Add User
3. Scroll down to Username
4. Option to set Username may not be needed using the setting with email address as username

• 9.2.2
• 9.2.1
• 9.2
• 9.1.1
• 9.1
• 9.0

Affected browser

• Chrome
• Firefox
• Safari
• Internet Explorer
• Edge

Can't go and exit edit mode on pages with #

Description of bug

When user is loged in with edit permissions on a page with with a #xxx at the end of the url.
Then the edit mode pencil and the close edit mode buttons on the bottom of the page (black area) are not working.

Steps to reproduce

1. create a new page
2. go to that page
3. add #xxxx add the end of the url in the adressbar of the browser (or create a link with #xxx on the page)
4. click edit mode button
5. Bug : nothing happen

(xxx : can be all text)

Current result

Nothing happend for the user.
The web api call is fired.
But the page refresh don't hapen.

Expected result

The page don't go to edit mode or go out of edit mode.

Screenshots

Error log

Additional context

This hapen on all pages with javascript that use routing (clientside urls) with #

Error is in EditBar/Dnn.EditBar.UI/editBar/scripts/ExitEditMode.js
line : window.top.location.href = window.top.location.href;

this will maybe solve the problem
window.location.replace(window.top.location.href);
or rediret to page url without de #xxx part
https://stackoverflow.com/questions/503093/how-do-i-redirect-to-another-webpage

Affected version

DNN 9.2

Affected browser

tested on chrome on windows 7

Broken dependencies between Library and Extensions

Summary

Migrated Extensions projects still use nuget of Dnn.PersonaBar.Library

Current result (if necessary)

Project doesn't build right after fresh cone

In SiteGroup, Users should be delete-able from PersonaBar UI from child portal of SiteGroup

Description of bug

Users are not getting delete from portal-site of SiteGroup via PersonaBar UI

Block Issue

This is blocking #52

Steps to reproduce

• Installed engage_9.2.2
• Create child sites with users with Directory option i.e. http://{website1}/child1
• Create Site-Group based on child sites
• Browse to child site i.e. http://{website1}/child1
• Login in as host
• Go to PB > Manage > Users
• Click on right most (...) then click on "Delete-User"
• After that would see message "User have been deleted successfully"
• Goto PB > Content> Recyclebin > Users

Current result

Users not present and reappear in PB > Manage > Users

Expected result

User should be present

Affected version

• 9.2.1
• 9.2
• 9.1.1

Cannot create multiple root terms in hierarchical vocabulary

Description of bug

When adding a term to a hierarchical vocabulary, the first term has no UI to select the parent (which is normal), but then for each new term, there is no way to not select a parent term so it is now impossible to have multiple root terms. This was previously possible in Dnn 8.0.4 and even 7.4.2.

Steps to reproduce

List the steps to reproduce the behavior:
Got To Vocabularies, add a new vocabulary with hierarchical option.
Try to create a hierarchy such as this:

• Electronics
  • Televisions
  • Audio
• Computers
  • Systems
  • Components

Current result

It is impossible in this example to create the computer branch, there is no UI to set no parent after the first term is created (televisions)

Expected result

There should be a way to select no parent

Screenshots

• 9.2.2
• 9.2.1
• 9.2
• 9.1.1
• 9.1
• 9.0

Affected browser

I doubt is is browser related

• Chrome
• Firefox
• Safari
• Internet Explorer
• Edge

SEO: Concatenate Page URLs on Off cause a bad url with two ?

with "Concatenate Page URLs" on Off into SEO settings, when i try to "edit" a module into "Page Setting >Module", the "Module Setting" iframe has an url like (note the double ?):

/my-page?moduleid=11585?popup=true&ctl=module&hidecancel=true&hidedelete=true&noredirectonupdate=true
________^______________^

the double ? cause an exception:

Error: is currently unavailable. DotNetNuke.Services.Exceptions.ModuleLoadException: Formato della stringa di input non corretto. ---> System.FormatException: Formato della stringa di input non corretto. in System.Number.StringToNumber(String str, NumberStyles options, NumberBuffer& number, NumberFormatInfo info, Boolean parseDecimal) in System.Number.ParseInt32(String s, NumberStyles style, NumberFormatInfo info) in DotNetNuke.Modules.Admin.Modules.ModuleSettingsPage.OnInit(EventArgs e)

The problem is in ModuleEdit.js (https://github.com/dnnsoftware/Dnn.AdminExperience.Extensions/blob/2e77c2e19658c90d7cc52c4421a22b26b6c97cf5/src/Modules/Content/Dnn.PersonaBar.Pages/Pages.Web/src/components/Modules/ModuleEdit/ModuleEdit.jsx). This module, into the render() method, always concatenate the this.props.module.editSettingUrl with queryString , without check if this.props.module.editSettingUrl has already a ? , but queryString already has a ?:

const queryString = "?popUp=true&HideCancel=true&HideDelete=true&NoRedirectOnUpdate=true";

My fix is remove ? from queryString and add it if necessary into the render() method:

const queryString = "popUp=true&HideCancel=true&HideDelete=true&NoRedirectOnUpdate=true";

// ...

render() {
        const {state, props} = this;

        let moduleSettingControlPath = this.props.module.editSettingUrl;
        if( moduleSettingControlPath.indexOf('?') === -1 ){ 
            moduleSettingControlPath += '?';
        } else {
           moduleSettingControlPath += '&';
        }
        moduleSettingControlPath += queryString;
        return (state.userMode === "edit" && 
            <iframe ref="iframe" src={moduleSettingControlPath} style={iFrameStyle} frameBorder={0}></iframe>
        );
    }

Originally created by @cesco69

SQL Console - Query results - Sorting not working as expected

Description

Sorting does apply correct order to SQL console results.

Steps to reproduce

• Execute a select query to get results in the results section.
• In the Results Section, click on any column name to sort in ascending order.
• In the Results Section, click on same column name to sort in descending order.
• Click on any other column to sort as per ascending order of that column

Current behavior

Sorting is not working as expected.

Expected behavior

Sorting should be working as expected.

Restore-user from PersonaBar of child-site of Site-group is not working

Description of bug

Restore-user from PersonaBar of child-site of Site-group is not working

Steps to reproduce

Install engage_9.2.2
After creating site-group. Delete-user from child site of master group, So that it should be start showing up in PB > Content > RecycleBin

Go to RecycleBin of child site of Site-group PB > Content > RecycleBin

• Click on User tabs
• Hover on any deleted user and in click on restore icon

Current result

User still appearing.in deleted user in PB > Content > RecycleBin under Users tab

Expected result

User should move successfully to PB > Manage > Users

Affected version

• 9.2.2
• 9.2.1
• 9.2
• 9.1.1

Settings > Custom CSS: + character (adjacent sibling combinator) stripped out on save

Steps to reproduce:

1. Visit PersonaBar > Settings > Custom CSS
2. Enter the following code: .DnnModule + .DnnModule { margin-top: 1rem; }
3. Press Save, and see the success message
4. Refresh the page
5. Visit PersonaBar > Settings > Custom CSS
6. You will see the code now says .DnnModule .DnnModule { margin-top: 1rem; }

Note the + character (adjacent sibling combinator) has been replaced with a blank space character .

What should happen:

The + character should not be stripped out of the Custom CSS.

Notes:

I'm using DNN Evoq Engage 9.2.0.

Tested in the latest versions of Firefox and Chrome on Windows Server 2016.

Originally created by @OllyHodgson at dnnsoftware/Dnn.AdminExperience.Extensions#603

Missing link class on inline help command links for clear-screen

Description of Issue

The inline help command links are not styled correct and thus are very difficult to read.

Steps to Reproduce

• Install DNN 09.02.01
• Go to Settings > Prompt
• Type help
• View links for clear-screen command links

Originally created by @nvisionative at dnnsoftware/Dnn.AdminExperience.Extensions#606

Add youtube playlist on how to submit pull requests

Description

A video walkthrough on how to build the projects, modules, persona bar and submitting pull requesta has been made at https://www.youtube.com/playlist?list=PLIx1M8IdVvqZ0bnODGqJyxvONNPj5BzMP we need to link that in the project documentation

Accessibility of the PersonaBar is pretty bad

Description

A recent post by Katherine Moss to the DNN Connect facebook group has highlighted the accessibility of the Persona Bar is practically non-existent.

A quick look reveals:

• Keyboard navigation (i.e. tabbing through the links on the page) doesn't ever highlight any of the icons in the Personabar or Edit Bar. This is likely to be because the functionality is directly bound to <li> elements - not <a> or <button> elements which are focusable "for free".
• There are no role or aria attributes anywhere in the Persona Bar. Perhaps this W3C toolbar example would be a good role model for DNN?
• The SVG icons have no alt or title text (I'm unsure of the best approach here).

I'm no expert, but even I can see that for a non-sighted user, the DNN 9 admin interface must be nigh on impossible to use.

Steps to reproduce

Open Firefox dev tools. Enable the Accessibility panel. Browse through the Persona Bar. Note that there is almost no useful information there.

Install the Landmarks extension for Firefox/Chrome/Opera. Load a DNN page. Note that the PersonaBar and Edit Bar do not appear.

Try the PersonaBar with other accessibility testing tools. The WAVE extension doesn't seem to notice it at all, but that might be a limitation of the extension.

Current result

Users of assistive technology really struggle to use DNN's admin interface.

Expected result

Users of assistive technology can use DNN's admin interface.

Affected version

• 9.2.1
• 9.2
• 9.1.1
• 9.1
• 9.0

Settings/Delete localization functions is missing in page settings

Description of bug

Settings/Delete localization functions is missing in page settings

Steps to reproduce

1. install evoq 9x and login as host;
2. add a new language and enable content localization in Site Settings;
3. try to edit any page and switch to Localization tab.

Current result

only have the view icon, but no gear icon or trash icon.

Expected result

same functionality with 8x:
eye icon: click to browse the page;
gear icon: click to check the page setting of that localized page;
trash icon: click to delete that localized culture of the page.

Screenshots

• 9.2.2
• 9.2.1
• 9.2
• 9.1.1
• 9.1
• 9.0

Refactor RestoreUserUnitTests to Inherit from CommandTest

Description of bug

RestoreUserUnitTests should inherit from CommandTest Generic class to achieve DRY

Steps to reproduce

Go to the implementation of Extensions\Manage\Dnn.PersonaBar.Users.Tests\RestoreUserUnitTests.cs

Current result

It does'nt inherit from CommandTest

Expected result

It should be inheriting from CommandTest

Affected version

• 9.2.2
• 9.2.1

release/161 Is throwing a javascript error: Error: Cannot find module "../maps/decode.json"

Description of bug

After Installing 922 RC2 or upgrading when you login as an admin and view the Development Console you will see error:

Error: Cannot find module "../maps/decode.json"

Steps to reproduce

List the steps to reproduce the behavior:

1. Install 922 RC2
2. Login as admin or host
3. View development console in browser
4. See error

Current result

Error: Cannot find module "../maps/decode.json" is shown

Expected result

No javascript errors should be displayed in the console.

Affected version

• 9.2.2
• [] 9.2.1
• [] 9.2
• [] 9.1.1
• 9.1
• 9.0

Affected browser

• Chrome
• Firefox
• Safari
• Internet Explorer
• Edge

Upgrade RequireJS to latest version

Description

Upgrade RequireJS to latest version, currently we have 2 places of requirejs referenced:

1. StructuredContentVisualizer module - version 2.3.3
2. PersonaBar - version 2.1.11

Latest version: http://requirejs.org/docs/download.html version 2.3.5
need upgrade both places to 2.3.5 and make sure nothing is broken.

Originally created by @tpluscode at dnnsoftware/Dnn.AdminExperience.Library#157

About Screen - Evoq License Management and Not DNN Platform Info

Description of bug

The About screen located in Settings > About appears to be a license management screen for the commerical Evoq products.

Given that this is the DNN Platform, the About screen should have generic information regarding the DNN Platform and not commerical products.

Steps to reproduce

1. Login to DNN
2. From the Persona Bar, hover over Settings
3. Select About

Current result

Users of the DNN Platform are presented with an Evoq licensing screen.

Expected result

Generic information regarding the DNN Platform.

Some types of information that could be displayed are:

• Current version / build info
• Links to current known issues for the version in question
• Links to the release notes for the version in question
• Links to the DNN documentation and help materials
• Etc.

Affected version

• 9.2.2
• 9.2.1
• 9.2
• 9.1.1
• [ x] 9.1
• [x ] 9.0

Missing styles in 9.2 to notify user which pages are hidden/Disabled

Description

In 9.1 system used to display flag icon which lets user know if page is hidden or disabled. in 9.2 there no such direct notification

Expected

Actual

Affected version

• 9.2

Originally created by @tpluscode at dnnsoftware/Dnn.AdminExperience.Extensions#584

Managing version numbers (of code and install packages)

Currently version number have to be managed multiple times across every repository. For this repository alone it's 22 manifest files which have to be changed every time we bump the version (no wonder we bump it ver rarely 🙁). The numbers in the .dnn manifests are then taken as the zip installer version. Hence these artifacts, as seen in builds from #539 are still 1.6.0, even though GitVersion wrongly calculated 1.5.1. Just imagine how many there are across all Plaftorm/Evoq codebase.

---

So, with GitVersion we would not have the version number at all. Anywhere! Not in .dnn, not in AssemblyInfo.cs. Anywhere. That version would only ever be calculated from the git branching. The tool has a lot to offer in terms of configuration. It is being affected mainly by tags and merges with release branches.

Originally created by @tpluscode at dnnsoftware/Dnn.AdminExperience.Extensions#578

Refactor SetUserUnitTests to Inherit from CommandTest

Description of bug

SetUserUnitTests should inherit from CommandTest Generic class to achieve DRY

Steps to reproduce

Go to the implementation of Extensions\Manage\Dnn.PersonaBar.Users.Tests\SetUserUnitTests.cs

Current result

It does'nt inherit from CommandTest

Expected result

It should be inheriting from CommandTest

Affected version

• 9.2.1
• 9.2

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

Can't change host email in Dnn 9

This issue was moved here because it is only a UI issue, it was originally at dnnsoftware/Dnn.Platform#2050

In previous versions of Dnn, there was a setting in Host Settings to set the host email. This email was used when testing the SMTP server settings. So when testing the emails, users do not receive the email since they don't have access to [email protected] (the default on new installations)

Also, some modules may use that email address to notify the host, so people changing their email and not having control over this, stop receiving those notifications.

I think this could be added in Settings -> Server Settings -> SMTP Server

In the database, this is stored in HostSettings Table with a SettingName of HostEmail

Originally created by @valadas at dnnsoftware/Dnn.AdminExperience.Extensions#604

Cannot Create Module from Manifest

GetModuleFiles function doesn't retrieve manifest files

Wrong Get: /API/PersonaBar/Extensions/GetModuleFiles?ownerFolder=MyFolder&moduleFolder=SubFolder&type=3

Correct Get: /API/PersonaBar/Extensions/GetModuleFiles?ownerFolder=MyFolder&moduleFolder=SubFolder&type=2

change js function in Admin\Dnn.PersonaBar\Modules\Dnn.Extensions\scripts\bundles\extensions-bundle.js
'onFolderSelect' .... type: 3 to type: 2

Originally created by @ala-musleh at dnnsoftware/Dnn.AdminExperience.Extensions#47

Can not create a user with a username contains backslash "\"

I want to add a new active directory user to my dnn like "DES\j.olsen" how ever I receive error "The username specified is invalid. Please specify a valid username."

I thought I can fix it buy overriding the "User Name Validation" regular expression from security area but it didn't help me too.

I was able to do that in dnn 8.x but I can't do it in dnn 9.2.0 and 9.2.1.

Update Security Analyzer to show a warning for RichText profile properties

Description of problem

Currently the security analyzer flags the Biography field as an failure due to it's default configuration of being a rich text field.

Description of solution

We need to switch this to a warning, maybe update the steps to include a bit more details on where to go and change this to a basic text input.

Ability to hide persona bar

Description

It is hard to view all content when you use sites that have 100% width. Personabar hides how it looks and sometimes buttons or links to other parts of the site.

Steps to reproduce

Install DNN
Login as Host or Administrator
Edit a page with 100% width module or skin menu

Current result

Cannot view or select anything hidden behind the persona bar

Expected result

Two options in my mind.

One is the entire website shifts over to where the persona bar edge is so you can see the entire site look and feel along with testing functions such as links and buttons.

The other would be to have a switch or carrot icon/arrow icon that allows you to hide/unhide the persona bar so you can select it.

Another is keep persona bar hidden to the side and only if you hover your mouse over it does it popout and then select with a PIN to pin it open or keep it open if you need it a lot.

Affected version

• 9.2
• 9.1.1
• 9.1
• 9.0

Affected browser

• Chrome
• Firefox
• Safari
• Internet Explorer
• Edge

Action required: Greenkeeper could not be activated 🚨

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

UX: "It appears you have a slow connection..." is misleading

Description of bug

During long running operations, DNN will show a "It appears you have a slow connection... We are processing your content" message. Almost every time I've encountered this, it's been due to DNN taking a long time to process a complex request.

I suggest the language is changed to something closer to the truth, e.g. "This task is taking a while. We are still processing your content". Or it could just be reduced to "We are processing your content".

Steps to reproduce

Do anything which will cause a long-running request in the PersonaBar. For example:

1. PersonaBar > Content > Pages
2. Add Multiple Pages
3. Paste in a list of 100 page titles to add
4. Click Add Pages

Current result

After a while the user is shown a "It appears you have a slow connection... We are processing your content" message.

Expected result

DNN doesn't blame the user's connection for its own slow response.

Screenshots

Additional context

Whatever message is chosen, I imagine it will need to be translated.

Affected version

• 9.2.2
• 9.2.1
• 9.2
• 9.1.1
• 9.1
• 9.0

Affected browser

n/a

Missing entries in sums.resources for 9.2.2

Checksums must be calculated and added to sums.resources for the 9.2.2 release

Personabar lazy loading + caching

The method call 'gettable' (GET /API/personaBar/localization/gettable?culture=en-US HTTP/1.1) needs to be cached. Lazy loading would be even better. I personally use 'Strathweb.CacheOutput' and it works fine. So cache the web api methods with Strathweb.CacheOutput, e.g., [CacheOutput(ClientTimeSpan = 3600, ServerTimeSpan = 3600)].

Originally created by @kurtwilbies at dnnsoftware/Dnn.AdminExperience.Extensions#192

Update login page

Dnn9 without updating the login and profile page is NOT complete, especially from a marketing perspective. The whole community would like to see these changes (actually now for years).Please update those pages.

Originally created by @kurtwilbies

Server menu is not displayed

Description

With recent builds of 9.2.1 some Persona Bar menus were not working. Turns out that the CI did not capture yarn install failure and we were using broken React bundles:

export-bundle.js?cdv=65:2 Uncaught Error: Minified React error #130; visit http://facebook.github.io/react/docs/error-decoder.html?invariant=130&args[]=undefined&args[]=%20Check%20the%20render%20method%20of%20%60t%60. for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
at n (export-bundle.js?cdv=65:2)
at i (export-bundle.js?cdv=65:61)
at r (export-bundle.js?cdv=65:172)
at o (export-bundle.js?cdv=65:29)
at o (export-bundle.js?cdv=65:29)
at i (export-bundle.js?cdv=65:29)
at Object.instantiateChildren (export-bundle.js?cdv=65:172)
at h._reconcilerInstantiateChildren (export-bundle.js?cdv=65:173)
at h.mountChildren (export-bundle.js?cdv=65:173)
at h._createInitialChildren (export-bundle.js?cdv=65:173)

The root cause was yarn.lock referring the private MyGet repository.

Originally created by @tpluscode at dnnsoftware/Dnn.AdminExperience.Extensions#576

Reinstate "Make page private / Make page public" toggle

Description of problem

Since the move to the Persona Bar the 'Make page private / Make page public' toggle was removed. I get clients asking where this is as it was an easy way to do this.

Description of solution

I suggest adding this back in to the edit page bar next to the Add Module buttons so it is easy to toggle the visibility of a page.

Affected version

• 9.2.2
• 9.2.1
• 9.2
• 9.1.1
• 9.1
• 9.0

Affected browser

None

• Chrome
• Firefox
• Safari
• Internet Explorer
• Edge

Engage - Pages - Viewing Analytics - On click, no action is performed

Steps to reproduce

1. Open Persona Bar > Pages
2. Click on published, visible page in the tree view
3. Hover the mouse over on ellipsis icon
4. Click on Analytics

Expected result

Analytics section should be displayed.

Actual result

On click of Ellipsis, no action is performed

Browser console shows error when click on Analytics:

export-bundle.js?cdv=126:15 Uncaught TypeError: this.props.CallCustomAction is not a function
at t.value (<anonymous>:21:23687)
at Object.r (export-bundle.js?cdv=126:15)
at a (export-bundle.js?cdv=126:15)
at Object.s [as executeDispatchesInOrder] (export-bundle.js?cdv=126:15)
at d (export-bundle.js?cdv=126:14)
at f (export-bundle.js?cdv=126:14)
at Array.forEach (<anonymous>)
at n (export-bundle.js?cdv=126:61)
at Object.processEventQueue (export-bundle.js?cdv=126:14)
at r (export-bundle.js?cdv=126:173)
value @ VM316:21
r @ export-bundle.js?cdv=126:15
a @ export-bundle.js?cdv=126:15
s @ export-bundle.js?cdv=126:15
d @ export-bundle.js?cdv=126:14
f @ export-bundle.js?cdv=126:14
n @ export-bundle.js?cdv=126:61
processEventQueue @ export-bundle.js?cdv=126:14
r @ export-bundle.js?cdv=126:173
handleTopLevel @ export-bundle.js?cdv=126:173
i @ export-bundle.js?cdv=126:173
perform @ export-bundle.js?cdv=126:14
batchedUpdates @ export-bundle.js?cdv=126:173
i @ export-bundle.js?cdv=126:13
dispatchEvent @ export-bundle.js?cdv=126:173

Originally created by @tpluscode at dnnsoftware/Dnn.AdminExperience.Extensions#602

Create more meaningful issue templates

Description

Currently only one issue template exists and it is very ISSUE focused.

Steps to reproduce

Click New Issue button on GitHub repo.

Current result

A single issue template is used based on ISSUE_TEMPLATE.md.

Desired result

The user should be able to choose from several issues types (e.g., Bug Report, Feature Request, Help & Other Questions)

Affected version

• 9.2.1
• 9.2
• 9.1.1
• 9.1
• 9.0

Affected browser

• Chrome
• Firefox
• Safari
• Internet Explorer
• Edge

RFC: UX: Clicking in the area to the right of a PersonaBar editing pane makes it disappear

Description of bug

Often, when in the middle of a task I'll accidentally click outside the PersonaBar. My first thought is usually a four letter expletive.

Over time I've learnt I can usually pick up where I left off by navigating through the menu again, but when I first used DNN this was really frustating: I thought I'd lost my work.

I also have to write step by step instructions for people to make changes on the system. They're IT support people, who don't know DNN at all. This happens to them all the time - and I have to take the calls to help them get back to where they were.

Steps to reproduce

1. Open one of the editing panes from the personabar
2. Start work on a multi-step task, such as installing an extension
3. Halfway through, click in the grey area to the right of the editing pane
4. Panic, thinking you've lost your progress

Current result

The PersonaBar edit pane disappears.

Expected result

Nothing happens. The PersonaBar edit pane only closes when you click the close icon in the top right.

Screenshots

Step 4 of 5? Don't accidentally click on the right of the screen:

Should only close when you click on the close button:

Affected version

• 9.2.2
• 9.2.1
• 9.2
• 9.1.1
• 9.1
• 9.0