dnnsoftware/dnn.adminexperience.library

DNN Admin Experience Library

dnn.adminexperience.library's Issues

Branch cleanup

@dnnsoftware/tag

Here's what I propose to clean up branches and branch strategy here:

1. tag the HEAD of each release branch with a matching tag
2. merge release branches into development starting from the oldest
   • any conflicts should be resolved in favour of development
   • ideally, there shouldn't be any
3. delete release branches
4. delete master branch
5. rename development -> master
6. delete development

There are also some stale branches. Most probably should be removed. We can address them later

Upgrade RequireJS to latest version

Description

Upgrade RequireJS to latest version, currently we have 2 places of requirejs referenced:

1. StructuredContentVisualizer module - version 2.3.3
2. PersonaBar - version 2.1.11

Latest version: http://requirejs.org/docs/download.html version 2.3.5
need upgrade both places to 2.3.5 and make sure nothing is broken.

A potential security vulnerability in Dnn.AdminExperience.Library

GitHub raises a possible vulnerability in momen.js we use

Please refer to this report: https://nvd.nist.gov/vuln/detail/CVE-2017-18214

Suggested fix is to update package.json with moment ~> 2.19.3

Update login page

Dnn9 without updating the login and profile page is NOT complete, especially from a marketing perspective. The whole community would like to see these changes (actually now for years).Please update those pages.

Popup theme, wrong tabid and no antiForgeryToken

I am developing an angular app, in MVC, using web api, and this works fine in a NON popup theme, such as Admin and Home (Xcillion). In a popup theme the tabid is set to -1 and there is no element RequestVerificationToken and thus using sf to get the antiForgeryToken OR window.document.getElementsByName('__RequestVerificationToken')[0].value is not possible; this occurs only for non administrators. When logged in as super user this issue is not present.

In summary:

1. MVC, DNN popup theme and Non administrator: the above mentioned problem occurs. Using dnn9 with the default theme (Xcillion).
2. In other scenarios the tabid is set correctly and the antiForgeryToken is present.

PB General: mouseover does not work in Chrome and FF

Description

On IE, the personabar will pop up the menu when you mouseover the icons. On FF and Chrome, it does not work. The usability is very poor because if you need to go to Manage > Roles, you have to click on the icon twice (the first time the Manage > Users panel opens, and click a second time to go to the Roles panel).

This problem is reported in the forums as well by other users. Clearing cache, resource management has no effect as suggested in the forum thread.

http://www.dnnsoftware.com/forums/threadid/534984/scope/posts/persona-bar-menu-fly-out-not-working-with-chrome

Make Persona Bar UserSetting free of Evoq parameter in platform and extensible

Description

https://github.com/dnnsoftware/Dnn.AdminExperience.Library/blob/development/src/Dnn.PersonaBar.Library/DTO/UserSettings.cs

Persona Bar user settings is a mechanism to store server side the user preference for the persona bar consume then in the UI.

These settings are used to store the latest panel open, if the panel was open, the latest query for analytics, etc… So the next time the user comes to the Persona bar will find the same setup, its preferences in place.

Issue

1. The current implementation makes use of a Fixed Schema Entity Object (not extensible)
2. The current implementation expose settings used only in Evoq
   • Some of these properties make sense for a product independent Persona Bar (i.e.: Expand PersonaBar, Active Path, Active Identifier), but other are fixed to feature in Evoq (i.e.: endDate, comparativeTerm, period, legends, expandTasks).

The goal of this improvement is remove any Evoq specific parameters and make the system extensible so other panels could take the benefit of this mechanism (starting with Evoq params).

Note: we have to consider if the new system is backward compatible, in case some third party could potencially using the old settings (however, I do not think will be the case as these are fixed and used already in specific area).

Evoq Site Settings modules' load is not synchronized

Description

In PB -> SiteSettings -> Search of Evoq we have two extra tabs: Crawiling and File Extensions.

These two extra tabs come from Dnn.AdminExperience.Evoq.Basic and they are injected into the main SiteSettings module defined in Dnn.AdminExperience.Extensions.
The way this extension works is totally unreliable since it is based on two single and not-dependent asynchronous calls, as shown in this code snippet:

var init = function (wrapper, util, params, callback) {

        window.dnn.initSiteSettings = function initializeSiteSettings() {
            return {
                utility: util,
                siteRoot: config.siteRoot,
                settings: params.settings,
                moduleName: 'EvoqSiteSettings',
                identifier: params.identifier
            };
        };

        window.dnn.SiteSettings = {};

        util.loadBundleScript('modules/dnn.sitesettings/scripts/bundles/evoq-site-settings-bundle.js');

        wrapper.on('init.extension', function () {
            if (!window.dnn.SiteSettings.bundleLoaded) {
                setTimeout(function () {
                    util.loadBundleScript('modules/dnn.sitesettings/scripts/bundles/site-settings-bundle.js');
                }, 0);
            }
        });

        if (typeof callback === "function") {
            callback();
        }
    };

Here is the source on GitHub: https://github.com/trilogy-group/Dnn.AdminExperience.Evoq.Basic/blob/4f252625334f8937cdb8106ae6eecead3940b8b5/src/Modules/Evoq.PersonaBar.SiteSettings/admin/personaBar/scripts/EvoqSiteSettings.js#L9

Current behavior

• Sometimes the site-settings-bundle.js is loaded before evoq-site-settings-bundle. In this case, errors appears in the browser console and the two extra tabs (Crawiling and File Extensions) are not injected into the application.
• Even retrying to reload many times is not sure that extra tabs will appear, since the load sequence of the two bundles is not managed at all.
• To prevent this issue (partially and badly), a setTimeout by 500ms was set in the bootstrap of Evoq Site Settings React project. It has been fixed by Dnn.AdminExperience.Extensions#511

Expected behavior

• evoq-site-settings-bundle.js should be loaded before site-settings-bundle.js, being it a dependency
• site-settings-bundle.js should be loaded only once its dependency has been loaded
• dependencies must not have any asynchronous initialization code, to avoid unpredictable behaviors

Prompt List-pages : deleted flag default value should be true

Steps to reproduce

1. Open DNN platform and login as super user
2. Open PB > Settings > prompt
3. Write down help list-pages
4. Confirm that deleted default value is true
5. Write down list-pages --deleted
6. Press enter and validate the results

Expected results

Deleted pages shall appear to the user

Results

Not deleted pages appear to the user indicating that default value for the parameter is false.

Can't change host email in Dnn 9

This issue was moved here because it is only a UI issue, it was originally at dnnsoftware/Dnn.Platform#2050

In previous versions of Dnn, there was a setting in Host Settings to set the host email. This email was used when testing the SMTP server settings. So when testing the emails, users do not receive the email since they don't have access to [email protected] (the default on new installations)

Also, some modules may use that email address to notify the host, so people changing their email and not having control over this, stop receiving those notifications.

I think this could be added in Settings -> Server Settings -> SMTP Server

In the database, this is stored in HostSettings Table with a SettingName of HostEmail