dnnsoftware/dnn.evs

DNN (formerly DotNetNuke) Extension Verification Service

dnn.evs's Issues

PetaPoco Excluded from EVSAppController

Is the PetaPoco.cs intentionally excluded from the project? If yes, do we need to keep it?

Extra Unused Folders in ProcessStorePackages

There are no files in these folders (image below). Do the folders have a purpose?

Show error if manifest contains comments

Dnn chokes on manifests that contain xml comments, EVS should detect and give an error if the manifest has any comments.

Create issue templates

Description

Currently there are no issue templates for this repo.

Steps to reproduce

Click New Issue button on GitHub repo.

Current result

No issue templates are used.

Desired result

The user should be able to choose from several issues types (e.g., Bug Report, Feature Request, Help & Other Questions)

Affected version

• ?.?.?

Issue Warnings for DLL's that Don't Include a Version

In the manifest, you're able to specify DLL's that should be installed with an extension. This tells the installer what they are, and that they should be found in the installation package.

It's currently optional to include a version number for the DLL, which is okay since it introduces flexibility for multiple use cases. An example of both scenarios is below.

<component type="Assembly">
  <assemblies>
	<assembly>
	  <path>bin</path>
	  <name>EntityFramework.dll</name>
	  <sourceFileName>bin\EntityFramework.dll</sourceFileName>
	</assembly>
	<assembly>
	  <path>bin</path>
	  <name>ImageResizer.dll</name>
	  <sourceFileName>bin\ImageResizer.dll</sourceFileName>
	  <version>4.0.0</version>
	</assembly>
  </assemblies>
</component>

The EVS scan should create a warning message for each DLL that does not include a version number. It's not an error message, but it's definitely something for a website owner to be aware of before installing an extension.

EVS scan may have a false negative about the script path for JS packages.

Hello. jQuery UI and Knockout are JavaScript libraries that help provide easy-to-use features and display data. The current version of jQuery UI and Knockout that I had on my DNN site is not considered to be the most secure versions available, I looked for a way to update these to version 01.13.01 and 03.05.01, respectively.

To achieve this update I proceeded to create extension installation packages for each of these libraries.

Having these installations ready, I carried out tests using the EVS tool, in each of the tests I carried out I received a Warning Message: A file (\jquery-ui.min.js) was found in the extension that was not included in the manifest, A file (\knockout.js) was found in the extension that was not included in the manifest. However, these files are included within the corresponding manifests.

I have tested several DNN extension installation packages and all of them give me the same warning messages.

I'm reporting this because it seems that EVS parsing may have a false negative about the script path for JS packages.

I installed these packages on my site and they installed successfully
• .JS files are copied to the path where they should be within my site.
• In the console I could see that the site is also loaded correctly.
• There are no errors on the site pages.

Here I attach the installation packages of the libraries in case you want to try them.

jQueryUI.Library.01.13.01.Install.zip
KnockoutJs.Library.03.05.01.Install.zip

@WillStrohl

DNN 9.x Missing from EVSWorker

Is there supposed to be a DNN 9.xx collection of provider files here?

Add GitHub Topics to repo

At minimum, please add dnn, dotnetnuke and dnncms GitHub Topics to this repo.

Update GitHub repo Description to include keywords

Please update the this repo's description to include, at minimum, the keywords DNN and DotNetNuke. Currently DNN's is used, which throws off GitHub search attempts. The recommended way is to use something like:
DNN (formerly DotNetNuke) Extension Verification Service

RemoteDebugManager Excluded from EVSWorker

Is the RemoteDebugManager.cs intentionally excluded from the project? If yes, do we need to keep it?

Developer Documentation

Please add documentation to either the wiki or the readme.md to help us know how best to get setup and test our changes before we submit a pull request.

As of right now, the wiki redirects to the main page.

Update README to include DNN and DotNetNuke keywords for increased GitHub search exposure

The current README files does not include the keywords DNN and DotNetNuke. At minimum, these should be included to ensure the repo can be discovered better via GitHub search.

Add topics to the repo

Please add at least the following (GitHub) topics to this repository:

dnn
dnncms
dotnetnuke