doherty/dist-zilla-plugin-test-unusedvars

Release tests for unused variables

dist-zilla-plugin-test-unusedvars's Issues

Don't blindly assume lib exists

If lib doesn't exist, then plan skip_all. We might consider checking bin as well.

Another mechanism is needed for finding files

Sometimes what's in the MANIFEST is not an accurate list of the files to be tested - for example if a .pm file is generated by a script at build time, the resulting file won't be in MANIFEST. In this case, simply calling all_vars_ok is not sufficient.

There should be another way to determine the files to be tested - either by using File::Find in lib or blib, or by using a FileFinder option (with an extra option to add in additional files). e.g. see [Test::Compile].

Random failures under `HARNESS_OPTIONS=j10`

Parallel

export HARNESS_OPTIONS=j10

1

Building and testing Dist-Zilla-Plugin-Test-UnusedVars-2.000004 ... Building Dist-Zilla-Plugin-Test-UnusedVars
t/00-compile.t .. ok                                                    
t/everything.t .. ok                                                    
t/deprecated.t .. 1/2 Can't locate directory /home/kent/.cpanm/work/1375385522.519515/Dist-Zilla-Plugin-Test-UnusedVars-2.000004/tmp/XIw0rV7EDE/source at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Dist/Zilla/Tester.pm line 156.
# Looks like you planned 2 tests but ran 1.
# Looks like your test exited with 2 just after 1.
t/deprecated.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 1/2 subtests 

Test Summary Report
-------------------
t/deprecated.t (Wstat: 512 Tests: 1 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 2 tests but ran 1.

2

You can s)kip, r)etry, f)orce install, e)xamine build log, or l)ook ? [s] r
t/00-compile.t .. ok                                                    
t/deprecated.t .. ok                                                    
t/everything.t .. no viable configuration could be found


Trace begun at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Config/MVP/Reader/Finder.pm line 48
Config::MVP::Reader::Finder::_which_reader('Dist::Zilla::MVP::Reader::Finder=HASH(0x35fd020)', 'Path::Class::File=HASH(0x35f4210)') called at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Config/MVP/Reader/Finder.pm line 76
Config::MVP::Reader::Finder::try {...}  at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Try/Tiny.pm line 81
eval {...} at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Try/Tiny.pm line 72
Try::Tiny::try('CODE(0x35fd0c8)', 'Try::Tiny::Catch=REF(0x35e0130)') called at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Config/MVP/Reader/Finder.pm line 81
Config::MVP::Reader::Finder::read_config('Dist::Zilla::MVP::Reader::Finder', 'Path::Class::File=HASH(0x35f4210)', 'HASH(0x35f4270)') called at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Dist/Zilla/Dist/Builder.pm line 220
Dist::Zilla::Dist::Builder::try {...}  at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Try/Tiny.pm line 81
eval {...} at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Try/Tiny.pm line 72
Try::Tiny::try('CODE(0x307d870)', 'Try::Tiny::Catch=REF(0x35c4080)') called at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Dist/Zilla/Dist/Builder.pm line 245
Dist::Zilla::Dist::Builder::_load_config('Dist::Zilla::Tester::_Builder', 'HASH(0x307d408)') called at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Dist/Zilla/Dist/Builder.pm line 26
Dist::Zilla::Dist::Builder::from_config('Dist::Zilla::Tester::_Builder', 'HASH(0xcb0208)') called at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Dist/Zilla/Tester.pm line 144
Class::MOP::Class:::around('CODE(0x1e9bb90)', 'Dist::Zilla::Tester::_Builder', 'HASH(0xcb0208)', 'HASH(0xcc5260)') called at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/x86_64-linux/Class/MOP/Method/Wrapped.pm line 162
Class::MOP::Method::Wrapped::__ANON__('Dist::Zilla::Tester::_Builder', 'HASH(0xcb0208)', 'HASH(0xcc5260)') called at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/x86_64-linux/Class/MOP/Method/Wrapped.pm line 91
Dist::Zilla::Tester::_Builder::from_config('Dist::Zilla::Tester::_Builder', 'HASH(0xcb0208)', 'HASH(0xcc5260)') called at t/everything.t line 8
# Looks like your test exited with 255 before it could output anything.
t/everything.t .. Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 1/1 subtests 

Test Summary Report
-------------------
t/everything.t (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 1 tests but ran 0.
Files=3, Tests=4,  1 wallclock secs ( 0.03 usr  0.01 sys +  3.38 cusr  0.30 csys =  3.72 CPU)
Result: FAIL

3

You can s)kip, r)etry, f)orce install, e)xamine build log, or l)ook ? [s] r
t/00-compile.t .. ok                                                    
===(       3;1  1/2  0/1 )==============================================cannot fetch initial working directory: No such file or directory at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Path/Class/Dir.pm line 155.
can't open /home/kent/.cpanm/work/1375385522.519515/Dist-Zilla-Plugin-Test-UnusedVars-2.000004/tmp/L2m58kIcpH/source/dist.ini for reading: No such file or directory at /home/kent/perl5/perlbrew/perls/perl-5.18.0/lib/site_perl/5.18.0/Dist/Zilla/File/OnDisk.pm line 33, <DATA> line 9.
# Looks like your test exited with 2 before it could output anything.
t/everything.t .. Dubious, test returned 2 (wstat 512, 0x200)           
Failed 1/1 subtests 
t/deprecated.t .. ok

Test Summary Report
-------------------
t/everything.t (Wstat: 512 Tests: 0 Failed: 0)
  Non-zero exit status: 2
  Parse errors: Bad plan.  You planned 1 tests but ran 0.

Single Threaded

export HARNESS_OPTIONS=j1

Building and testing Dist-Zilla-Plugin-Test-UnusedVars-2.000004 ... Building Dist-Zilla-Plugin-Test-UnusedVars
t/00-compile.t .. ok   
t/deprecated.t .. ok   
t/everything.t .. ok   
All tests successful.
Files=3, Tests=5,  2 wallclock secs ( 0.03 usr  0.01 sys +  2.20 cusr  0.18 csys =  2.42 CPU)
Result: PASS

variable will be reported as unused when it is used only in regexp

$t will be reported as 'unused' in this example:

sub a{
  my $t = "abc";
  $t =~ /(.*)c/;
  return $1;
}

Arguments to skip are reversed

The arguments to skip (i.e., when Test::Vars is not installed) are reversed in the xt/unused-vars.t

Instead of:

skip 1 => 'Test::Vars required for testing for unused vars'
        if $@;

it should be:

skip 'Test::Vars required for testing for unused vars' => 1
        if $@;

2 dots version number without 'v'

Current release is '2.0.1' instead of 'v2.0.1' or a decimal number with a single dot. This is not a version format following best practices, and this may break some CPAN toolchain tools.

See version.pm for recommandations about version numbers.

perl-5.16 deps on Test-Vars failed

MacBook-Air-de-Geistteufel:MooX-Options (master=) geistteufel$ cpanm --prompt $(dzil authordeps --missing)
cpanm (App::cpanminus) 1.5011 on perl 5.016000 built for darwin-thread-multi-2level
Work directory is /Users/geistteufel/.cpanm/work/1337988155.68326
You have make /usr/bin/make
You have LWP 6.04
You have /usr/bin/tar: bsdtar 2.8.3 - libarchive 2.8.3
You have /usr/bin/unzip
Searching Dist::Zilla::Plugin::Test::UnusedVars on cpanmetadb ...
--> Working on Dist::Zilla::Plugin::Test::UnusedVars
Fetching file:///Volumes/MACBOOKAIREXT/Devel/minicpan/authors/id/D/DO/DOHERTY/Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2.tar.gz ... FAIL
! Download file:///Volumes/MACBOOKAIREXT/Devel/minicpan/authors/id/D/DO/DOHERTY/Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2.tar.gz failed. Retrying ... 
! Download file:///Volumes/MACBOOKAIREXT/Devel/minicpan/authors/id/D/DO/DOHERTY/Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2.tar.gz failed. Retrying ... 
! Download file:///Volumes/MACBOOKAIREXT/Devel/minicpan/authors/id/D/DO/DOHERTY/Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2.tar.gz failed. Retrying ... 
! Failed to download file:///Volumes/MACBOOKAIREXT/Devel/minicpan/authors/id/D/DO/DOHERTY/Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2.tar.gz
Fetching http://cpan.celogeek.com/authors/id/D/DO/DOHERTY/Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2.tar.gz ... OK
Unpacking Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2.tar.gz
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/MANIFEST
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/README
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/Changes
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/META.json
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/META.yml
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/cpan-changes.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/mojibake.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/unused-vars.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/pod-coverage.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/no-tabs.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/distmeta.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/minimum-version.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/kwalitee.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/pod-syntax.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/portability.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/dist-manifest.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/pod-linkcheck.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/test-version.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/synopsis.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/release/meta-json.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/author/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/author/test-eol.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/xt/author/critic.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/dist.ini
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/LICENSE
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/Makefile.PL
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/t/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/t/deprecated.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/t/everything.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/t/00-compile.t
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/lib/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/lib/Dist/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/lib/Dist/Zilla/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/lib/Dist/Zilla/Plugin/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/lib/Dist/Zilla/Plugin/UnusedVarsTests.pm
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/lib/Dist/Zilla/Plugin/Test/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/lib/Dist/Zilla/Plugin/Test/UnusedVars.pm
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/Build.PL
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/corpus/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/corpus/DZ1/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/corpus/DZ1/dist.ini
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/corpus/DZ1/lib/
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/corpus/DZ1/lib/DZ1.pm
x Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2/README.mkdn
Entering Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2
Checking configure dependencies from META.yml
Checking if you have ExtUtils::MakeMaker 6.30 ... Yes (6.63_02)
Checking if you have Module::Build 0.3601 ... Yes (0.40)
Configuring Dist-Zilla-Plugin-Test-UnusedVars-v2.0.2 ... Running Build.PL
Checking prerequisites...
  requires:
    !  Test::Vars is not installed

ERRORS/WARNINGS FOUND IN PREREQUISITES.  You may wish to install the versions
of the modules indicated above before proceeding with this installation

Created MYMETA.yml and MYMETA.json
Creating new 'Build' script for 'Dist-Zilla-Plugin-Test-UnusedVars' version 'v2.0.2'
OK
Checking dependencies from MYMETA.json ...
Checking if you have Moose::Autobox 0 ... Yes (0.12)
Checking if you have Test::More 0.96 ... Yes (0.98)
Checking if you have Test::DZil 0 ... Yes (4.300016)
Checking if you have File::Find 0 ... Yes (1.20)
Checking if you have autodie 0 ... Yes (2.11)
Checking if you have File::Temp 0 ... Yes (0.22)
Checking if you have File::Path 0 ... Yes (2.08_01)
Checking if you have Module::Build 0.3601 ... Yes (0.40)
Checking if you have Test::Output 0 ... Yes (1.01)
Checking if you have warnings 0 ... Yes (1.13)
Checking if you have Test::Vars 0 ... No
Checking if you have namespace::autoclean 0 ... Yes (0.13)
Checking if you have strict 0 ... Yes (1.07)
Checking if you have Dist::Zilla 4 ... Yes (4.300016)
Checking if you have Dist::Zilla::Plugin::InlineFiles 0 ... Yes (4.300016)
Checking if you have Moose 0 ... Yes (2.0602)
==> Found dependencies: Test::Vars
Searching Test::Vars on cpanmetadb ...
--> Working on Test::Vars
Fetching file:///Volumes/MACBOOKAIREXT/Devel/minicpan/authors/id/G/GF/GFUJI/Test-Vars-0.001.tar.gz ... FAIL
! Download file:///Volumes/MACBOOKAIREXT/Devel/minicpan/authors/id/G/GF/GFUJI/Test-Vars-0.001.tar.gz failed. Retrying ... 
! Download file:///Volumes/MACBOOKAIREXT/Devel/minicpan/authors/id/G/GF/GFUJI/Test-Vars-0.001.tar.gz failed. Retrying ... 
! Download file:///Volumes/MACBOOKAIREXT/Devel/minicpan/authors/id/G/GF/GFUJI/Test-Vars-0.001.tar.gz failed. Retrying ... 
! Failed to download file:///Volumes/MACBOOKAIREXT/Devel/minicpan/authors/id/G/GF/GFUJI/Test-Vars-0.001.tar.gz
Fetching http://cpan.celogeek.com/authors/id/G/GF/GFUJI/Test-Vars-0.001.tar.gz ... OK
Unpacking Test-Vars-0.001.tar.gz
x Test-Vars-0.001/
x Test-Vars-0.001/t/
x Test-Vars-0.001/t/lib/
x Test-Vars-0.001/t/lib/NoWarnings.pm
x Test-Vars-0.001/t/lib/Warned4.pm
x Test-Vars-0.001/t/lib/Self.pm
x Test-Vars-0.001/t/lib/NotWarned.pm
x Test-Vars-0.001/t/lib/Warned5.pm
x Test-Vars-0.001/t/lib/Warned6.pm
x Test-Vars-0.001/t/lib/Closure.pm
x Test-Vars-0.001/t/lib/OptimizedAway.pm
x Test-Vars-0.001/t/lib/CompileError.pm
x Test-Vars-0.001/t/lib/Warned7.pm
x Test-Vars-0.001/t/lib/Warned1.pm
x Test-Vars-0.001/t/lib/NoWarningsOnce.pm
x Test-Vars-0.001/t/lib/Foreach.pm
x Test-Vars-0.001/t/lib/Aelemfast.pm
x Test-Vars-0.001/t/lib/StringyEval.pm
x Test-Vars-0.001/t/lib/Warned2.pm
x Test-Vars-0.001/t/lib/Warned3.pm
x Test-Vars-0.001/t/lib/OurVars.pm
x Test-Vars-0.001/t/02_no_warnings.t
x Test-Vars-0.001/t/01_self.t
x Test-Vars-0.001/t/00_load.t
x Test-Vars-0.001/t/04_ignores.t
x Test-Vars-0.001/t/03_warned.t
x Test-Vars-0.001/inc/
x Test-Vars-0.001/inc/Module/
x Test-Vars-0.001/inc/Module/Install.pm
x Test-Vars-0.001/inc/Module/Install/
x Test-Vars-0.001/inc/Module/Install/Makefile.pm
x Test-Vars-0.001/inc/Module/Install/Metadata.pm
x Test-Vars-0.001/inc/Module/Install/WriteAll.pm
x Test-Vars-0.001/inc/Module/Install/Base.pm
x Test-Vars-0.001/Changes
x Test-Vars-0.001/lib/
x Test-Vars-0.001/lib/Test/
x Test-Vars-0.001/lib/Test/Vars.pm
x Test-Vars-0.001/MANIFEST
x Test-Vars-0.001/xt/
x Test-Vars-0.001/xt/03_pod-coverage.t
x Test-Vars-0.001/xt/04_synopsis.t
x Test-Vars-0.001/xt/02_pod.t
x Test-Vars-0.001/xt/01_podspell.t
x Test-Vars-0.001/META.yml
x Test-Vars-0.001/example/
x Test-Vars-0.001/example/test_more.t
x Test-Vars-0.001/example/math-bigint.t
x Test-Vars-0.001/example/cpan.t
x Test-Vars-0.001/MANIFEST.SKIP
x Test-Vars-0.001/README
x Test-Vars-0.001/Makefile.PL
Entering Test-Vars-0.001
Checking configure dependencies from META.yml
Checking if you have ExtUtils::MakeMaker 6.42 ... Yes (6.63_02)
Configuring Test-Vars-0.001 ... Running Makefile.PL
Checking if your kit is complete...
Looks good
Writing Makefile for Test::Vars
Writing MYMETA.yml and MYMETA.json
OK
Checking dependencies from MYMETA.json ...
Checking if you have Test::More 0.88 ... Yes (0.98)
Checking if you have ExtUtils::MakeMaker 6.42 ... Yes (6.63_02)
Checking if you have parent 0 ... Yes (0.225)
Checking if you have B 0 ... Yes (1.34)
Building and testing Test-Vars-0.001 ... cp lib/Test/Vars.pm blib/lib/Test/Vars.pm
Manifying blib/man3/Test::Vars.3
PERL_DL_NONLAZY=1 /Users/geistteufel/perl5/perlbrew/perls/perl-5.16.0/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t
t/00_load.t ......... 1/1 # Testing Test::Vars/0.001
t/00_load.t ......... ok   
t/01_self.t ......... ok   
t/02_no_warnings.t .. 1/? # @used_var is used once in &Aelemfast::foo at t/lib/Aelemfast.pm line 6

#   Failed test 't/lib/Aelemfast.pm'
#   at t/02_no_warnings.t line 14.
# IGNORE CompileError.pm because: Intentinal compile error.
# Looks like you failed 1 test of 22.
t/02_no_warnings.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/22 subtests 
t/03_warned.t ....... ok   
t/04_ignores.t ...... ok   

Test Summary Report
-------------------
t/02_no_warnings.t (Wstat: 256 Tests: 22 Failed: 1)
  Failed test:  7
  Non-zero exit status: 1
Files=5, Tests=34,  0 wallclock secs ( 0.05 usr  0.02 sys +  0.50 cusr  0.12 csys =  0.69 CPU)
Result: FAIL
Failed 1/5 test programs. 1/34 subtests failed.
make: *** [test_dynamic] Error 255
FAIL
Testing Test-Vars-0.001 failed.