dokozero/okcolor

Figma plugin for advanced color picking, with OkLCH, APCA, WCAG and more.

okcolor's Issues

LCH values accuracy

Hi there! Thank you for the plugin 🙌

I noticed that lch.oklch.com and the okColor plugin show really different values for the LCH color mode. E. g. 105 and 26.3 for Chroma.

What could be the reason?

OKLrCH for better Lightness?

Hi,

I'd like to suggest implementing OkLrCH space instead of the current OkLCH for more perceptually uniform lightness.
Björn used it in one of these color pickers: https://bottosson.github.io/misc/colorpicker

Middle gray in OkColor is currently #636363, which is darker than the supposed #777777

Also, OkLCH suffers from an extension of dark values near Black, as you can see from this post:
https://raphlinus.github.io/color/2021/01/18/oklab-critique.html
which makes the interpolation from any light colors to black not very uniform.

I hope you will consider this in the next update.
Thank you for such a great plugin!

Cheers,
Alex

Improve performance and resolution

Let’s backport optimizations from OKLCH color picker. It will allow improving <canvas> resolution.

I am creating this issue to refer it later for other developers.

WebGL sRGB rendering bug in Chrome and Safari

Hello @freydev I'm going to need your help again.

I just released a new version and found a bug in OkLCH's render, I'm not sure if it was there before when we released version 5, maybe Chrome changed something meanwhile in their WebGL engine.

On Chrome and Safari (macOS)

On Figma desktop, Firefox and Edge (macOS)

I reverted the update to see if it was present on the last release (5), tested on Chrome and yes, same weird bug:

It only happens in sRGB, P3 is fine, here is a capture from Chrome:

I looked into the code, especially in f_shader.glsl but I'm not that familiar with WebGL, If you know where it can come from that would be helpful (you'll see that I refactored the whole code and it's now easier to read 👍).

If you need to push a new test version in prod tell me as we can't test dev version in Chrome but only in desktop app which is a shame to debug 😔 . Thanks in advance for your time.

The field order for OKLCH

Hey! Thanks for the update that brings P3. I’m continuing to test it, but at first glance, it looks great!

Every time I use the plugin, I have to wrap my head around this control.

The order here is H, C, and L. This order contradicts the parameter order in the CSS notation and even the space name: LCH.

I would suggest changing the field order according to the selected color space. So it would be H, S, L for HSL, and L, C, H for OKLCH.

Chroma value formatting

The Chroma value looks confusing, because it’s actually 0.319.

Is there a strong reason to format it as 31.9?