Giter Site home page Giter Site logo

Comments (18)

dolanmiu avatar dolanmiu commented on June 18, 2024 1

ok, got gitter working

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

So sorry,

I have updated the library but did not update the README!

It is now:

ng-color-basic
ng-colour-basic-preview

This is because later, I want this library to have other colour picker styles such as ng-color-circle etc.

Apologies!

from ng-color.

nla-brandonjames avatar nla-brandonjames commented on June 18, 2024

I think I will consider contributing to this library as well. There are some visual modifications I wish to make as well as features (like switching the text input from hex, rgb, etc.).

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

that would be great if you could 😄

from ng-color.

nla-brandonjames avatar nla-brandonjames commented on June 18, 2024

I can't get TypeScript hinting when writing it in the app module either. Not sure why that is.

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

hmmm, its probably because of:

vscode-tslint: 'Unsupported TypeScript version: 2.2.1' while validating

i use visual studio code, this is the error i get

from ng-color.

nla-brandonjames avatar nla-brandonjames commented on June 18, 2024

I see. I went to this library because I was having some issues with this color picker I tried first - http://alberplz.github.io/angular2-color-picker/examples/index.html. I like the way this developer's UI looks but he messed up by doing absolute positioning for the element so it was hard for it to play nicely. It has all the features I could want.

from ng-color.

nla-brandonjames avatar nla-brandonjames commented on June 18, 2024

Is it possible to make this directive - saturation-lightness-preview not use 100% height?

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

I have updated the tslint, codelyzer, and typescript dev dependencies, which means tslint now runs

do a pull and do:

npm run lint

it throws a lot of errors, got to fix it up 😂

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

and yes, I had a look at angular2-color-picker and frankly got fed up cos it didn't do what I wanted. And the code was pretty hideous to modify, so I decided to write a better, more flexible library.

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

Is it possible to make this directive - saturation-lightness-preview not use 100% height?

why not 100%? its meant to be a standalone component which can be used by other components. don't change the saturation-lightness-preview, ng-color-basic, and ng-color-basic-preview depend on it

from ng-color.

nla-brandonjames avatar nla-brandonjames commented on June 18, 2024

Do you want to move this conversation to gitter? Glad you're willing to work with me.

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

how I would like this library to work is that ng-color-basic, and ng-color-basic-preview components, and in future, other components are made up of other tiny little functioning components 😄

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

Do you want to move this conversation to gitter? Glad you're willing to work with me.

yes, a gitter would be nice

from ng-color.

nla-brandonjames avatar nla-brandonjames commented on June 18, 2024

I'll open a new issue for the reason I am seeking to change the height of saturation-lightness-preview.

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

ok, create a pull request to fix this

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

Do you want to move this conversation to gitter? Glad you're willing to work with me.

yes, a gitter would be nice

it seems like gitter is down, I cannot load it

from ng-color.

nla-brandonjames avatar nla-brandonjames commented on June 18, 2024

I can bring it up, it may be a problem on your side.

from ng-color.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.