Giter Site home page Giter Site logo

Add Angular 4 support about ng-color HOT 5 CLOSED

leonhh avatar leonhh commented on June 18, 2024
Add Angular 4 support

from ng-color.

Comments (5)

dolanmiu avatar dolanmiu commented on June 18, 2024

But this Plunkr is using Angular 4 though 😖:

http://plnkr.co/edit/N2VKBCrNNIwInwI8PVOu?p=preview

from ng-color.

leonhh avatar leonhh commented on June 18, 2024

Seems to be working in the plunkr indeed but couldn't get it working within my Angular CLI project. I'll try to take a deeper look into it. Do you want to continue support for Angular 2 or is it ok to make it work for Angular 4 or higher only?

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

I believe I read somewhere that Angular 4 is backwards compatible with Angular 2.

So the answer to your question is, yes, it is ok for it to be made compatible for Angular 4

from ng-color.

dolanmiu avatar dolanmiu commented on June 18, 2024

I have re-scaffolded the entire component, and now I am confirm it works for Angular 4 (as I am using it right now in my angular/cli project!

Please re-open if it still doesnt work

Thanks

from ng-color.

leonhh avatar leonhh commented on June 18, 2024

Cheers, working fine now!

Edit: doesn't seem to be working for production/aot builds.

from ng-color.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.