Discuss design decision of underlying implementation

[donavon]

Discuss design decision of underlying implementation

[srmagura]

Hey @tonix-tuft, your analysis is correct. Is the hook's current implementation causing any issues?

We use useRef for the reason you said: If a new handler is defined on each render, we want to avoid adding and removing the event listener on each render.

Your implementation would work too. The caller would always need to remember to useCallback to prevent lots of unnecessary addEventListener / removeEventListener calls. The problem is most people (myself included) are not going to remember to useCallback every single time.

[tonix-tuft]

No no, I was just curious and asked about the design decisions of this hook, no issues. Closing this.

Thank you for your reply!