Giter Site home page Giter Site logo

Comments (2)

zhouzi avatar zhouzi commented on May 24, 2024 2

in second sample if props.handler ever changes your savedHandler.current will not ever get updated

The ref is updated every time the hook is called, regardless of whether props.handler changed or not. So compared to the example with useEffect, it's updated even more often. It shouldn't be an issue since updating a ref doesn't trigger a rerender.

I would not trust the "hold a mutable value", everything should be immutable in React

I agree that mutability is a nightmare that should be avoided at all cost. But that's how React refs work: they hold a mutable value. I think it's ok to use them responsibly.

I'll close this issue, it was really just me being curious 😉

from use-event-listener.

dviry avatar dviry commented on May 24, 2024

my 2 cents: in second sample if props.handler ever changes your savedHandler.current will not ever get updated... I would not trust the "hold a mutable value", everything should be immutable in React ;)

from use-event-listener.

Related Issues (19)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.