Comments (2)
in second sample if props.handler ever changes your savedHandler.current will not ever get updated
The ref is updated every time the hook is called, regardless of whether props.handler
changed or not. So compared to the example with useEffect
, it's updated even more often. It shouldn't be an issue since updating a ref doesn't trigger a rerender.
I would not trust the "hold a mutable value", everything should be immutable in React
I agree that mutability is a nightmare that should be avoided at all cost. But that's how React refs work: they hold a mutable value. I think it's ok to use them responsibly.
I'll close this issue, it was really just me being curious 😉
from use-event-listener.
my 2 cents: in second sample if props.handler ever changes your savedHandler.current will not ever get updated... I would not trust the "hold a mutable value", everything should be immutable in React ;)
from use-event-listener.
Related Issues (19)
- How to add listener for particular group of DOM Elements? HOT 3
- Feature request: have more specific parameter typings
- Hook doesn't allow `element` to be null HOT 1
- add all-contributors HOT 2
- Discuss design decision of underlying implementation HOT 2
- TypeScript definitions in repo do not match with latest version on npm HOT 4
- [Question] Please show example how create another hook based on that HOT 1
- Only start listener after some condition? HOT 8
- Support for event listener options HOT 4
- Do not work, If we pass element as ref HOT 9
- Republish the package with updated peerDependencies 'cause now we have a problem for React 17 HOT 5
- adding duplicate events HOT 1
- Removing event listener HOT 2
- eslint conditional issue
- Saving handler in useEffect() HOT 1
- does not work with chrome.runtime.onMessage
- How to prevent event propagation / bubbling? HOT 1
- How to add listener on DOM element ? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from use-event-listener.