Giter Site home page Giter Site logo

Comments (1)

donmccurdy avatar donmccurdy commented on July 18, 2024

My guess would be that Meshopt's simplifier does something like:

  1. Look for an edge to collapse without exceeding the error metric
  2. Merge the two vertices on that edge
  3. Remove any resulting degenerate triangles

The bench turns into one very long triangle just before it collapses, so probably meshopt thinks it can safely collapse that small edge at the end of the triangle, makes the triangle degenerate, and there's no special case for making sure not to collapse the entire mesh down to nothing.

I can think of arguments for or against that approach ... if you're choosing error ratios carefully based on each object's size in a large s cene, maybe you want it to collapse to nothing at some distance? Or maybe you want to preserve, at minimum, a triangle or a tetrahedron or something like that.

In any case, I think a change in Meshoptimizer would be required to avoid this, or else (slower...) iteratively call simplifyPrimitive(...) until you get a result in the right ballpark.

Also note that an error ratio of just 0.05 is enough to reduce the bench to a 12-triangle box:

import { MeshoptSimplifier } from 'meshoptimizer';
import { weld, simplify } from '@gltf-transform/functions';

await document.transform(
	weld({tolerance: 0.01}),
	simplify({simplifier: MeshoptSimplifier, ratio: 0.01, error: .05, lockBorder: true})
);

I suspect that more aggressive welds, fewer vertex attributes, and lower error thresholds would get you more predictable results. Also note, #802 / #868 are somewhat intended to help with discarding UVs for LOD generation.

from gltf-transform.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.