dorsetdigital/silverstripe-enhanced-requirements

Extends and enhances the Silverstripe requirements system, providing inlining of assets, http/2 server push, deferred css, etc.

silverstripe-enhanced-requirements's Issues

Add option to combine inlined assets

Currently, all inlined assets get added to the page in their own <style> and <script> tags. It would be nice if they could be combined, so that all the CSS which has been inlined and all the JS which has been inlined are injected into a single tag.

This should be a configurable option, and separated out for CSS and JS... not least of all because it relies on people adding all the right semi-colons, etc. to their scripts to make sure things don't break!

Exception class namespaces missing

In the themedCSS() and themedJavascript() methods, when a file is not present, an InvalidArgumentException is thrown.
There's a missing 'use' statement in the custom backend class, which means that when this happens, a not found error is thrown instead of the expected method:

'[Emergency] Uncaught Error: Class 'DorsetDigital\EnhancedRequirements\View\InvalidArgumentException' not found'

Adding use InvalidArgumentException; should sort it

theme methods not working

The themedCSS and themedJavascript methods don't currently accept the third parameter.
The signature of these methods in the Requirements doesn't include the parameters to be able to pass to the backend.

Need to use injector to replace Requirements with an extended version to allow for the method signatures to be changed.

Optional inline Type

Can you make the "type" attribute optional for inline JavaScript?

Enhanced_Backend.php => Line: 98

The type attribute is unnecessary for JavaScript resources.

Source: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#attr-type