The amacs from dotkom

Show error message to user if application failed

Is your feature request related to a problem? Please describe.
If the receiving end is not working, the user should be alerted that something is wrong and that they should try again later.

Describe the solution you'd like
A big (red) error message on the top of the screen, or a modal, alerting the user of the problem.

Additional context
If opptak.online is a standalone application, it is not necessarily down when other parts of the eco system (like online.ntnu.no) is down. This may result in several in users having to rewrite and resend maybe several applications, stressing the new students that they may lose the possibility to be a part of Online, stressing the people that organize the applications, and stress the leaders that have to find time/room/interviewers to host.

Better "Application sent"-confirmation. The text is too little information. New page?

Google analytics

Add help text above application text

Text from splash:

Send inn din søknad hvor du forteller litt om deg selv, din motivasjon for vervet, hvilke komiteer du kunne tenke deg å være med i, og evt. tidligere erfaring fra lignende arbeid. Hold gjerne søknaden kort ettersom at vi arrangerer et intervju med hver søker så vi kan bli enda bedre kjent med deg.

Fill in name and email when logged in and disable fields.

When logging in the user's name and email should show up in the input fields so the user can verify that everything is correct. These fields and the toggle switch should also be disabled until the user logs out.

Favicons

Look at mobile scaling a bit, especially on the application page

Input:disabled doesn't work on Edge

Split application process into two pages

First page should show an overview of the committees while second page is the application itself.

Display deadlines for the current application period

Is your feature request related to a problem? Please describe.
The user should be able to see when the application period deadline is, so that they can apply before it.

Describe the solution you'd like

Display to the user when the deadline is if the period is accepting applications.
Display when the period stars if it has not started yet.
Display when it was when the period has ended.
Display something general like 'we'll give you a little extra time' when withing the deadline_delta of an application period, as not to give away when it will actually close, as we'll want is ASAP when the deadline has passed.

Describe alternatives you've considered
Would be kinda strange to not show it when we have the information.

Additional context
The information is there. Let us use it!

Add fetch polyfill

Text for login toggle switch

Fyll inn brukerinfo selv

Logout is broken

Describe the bug
The user is not logged out when they click 'logg ut'

To Reproduce
Steps to reproduce the behavior:

Go to '/application'
Click on 'Logg inn'
Click on 'Logg ut'
See that you are in fact not logged out

Expected behavior
The user should be logged out

Clicking info card on mobile doesn't remove border after click

Create a base CSS that we can compose off of

We define the same values for various CSS classes all over the app at the moment. We probably shouldn't.

Handle denying/aborting SSO login

Handle denying SSO login (you cannot click "no online.ntnu.no-account" any more if you start the login process)
Handle closing SSO login window preemptively (you cannot click "no online.ntnu.no-account" any more if you start the login process)

Deploy production build to AWS S3

Production build is currently deployed built to a local folder on Nansen.
Since this is just static files, it could easily be deployed to an S3 bucket on AWS to reduce strain on Nansen.

Serve images using webpack

More texts in general

Don't close CommitteeInfo if clicking on contents (e.g. to mark for copy/paste)

Scroll to page top when going from one page to the other

Scrolling down on the front page and then going to the next page will make the second page be at the same position as where you were on the first page. This is not very intuitive, so we should make sure the browser is scrolled to the top when the user changes pages.

Add CSS hover and active states on most components

Add onChange to ToggleSwitch component

ToggleSwitch should notify parent when it's state changes.

Add extra committees like Bankom to the information-list

Is your feature request related to a problem? Please describe.
Users should be able to see the application description of committees like Bankom even though they should not be able to apply for them.

With the new system this would probably also be nice include as part of the OW4 model, as not all application periods should have Bankom visible.

Describe the solution you'd like
Change models in back-end:
Could either have an 'extra_committees' field or something on the relation between a committee and the application period like can_apply. Would require refactor of relation though.

Describe alternatives you've considered
Could hack it together in the front-end in some way by always fetching bankom and applying them to the list 🤢

Additional context
This was a feature we previously had, but it was not added in the first iteration of the back-end refactor.

Borders on toggle switch look weird on Firefox

Display application periods with a single committee a bit differently

Is your feature request related to a problem? Please describe.
We do support application periods with just a single committee, and they may behave a bit differently.

Describe the solution you'd like
When the current application period only has a single committee we could either not display the information screen, or just display the single application test a bit more prominently.

We could change a bit of how the committee selection is displayed as well.
It should just show a single committee, and maybe the application description.
You should not be able to select or de-select it, as it is implicitly selected because its the only committe.

Describe alternatives you've considered
We could just not, but I would like for us to have it.

Additional context
This may allow for the app to be used for a bit more than just committee applications directly. Like Node committee leader application, and applications for being a 'fadder'.

Move away from class based components

Is your feature request related to a problem? Please describe.
We use unsafe lifecycle hooks and all of that. Maybe move away from classes altogether. Make us ready for concurrent mode and all of that.

Describe the solution you'd like
Move Application form state from local state to a reducer/slice from Redux Toolkit, that is the most crucial class component.
The rest should hopefully be trivial to convert.

Describe alternatives you've considered
Not upgrading would be bad in the long run.

Additional context
Concurrent mode is still en experimental feature of React, and it won't be enforced even when it is released. But having it would still be cool.

Error: Popup window closed

Happens if a user closes the SSO login window. Can be handled. I can look into it.

https://sentry.io/dotkom/supreme-guacamole/issues/334103553/

Error: Popup window closed
  at e._error (vendor.63690dea81dc53e11cd6.js:1)
  at e._checkForPopupClosed (vendor.63690dea81dc53e11cd6.js:1)
  at n (vendor.63690dea81dc53e11cd6.js:1)

Create service for posting and fetching applications.

App should require phone number when registering

Feature request.

Opptak.online should require phone number when registering as this is immensely useful when conducting the interviews.

CommitteeInfo desktop scaling

The application is designed mobile-first, so desktop could utilize space a bit more.

Mark committee as selected when clicking

Use px on borders

Rem is rounded to nearest pixel and apparently not all browsers round the same way.

Check contrasts and other a11y things

Disable submit until all fields filled

Add Casual Gaming to the commitees you can apply to

Users should be required to write what year they study.

Feature request.

It's very useful for the people conducting the interviews to know what year of their degree the applicants are starting. If we later make more powerful tools for use in organizing interviews and the picking of candidates, this could be useful for sorting.

dotkom / amacs Goto Github PK

amacs's People

Contributors

Stargazers

Watchers

Forkers

amacs's Issues

Recommend Projects

Recommend Topics

Recommend Org