dotkom/glowing-fortnight

The next generation of the Online Splash!

glowing-fortnight's Issues

Display "faddergruppe" highscores

Describe the solution you'd like
Implement a Google Sheet that the appropriate groups can use to update the scores for different "faddergrupper"

Additional context
Uses 'googleapis' package for Node.js and authentication via S3

Fix background-color of date on mobile

Describe the bug
The background color of the date is correct on larger display. When the screen gets below 720px, it uses another background color (primary).

Expected behavior
It should use the same color as the larger screen does (primaryDarken45)

Screenshots

Add hashes to static files

Prevents js/css from being cached after shipping a new version.
https://webpack.js.org/guides/caching/

This will also require the index.html file to be generated dynamically.

The last day/event on the calendar remains several days later

This might be due to the active event function. It's not all that important however, as the splash is usually tucked away neatly when the last day is over anyways.

Add a button to re-hide previous events

I'm sure this would rarely be used, but it doesn't seem like all that much work and somebody could want to use it.

Partners are not center aligned

This is due to this rule, which is used to space the partner logos. This affects the main partner logo, but the row underneath is also shifted slightly due to the last partner having a margin that isn't needed.
You could write up a fix, but I'd suggest maybe looking into rewriting the component with flexbox in mind.

First event never enters sorting process and goes directly to daysEvents

This results in the first event being sorted based on the next event.

Entire content of events in calendar is clickable

The event description is currently rendered as a clickable for toggling expansion of the event, which makes it impossible to mark text in some browsers, or possibly also to click markdown-parsed urls.

Add title and alt text to img tags

As was seemingly wanted by myth

Update for 2020

We need to do the 2020 update, below is a list.

Sjekkliste:

• Lese igjennom ny på informatikk
• Oppdatere ITEX linken
• Legge inn startdato for fadderukene (kommer i #66)
• Lage og linke til 2020 infoside (lenke kommer i #66)
• Lage fadderuke-events i OW
• Oppdatere API_EVENTS_URL (kommer i #66)
• Lese igjennom ditt liv som Onliner
• Oppdatere komitesøknadsfristen
• Oppdatere sponsorlogoer
• Coronainfo ?
• Vurdere om man skal gjøre andre endringer
• Glede seg til fadderuka

Clicking on events feel too aggressive on desktop

See #10 (comment)

Should preDays be based on end_time of events?

As pondered by @myth in Slack. This would fix the #15 by removing the problem entirely. This allows for seeing ongoing events as future events while still hiding events that have passed.

Dynamic dates and logos

To avoid manual labor every year we can consider extending the API a bit.

Changes required each year are:

• Updating API URL to only fetch events after a set date
  A potential fix for this is to only consider events for the current year instead.
• Fadderuke start date
  Can be added to API and set by velkom.
• Committee application deadline
  Can be added to API and set by velkom.
• Theme logo
  Can be added to API and set by velkom. If the logo has not been set a generic one is used instead.
• Partner logos
  Can be added to API and set by velkom. However, this can be a bit more tricky as manual adjustments are sometimes needed.

Events can't span over midnight

Unfortunately the current calendar logic doesn't allow for events to span over midnight. It makes the event jump over to the next day from what I can gleam. It's not a huge issue, as we just prompt velkom to make events that end at 23:59 the day they start, but it would be swell to include this.

Update ow splash text

Foreløpig er det ubekreftet informasjon om oppstart av fadderukene for master.

Display something else than "loading" when there are no events

Should be a more visible link to Opptak.online from splash

Cross-issue from dotkom/onlineweb4#2094

Previous days are shuffled into preDays at 02:00, not 00:00

This is due to timey wimey zone stuff. The if-statement that guards the preDays.push evaluates as false for two hours between midnight and 02:00 when we want it to evaluate to true. The cause seems to be that the two Dates that are compared aren't in the same timezone (?).

Remove old sample data from the code

Now that the splash is hooked up to the API, there's hardly any reason to pump sample data into the calendar component.

Replace pirate logo with a generic logo