dotnet-architecture/grpc-for-wcf-developers

gRPC for WCF Developers guidance samples

grpc-for-wcf-developers's Issues

AwaitCancellation usage in FullStockTickerService

In the FullStockTickerService example that uses bidirectional streaming it feels to me like the use of the AwaitCancellation() method that creates a task that completes when the CancellationToken of the ServerCallContext is cancelled is unneccesary and has just been caried over from the example with the single stream without much thought.

Why not just await the HandleActions() method directly there since its task also completes when the same CancellationToken is cancelled?

Furthermore, if an exception is thrown in the HandleActions() method for some reason in a more complex example it will not cancel the CancellationToken and the program will stop reading new actions but the program will not stop because it will continue waiting for the token to be cancelled at the call to AwaitCancellation(). This seems rather dangerous to me in a real world scenario.

Error while running on Mac OS

Grpc.Core.RpcException: Status(StatusCode=Internal, Detail="Error starting gRPC call. HttpRequestException: The SSL connection could not be established, see inner exception. IOException: The handshake failed due to an unexpected packet format.")
at TraderSys.Portfolios.ClientConsole.Program.Main() in

The server is up

Authorize attribute on basic (non-Auth) TraderSys sample causes error.

The sample could be more approachable if you remove the Authorize attribute from PortfolioService.cs

I get this exception when I run the sample:

   at Grpc.Net.Client.Internal.GrpcCall`2.ValidateHeaders()
   at Grpc.Net.Client.Internal.GrpcCall`2.<SendAsync>d__76.MoveNext()
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.ConfiguredTaskAwaitable.ConfiguredTaskAwaiter.GetResult()
   at Grpc.Net.Client.Internal.GrpcCall`2.<GetResponseHeadersAsync>d__67.MoveNext()

And the output clued me in that authorization is expected:

System.InvalidOperationException: Endpoint gRPC - /PortfolioService.Portfolios/Get contains authorization metadata, but a middleware was not found that supports authorization.
Configure your application startup by adding app.UseAuthorization() inside the call to Configure(..) in the application startup code. The call to app.UseAuthorization() must appear between app.UseRouting() and app.UseEndpoints(...).
   at Microsoft.AspNetCore.Routing.EndpointMiddleware.ThrowMissingAuthMiddlewareException(Endpoint endpoint)
   at Microsoft.AspNetCore.Routing.EndpointMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Routing.EndpointRoutingMiddleware.Invoke(HttpContext httpContext)
   at Microsoft.AspNetCore.Diagnostics.DeveloperExceptionPageMiddleware.Invoke(HttpContext context)

WCF migration

Few questions about the statement "Migrate a WCF solution to gRPC":

1. Is it possible to reach gRPC service using a "net.tcp" protocol endpoint?
2. Am I correct that any existing client needs at least to change namespace of the old client instance to reach the gRPC migration result?
3. May I call a gRPC .Net Core server from a .NET Framework client and which is the way to add the relative Connected Service? Have I to point out the .proto file as for a .Net Core client?

Upgrade to net7

Create Directory.Dependencies.props File

Add all nuget package versions to it. Might need one per sample/solution but better if can have just one.

Set TargetFramework in it as well, or else also add a Directory.Build.props file with that.

deploy tradersys on IIS 10 throws exception

I tried to host the WCF service in the tradersys on IIS version 10 on Windows 10, which throws an exception:

The AutofacServiceHost.Container static property must be set before services can be instantiated. Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.InvalidOperationException: The AutofacServiceHost.Container static property must be set before services can be instantiated.

I'm aware of this issue as discussed several times on stackoverflow, such as this post. Yet the code by Microsft contains the appropriate autofac container.

While it works just fine using the Visual Studio and IISExpress.
Did I miss anything on deploying this as a service?